stella.stamenova added a comment.

In https://reviews.llvm.org/D53208#1264056, @jingham wrote:

> We do compose the decorators in a bunch of places (like Shafik's usage here). 
>  That will work more naturally if the categories that the decorators assert 
> are as decoupled as possible.  So the statement about macos version should 
> only skip the test if the os is macos, and make no comment about other os's.  
> That decouples the macos_version test from the oslist test, and allows 
> something like the construct in the tests that Shafik wrote, which seems a 
> pretty natural way to express "if on macOS, it has to be version > x, 
> otherwise it has to be clang > y".


I updated the change to support that. Could you have a look?


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53208



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to