Author: labath
Date: Tue Jun 7 16:29:46 2016
New Revision: 272062
URL: http://llvm.org/viewvc/llvm-project?rev=272062&view=rev
Log:
Revert "Make lldbinline.py regenerate the Makefile each time it builds."
This reverts commit r272024 as it is not windows-compatible.
Modified:
lldb/trunk/pac
labath added subscribers: zturner, labath.
labath added a comment.
Hi, I have reverted this commit, as it makes a number of assumptions, which are
not true on windows. Please see comments for details.
If you need help testing out a revised version on windows, let me know. I think
Zachary will b
labath created this revision.
labath added reviewers: chying, gkistanova.
labath added a subscriber: lldb-commits.
For the time being they are run with flunkOnFailure=False. If they prove to
be reliable. I will switch them to True.
http://reviews.llvm.org/D21159
Files:
zorg/buildbot/builders/L
labath added a reviewer: clayborg.
labath added a comment.
Native register context changes seem legit. Adding Greg for the Target.cpp
changes.
http://reviews.llvm.org/D21164
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llv
On 8 June 2016 at 17:24, Omair Javaid wrote:
> On 26 May 2016 at 18:07, Pavel Labath wrote:
>> These tests pass on soft float targets (e.g. android), so we should
>> not disable it there. I think we should figure out a way to make it
>> possible to disambiguate these. Right now it is possible to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272311: [zorg] Add a step to run unit tests to the scripted
LLDB builder (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D21159?vs=60121&id=60235#toc
Repository:
rL LLVM
http:
labath updated this revision to Diff 60256.
labath added a comment.
This revision is now accepted and ready to land.
Use an auxv-based approach for detecting the architecture in case of mips.
http://reviews.llvm.org/D20368
Files:
source/Plugins/Process/Linux/NativeProcessLinux.cpp
source/Pl
labath added a comment.
@nitesh.jain could you give the new version one more spin. I tried it on the
auxv files you sent me, and it should work, but maybe there are other issues we
did not notice. And thank you again for the help and all the patience.
Everyone else: The new version has only mip
Author: labath
Date: Thu Jun 9 17:39:36 2016
New Revision: 272326
URL: http://llvm.org/viewvc/llvm-project?rev=272326&view=rev
Log:
Enable some tests on linux
This enables a couple of tests which have been shown to run reliably on the
linux x86 buildbot. If you see a failure after this commit, f
labath added a comment.
So, I'll let Jason be the definitive judge here, but I have to say I don't like
this solution.
Computing 10 frames significantly increases the amount of processing needed to
get some result. Most importantly, it increases the latency, as it will cause a
lot more data to
labath added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:438
@@ +437,3 @@
+// The auxiliary vector consists of a sequence of key-value pairs, where
key and value are of
+// the pointer size for the architecture that the
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
The overall change looks good, but please also add a test which specifically
tests for watchpoints at unaligned addresses. Last time I checked, we all
watchpoint tests were passing (
labath added a comment.
I think this idea in general is more acceptable, but we'll need an OK from
Jason on the details.
Also, we should figure out a way to add a test for this. We should definitely
add a more deterministic test and not rely on TestPrintStackTraces to check
this functionality.
labath accepted this revision.
labath added a comment.
Seems to run fine on linux now. Thanks for investigating this. We'll monitor
the buildbots and let you know if anything bad happens. ;)
BTW. your comment in ControlPrivateStateThread seems to indicate that the linux
behavior is inconsistent
labath added a comment.
In http://reviews.llvm.org/D21221#457329, @ravitheja wrote:
> @labath In order to reproduce this situation without the help of standard
> library, I would have to write handwritten assembly and the CFI directives
> for that, is that fine ?
Yes, I think that's fine. Obv
labath created this revision.
labath added a reviewer: tberghammer.
labath added subscribers: lldb-commits, omjavaid, nitesh.jain, uweigand.
This removes the last usage of the Platform plugin in NPL. It was being
used for determining the architecture of the debugged process. I replace
the call tha
labath abandoned this revision.
labath added a comment.
I am abandoning this in favor of http://reviews.llvm.org/D21324, which achieves
the same result (no Platform plugin), but still uses the elf-parsing method to
keep everything working as is now.
You can give it a try if you want, but I don'
Author: labath
Date: Tue Jun 14 12:30:52 2016
New Revision: 272686
URL: http://llvm.org/viewvc/llvm-project?rev=272686&view=rev
Log:
Remove Platform usages from NativeProcessLinux
Summary:
This removes the last usage of the Platform plugin in NPL. It was being
used for determining the architectur
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272686: Remove Platform usages from NativeProcessLinux
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D21324?vs=60679&id=60705#toc
Repository:
rL LLVM
http://reviews.llvm.org
OK, i see. Thanks for the explanation. This may actually be some
windows specific thing then, as I remember zachary mentioning they
have some flakyness issues there.
BTW, this has sped up the LLDB test suite nearly 2x, so thanks a lot
for that. :)
pl
On 14 June 2016 at 17:13, Cameron wrote:
>
labath added a subscriber: labath.
labath added a comment.
OK, i see. Thanks for the explanation. This may actually be some
windows specific thing then, as I remember zachary mentioning they
have some flakyness issues there.
BTW, this has sped up the LLDB test suite nearly 2x, so thanks a lot
for
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thanks for adding the test. I have some nits about some details of the test. If
you agree with them, you can commit the updated version without additional
review.
Comment at
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
In general, the idea sounds reasonable.
I think you should be able to achieve the same effect by adding the library to
LLDB_SYSTEM_LIBS in LLDBDependencies.cmake. This should be a mu
Author: labath
Date: Wed Jun 29 05:16:14 2016
New Revision: 274116
URL: http://llvm.org/viewvc/llvm-project?rev=274116&view=rev
Log:
XFAIL tests which fail with gcc on linux
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/top-level/TestTopLevelExprs.py
lldb/trunk/
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm, thanks.
Repository:
rL LLVM
http://reviews.llvm.org/D20464
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.o
labath added a comment.
Is AdbClient getting big enough to deserve a couple of unit tests? All it would
take is to add the ability to specify the address to connect to and make a
small mock server that listens at that address?
http://reviews.llvm.org/D21770
_
labath added a subscriber: labath.
labath added a comment.
Please also add a test for this in `TestLinuxCore.py`.
There shouldn't be a need to add a new core file, you can just add an
additional check to the `do_test` method that verifies the right memory regions
(which you can pass in the same
Author: labath
Date: Wed Jun 29 08:58:27 2016
New Revision: 274125
URL: http://llvm.org/viewvc/llvm-project?rev=274125&view=rev
Log:
Remove platform plugins from lldb-server
Summary:
This removes the last usage of Platform plugins in lldb-server -- it was used
for launching child
processes, wher
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274125: Remove platform plugins from lldb-server (authored
by labath).
Changed prior to commit:
http://reviews.llvm.org/D20440?vs=57807&id=62220#toc
Repository:
rL LLVM
http://reviews.llvm.org/D2044
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
ok, sounds good.
http://reviews.llvm.org/D21770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
labath created this revision.
labath added a reviewer: tfiala.
labath added a subscriber: lldb-commits.
This is a slightly reworked version of D16322, which I had reverted because it
did not do what it
advertised. Differences from the previous version are:
- moved the code for cleaning up the rem
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
One of the tests there does not work with gcc, so I'm spinning that off into a
separate test, so
that we can XFAIL it with more granularity.
I am also renaming the test to reflect the fact t
labath added a subscriber: labath.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:497-505
@@ +496,11 @@
+ {
+bool fre;
+bool fr1;
+IsFR1_FRE (fr1, fre);
+
+// fr1 fre fpu_reg_size
+
Author: labath
Date: Mon Jul 4 04:27:53 2016
New Revision: 274490
URL: http://llvm.org/viewvc/llvm-project?rev=274490&view=rev
Log:
Join TestTlsGlobal tests again and use the proper decorator
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/tls_globals/TestTlsGlobals.py
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274491: Enable test log collection from remote debug servers
(take 2) (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D21898?vs=62369&id=62658#toc
Repository:
rL LLVM
http://r
Author: labath
Date: Mon Jul 4 04:59:45 2016
New Revision: 274491
URL: http://llvm.org/viewvc/llvm-project?rev=274491&view=rev
Log:
Enable test log collection from remote debug servers (take 2)
Summary:
This is a slightly reworked version of D16322, which I had reverted because it
did not do wh
Author: labath
Date: Mon Jul 4 08:07:35 2016
New Revision: 274499
URL: http://llvm.org/viewvc/llvm-project?rev=274499&view=rev
Log:
Remove SIGPIPE handler in LLGS
It is sufficient to set the handeler to SIG_IGN, to get the desired behaviour.
Also, the handler
calling a lot of signal-unsafe func
Author: labath
Date: Mon Jul 4 08:49:46 2016
New Revision: 274505
URL: http://llvm.org/viewvc/llvm-project?rev=274505&view=rev
Log:
Split TestTemplateIntegerArgs test into two
Summary:
One of the tests there does not work with gcc, so I'm spinning that off into a
separate test, so
that we can X
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274505: Split TestTemplateIntegerArgs test into two
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D21923?vs=62478&id=62681#toc
Repository:
rL LLVM
http://reviews.llvm.org/D2
labath created this revision.
labath added a reviewer: tberghammer.
labath added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
We are seeing infrequent failures to launch the inferior process on android.
The failing call
seems to be execve(). This adds more logging
labath updated this revision to Diff 62842.
labath added a comment.
run clang-format over the patch
http://reviews.llvm.org/D22039
Files:
source/Plugins/Process/Linux/NativeProcessLinux.cpp
source/Plugins/Process/Linux/NativeProcessLinux.h
Index: source/Plugins/Process/Linux/NativeProcessL
Author: labath
Date: Wed Jul 6 08:18:50 2016
New Revision: 274624
URL: http://llvm.org/viewvc/llvm-project?rev=274624&view=rev
Log:
[LLGS] Log more precise errors during inferior launch
Summary:
We are seeing infrequent failures to launch the inferior process on android.
The failing call
seems
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274624: [LLGS] Log more precise errors during inferior
launch (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D22039?vs=62842&id=62854#toc
Repository:
rL LLVM
http://reviews.l
labath added a comment.
What is the performance implication of this?
http://reviews.llvm.org/D22040
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good.
Please also run clang-format over the patch (also when I don't request it, i
tend to forget about that).
Comment at: source/Plugins/Platform/Android/AdbClient.cp
labath added a comment.
You raised good points here, Luke.
I've thought about the quoting issue, but as you have already noticed there is
no way to pass arguments containing quotes to adb correctly. Thinking about it
more, what we could do is detect this situation (look for `'` in the file name
Author: labath
Date: Thu Jul 7 10:45:57 2016
New Revision: 274762
URL: http://llvm.org/viewvc/llvm-project?rev=274762&view=rev
Log:
Bump up timeout in TestCallWithTimeout
remote targets need a bit more time to get their act together
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expre
Author: labath
Date: Thu Jul 7 10:46:00 2016
New Revision: 274763
URL: http://llvm.org/viewvc/llvm-project?rev=274763&view=rev
Log:
[LLGS] Work around an adb bug on Android <=M
On android M it can happen that we get a ETXTBSY, when we try to launch the
inferior. Sleeping
and retrying should hel
labath created this revision.
labath added reviewers: chying, gkistanova.
labath added a subscriber: lldb-commits.
The unit tests appear to be running reliably, so let's make them affect the
build output. (All scripted LLDB builtbots are still marked as experimental
though.)
http://reviews.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274831: [zorg] Remove flunkOnFailure=False from the scripted
LLDB builder unittests (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D22097?vs=63086&id=63187#toc
Repository:
rL
labath added a comment.
Thanks for adding the additional checks. Looks good apart from the clang-format
changes. This looks like the llvm style. I am not sure how you've run this but
it does not seem to have picked up LLDB's `.clang-format` file.
Are you using git? You need to set `clangFormat.
labath added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:98
@@ +97,3 @@
+const ArchSpec &arch =
m_thread.GetProcess()->GetTarget().GetArchitecture();
+RegisterInfo* reg_info = const_cast(m_reg_info.GetRegisterInfoAtIndex (re
labath added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:98
@@ +97,3 @@
+const ArchSpec &arch =
m_thread.GetProcess()->GetTarget().GetArchitecture();
+RegisterInfo* reg_info = const_cast(m_reg_info.GetRegisterInfoAtIndex (re
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
Process::SetExitStatus was popping the process io handler and resetting
m_process_input_reader
shared pointer, which is not a safe thing to do as the function is called
asynchronously and
ot
labath created this revision.
labath added a reviewer: tfiala.
labath added a subscriber: lldb-commits.
LLDBTestResult.hardMarkAsSkipped marked the whole class as skipped when the
first class in the
test failed the category check. This meant that subsequent tests in the same
class did not run
ev
labath added a comment.
Btw, I tried to make a unit test for this, but I could not get your meta test
runner to work -- the existing test was failing for me (it was not getting any
events apart from the global "test run started"/"test run finished" events). Do
you have any idea what could be wr
labath added a comment.
Given that this "file" comes straight from the kernel, i don't think asserting
here is necessarily a bad thing, but I don't really care either way...
http://reviews.llvm.org/D22211
___
lldb-commits mailing list
lldb-commits@
labath created this revision.
labath added a reviewer: clayborg.
labath added subscribers: tberghammer, lldb-commits.
void typedefs do not have a DW_AT_type attribute, so we end up with an empty
encoding_uid
variable. These don't need to be looked up and trying to look that will assert
in a debu
labath requested a review of this revision.
labath added a comment.
Sean, could you take a quick look at this one as well?
http://reviews.llvm.org/D17856
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: labath
Date: Tue Jul 12 04:26:30 2016
New Revision: 275164
URL: http://llvm.org/viewvc/llvm-project?rev=275164&view=rev
Log:
Dwarf parser: don't lookup void typedefs in the DWO
Summary:
void typedefs do not have a DW_AT_type attribute, so we end up with an empty
encoding_uid
variable. Th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275164: Dwarf parser: don't lookup void typedefs in the DWO
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D22218?vs=63499&id=63657#toc
Repository:
rL LLVM
http://reviews.llv
Author: labath
Date: Tue Jul 12 04:37:55 2016
New Revision: 275165
URL: http://llvm.org/viewvc/llvm-project?rev=275165&view=rev
Log:
Fix a race on process exit
Summary:
Process::SetExitStatus was popping the process io handler and resetting
m_process_input_reader
shared pointer, which is not a s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275165: Fix a race on process exit (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D22209?vs=63481&id=63659#toc
Repository:
rL LLVM
http://reviews.llvm.org/D22209
Files:
lld
Author: labath
Date: Tue Jul 12 10:07:18 2016
New Revision: 275173
URL: http://llvm.org/viewvc/llvm-project?rev=275173&view=rev
Log:
[test] Fix category-based skipping
Summary:
LLDBTestResult.hardMarkAsSkipped marked the whole class as skipped when the
first class in the
test failed the category
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275173: [test] Fix category-based skipping (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D22213?vs=63487&id=63679#toc
Repository:
rL LLVM
http://reviews.llvm.org/D22213
Fil
labath created this revision.
labath added a reviewer: jasonmolenda.
labath added a subscriber: lldb-commits.
This adds the knowledge of the DW_CFA_GNU_args_size instruction to the eh_frame
parsing code.
Right now it is ignored as I am unsure how is it supposed to be handled, but
now we are at l
Author: labath
Date: Tue Jul 12 10:13:11 2016
New Revision: 275175
URL: http://llvm.org/viewvc/llvm-project?rev=275175&view=rev
Log:
[NPL] Increase ETXTBSY workaround sleep
10ms does not seem to be enough all the time, go to 50.
Modified:
lldb/trunk/source/Plugins/Process/Linux/NativeProcess
labath added a comment.
I used the command you mentioned in the original patch:
$ python -m unittest discover -s test/src -p 'Test*.py'
FF
==
FAIL: test_with_function_filter
(TestCatchInvalidDecorator.TestCatchInvalidDec
Author: labath
Date: Tue Jul 12 11:06:31 2016
New Revision: 275185
URL: http://llvm.org/viewvc/llvm-project?rev=275185&view=rev
Log:
Increase "process load" timeout
Loading a dynamic library can take quite a long time, since it triggers a
number of
shared-library-event stops for dependent librar
labath added a comment.
lgtm
http://reviews.llvm.org/D22286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
looks good as far as I can tell
I second the idea of running clang-format over the patch.
Repository:
rL LLVM
http://reviews.llvm.org/D22284
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/
labath added a subscriber: labath.
labath added a comment.
Mostly just comments about the test from me.
Comment at: include/lldb/Core/Module.h:240
@@ -239,2 +239,3 @@
FindFirstSymbolWithNameAndType (const ConstString &name,
+const lldb::
Author: labath
Date: Wed Jul 13 05:55:24 2016
New Revision: 275260
URL: http://llvm.org/viewvc/llvm-project?rev=275260&view=rev
Log:
Add "support" for DW_CFA_GNU_args_size to the unwinder
Summary:
This adds the knowledge of the DW_CFA_GNU_args_size instruction to the eh_frame
parsing code.
Right
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275260: Add "support" for DW_CFA_GNU_args_size to the
unwinder (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D22266?vs=63678&id=63792#toc
Repository:
rL LLVM
http://reviews.
labath added a comment.
In http://reviews.llvm.org/D22266#482626, @jasonmolenda wrote:
> This is fine - is there a binary using this? I'd love to see the assembly
> code and a dump of the eh_frame CFI.
>
> I googled around and didn't find much about DW_CFA_GNU_args_size but in the
> libunwind
Author: labath
Date: Thu Jul 14 05:43:24 2016
New Revision: 275394
URL: http://llvm.org/viewvc/llvm-project?rev=275394&view=rev
Log:
mark newly failing tests as XFAIL
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py
lldb/trunk/p
Author: labath
Date: Thu Jul 14 05:43:21 2016
New Revision: 275393
URL: http://llvm.org/viewvc/llvm-project?rev=275393&view=rev
Log:
[test] [linux] define PR_SET_PTRACER constants if the system does not provide
them
Android API <= 16 header do not have these symbols defined, but the kernel does
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm.
Comment at: cmake/modules/LLDBStandalone.cmake:61
@@ -60,2 +60,3 @@
set(LLVM_MAIN_INCLUDE_DIR ${INCLUDE_DIR} CACHE PATH "Path to llvm/include")
+ set(LLVM_DIR ${LLVM
labath created this revision.
labath added a reviewer: tberghammer.
labath added a subscriber: lldb-commits.
This removes one level of indirection, which was just packing and repacking
launch args into
different structures. NFC.
https://reviews.llvm.org/D22357
Files:
source/Plugins/Process/Li
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
I believe the symbol names more consistent.
In case a symbol has DW_AT_linkage_name (e.g. clang puts it everywhere), we
print the demangled
linkage name, which does not contain the '::'. If
labath created this revision.
labath added reviewers: tfiala, zturner.
labath added a subscriber: lldb-commits.
We've run into this problem when the test errored out so early (because it
could not connect to
the remote device), that the code in D20193 did not catch the error. This
resulted in th
labath added a comment.
I think this also makes the code in https://reviews.llvm.org/D20193 obsolete.
If this goes in, I can create a follow-up to remove that.
https://reviews.llvm.org/D22404
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
Author: labath
Date: Fri Jul 15 05:18:15 2016
New Revision: 275544
URL: http://llvm.org/viewvc/llvm-project?rev=275544&view=rev
Log:
[NPL] Simplify process launch code
Summary:
This removes one level of indirection, which was just packing and repacking
launch args into
different structures. NFC.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275544: [NPL] Simplify process launch code (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D22357?vs=63973&id=64118#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22357
F
Author: labath
Date: Fri Jul 15 07:19:28 2016
New Revision: 27
URL: http://llvm.org/viewvc/llvm-project?rev=27&view=rev
Log:
Fix TestDarwinNSLogOutput for windows
pexpect python package does not exist on windows
Modified:
lldb/trunk/packages/Python/lldbsuite/test/macosx/nslog/TestDa
labath added a comment.
I don't think the original version tried to make a nice error message. It got
flagged as an error, and that was it. Now it will get flagged as exceptional
exit.
In any case we will print out the stderr/stdout (I changed this from
stderr-only, because in my case the only
labath created this revision.
labath added a reviewer: tberghammer.
labath added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
We've had two copies of code for launching processes:
- one in NativeProcessLinux, used for launching debugged processes
- one in
Author: labath
Date: Mon Jul 18 06:27:19 2016
New Revision: 275782
URL: http://llvm.org/viewvc/llvm-project?rev=275782&view=rev
Log:
[test] Report error when inferior test processes exit with a non-zero code
Summary:
We've run into this problem when the test errored out so early (because it
coul
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275782: [test] Report error when inferior test processes
exit with a non-zero code (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D22404?vs=64115&id=64297#toc
https://reviews.l
labath added a comment.
I have now :)
https://reviews.llvm.org/D22404
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Mon Jul 18 09:42:01 2016
New Revision: 275791
URL: http://llvm.org/viewvc/llvm-project?rev=275791&view=rev
Log:
Revert "[test] Report error when inferior test processes exit with a non-zero
code"
This reverts r275782.
The problem with the commit is that it reports an additi
labath marked 2 inline comments as done.
labath added a comment.
https://reviews.llvm.org/D22457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Thu Jul 21 09:54:03 2016
New Revision: 276288
URL: http://llvm.org/viewvc/llvm-project?rev=276288&view=rev
Log:
Unify process launching code on linux
Summary:
We've had two copies of code for launching processes:
- one in NativeProcessLinux, used for launching debugged proces
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276288: Unify process launching code on linux (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D22457?vs=64296&id=64894#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22457
labath added a comment.
I also reverted it back, as it was causing some issues (if a specific test case
in a test file failed, it still marked the whole file as failed). I'll need
revisit this later...
https://reviews.llvm.org/D22404
___
lldb-comm
labath added a comment.
Looks good, just please fix the small stylistic issue.
Comment at: source/Plugins/Process/elf-core/ThreadElfCore.h:24
@@ -23,3 +23,3 @@
{
-int64_t tv_sec;
-int32_t tv_usec;
+alignas(8) uint64_t tv_sec;
+alignas(8) uint64_t tv_usec;
--
Author: labath
Date: Fri Jul 22 07:18:45 2016
New Revision: 276406
URL: http://llvm.org/viewvc/llvm-project?rev=276406&view=rev
Log:
Fixing layout of elf-core file related structures
Summary:
The binary layout of prstatus and prpsinfo was wrong.
Some of the member variables where not aligned prop
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Ok, nevermind then. Looks good.
https://reviews.llvm.org/D22628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
The function was returning the null pointer for peeks of size zero, which seems
like a sensible
thing to do, but is actually pretty easy to get bitten by that if you are
extracting a variabl
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
We were checking whether an attribute is in block form by getting the block
data pointer, which
was not correct as the pointer be null even if the attribute is in block form.
Other places in
1501 - 1600 of 6833 matches
Mail list logo
