labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm.
================
Comment at: cmake/modules/LLDBStandalone.cmake:61
@@ -60,2 +60,3 @@
set(LLVM_MAIN_INCLUDE_DIR ${INCLUDE_DIR} CACHE PATH "Path to llvm/include")
+ set(LLVM_DIR ${LLVM_OBJ_ROOT}/cmake/modules/CMakeFiles CACHE PATH "Path to
LLVM build tree")
set(LLVM_BINARY_DIR ${LLVM_OBJ_ROOT} CACHE PATH "Path to LLVM build tree")
----------------
Please put a more descriptive location here, as this is the same as
`LLVM_BINARY_DIR`. Perhaps "Path to LLVMConfig.cmake" if you can't think of
anything better.
Repository:
rL LLVM
http://reviews.llvm.org/D22322
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
