labath added a comment.

Looks good, just please fix the small stylistic issue.


================
Comment at: source/Plugins/Process/elf-core/ThreadElfCore.h:24
@@ -23,3 +23,3 @@
 {
-    int64_t tv_sec;
-    int32_t tv_usec;
+    alignas(8) uint64_t tv_sec;
+    alignas(8) uint64_t tv_usec;
----------------
Please define a separate type for a "64-bit integer aligned to 8 bytes", so we 
can avoid littering the code with the alignas directives.


https://reviews.llvm.org/D22628



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to