labath added a comment.

So, I'll let Jason be the definitive judge here, but I have to say I don't like 
this solution.

Computing 10 frames significantly increases the amount of processing needed to 
get some result. Most importantly, it increases the latency, as it will cause a 
lot more data to be pulled from the server in case of remote debugging and may 
force a lot more eh_frame parsing. Also, it makes the unwinder a lot more 
nondeterministic and harder to test as now the frame you get shown can depend 
on something happening 10 levels down.

I'd really prefer a solution where we can get default unwinder to do the right 
thing, so we could just avoid needing to rely on the fallback.


http://reviews.llvm.org/D21221



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to