labath updated this revision to Diff 105095.
labath marked 2 inline comments as done.
labath added a comment.
remove extra pid check
https://reviews.llvm.org/D33778
Files:
include/lldb/Host/common/NativeProcessProtocol.h
source/Host/common/NativeProcessProtocol.cpp
source/Plugins/Process/
labath added a comment.
In https://reviews.llvm.org/D34945#798808, @ravitheja wrote:
> With this patch, I see the extra packet to query from server is probably
> unnecessary. I mean the error code is still there and it should be sufficient
> for the client to detect an error. As long as it does
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307072: Update lldb architecture docs (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D34872
Files:
lldb/trunk/www/architecture.html
lldb/trunk/www/architecture/index.html
Index
labath added a comment.
In https://reviews.llvm.org/D33035#798857, @abhishek.aggarwal wrote:
> Hi Pavel .. I could remove all exception handling code from source files.
> However, I am still wondering how to disable exception handling while
> providing python functions for C++ APIs of the featu
labath added a comment.
In https://reviews.llvm.org/D33035#798925, @abhishek.aggarwal wrote:
> In https://reviews.llvm.org/D33035#798885, @labath wrote:
>
> > Hm... that's a bit of a drag. I guess the SB API never ran into this
> > problem because it always provides it's own vector-like classes
labath added inline comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:3176
+ EnableErrorStringInPacket();
StreamGDBRemote escaped_packet;
I don't like how every packet function needs to enable this manually. Every
f
labath added a comment.
I am generally happy with this, just a couple of things I noticed below:
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:3329
} else {
- error.SetError(response.GetError(), eErrorTypeGeneric);
+error = re
labath added inline comments.
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:11
// C Includes
#include
#include
Do you still get the error if you remove these includes?
As far as I can tell they are unused, and this part of the code shoul
labath added inline comments.
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:115
_type:
\
name = #_type
switch (type) {
joerg wrote:
> krytarowski wrote:
> > brunoa
labath added a comment.
I would prefer the unique_lock idea also. Lamdas make the code look ugly.
Alternatively, we could start using thread safety annotations
https://clang.llvm.org/docs/ThreadSafetyAnalysis.html, and let clang do the
checking for us. I think a number of places could benefit f
labath created this revision.
Herald added a subscriber: ki.stfu.
It defined a couple of types (condition_t) which we don't use anymore,
as we have c++11 goodies now. I remove these definitions.
Also it unnecessarily included a couple of headers which weren't
necessary for it's operation. I remov
labath added inline comments.
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:18
#if defined(__linux__) || defined(__FreeBSD__)
#include "Plugins/Process/elf-core/ProcessElfCore.h"
#endif
krytarowski wrote:
> Is this needed here?
good point.
labath updated this revision to Diff 105613.
labath added a comment.
Remove unused include from auxvector.h
https://reviews.llvm.org/D35113
Files:
include/lldb/Host/MainLoop.h
include/lldb/Host/PosixApi.h
include/lldb/lldb-types.h
source/Host/common/File.cpp
source/Host/common/Socket.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307390: Add a NativeProcessProtocol Factory class (authored
by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D33778
Files:
lldb/trunk/include/lldb/Host/common/NativeProcessProtocol.h
lldb/
labath created this revision.
The usage of shared_from_this forces us to separate construction and
initialization phases, because shared_from_this() is not available in
the constructor (or destructor). The shared semantics are not necessary,
as we always have a clear owner of the native process cl
labath added a comment.
In https://reviews.llvm.org/D35083#802400, @jingham wrote:
> Ah, maybe you meant applying the thread safety annotation to Sean's solution
> to enforce the contract. That's an interesting solution, but makes a
> non-straightforward solution even more non-straightforward,
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
cool. thanks
https://reviews.llvm.org/D35065
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
labath added a comment.
Comment at: include/lldb/Host/MainLoop.h:16
#include "llvm/ADT/DenseMap.h"
+#include
Eugene.Zelenko wrote:
> I think will be good idea to include csignal instead. Same in other files.
> See
> http://clang.llvm.org/extra/clang-tidy
labath added a reviewer: emaste.
labath added a comment.
Adding ed as freebsd owner.
The patch seems reasonable, we changed the behavior on linux in a similar way
couple of releases back -- SEGV is not a "crash", because the application can
generally handle it via a signal handler.
Repository
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307632: [LLDB][ppc64le] Rename enums in AuxVector (authored
by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D35065
Files:
lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp
labath updated this revision to Diff 105980.
labath added a comment.
Use csignal instead of signal.h
https://reviews.llvm.org/D35113
Files:
include/lldb/Host/MainLoop.h
include/lldb/Host/PosixApi.h
include/lldb/lldb-types.h
source/Host/common/File.cpp
source/Host/common/Socket.cpp
s
labath added a comment.
In https://reviews.llvm.org/D35083#804623, @jingham wrote:
> As a general practice requiring a wrapper like this for every use of a should
> be locked object would make the code noisy and hard to read. The only error
> you would be protecting against is that somebody us
labath commandeered this revision.
labath edited reviewers, added: zturner; removed: labath.
labath added a comment.
It looks like this has ground to a halt, but it seems the consensus was to try
the Architecture plugin idea. I'm going to hijack this revision to maintain
context, and upload a ne
labath updated this revision to Diff 106165.
labath added a comment.
Herald added subscribers: javed.absar, mgorny.
The architecture plugin idea
https://reviews.llvm.org/D31172
Files:
include/lldb/Core/ArchSpec.h
include/lldb/Core/Architecture.h
include/lldb/Core/PluginManager.h
include
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks great, thanks for catching this.
The code was doing it this way initially, but then this got lost with all the
frantic refactors.
https://reviews.llvm.org/D35298
___
labath created this revision.
It is not presently used, and it's quite dangerous to use -- it assumes the
integer is an osx kern_return_t, but very few of the integers we have lying
around are mach kernel error codes. The error can still be used to a
mach error using a slightly longer (but more ex
labath created this revision.
Herald added subscribers: mgorny, srhines.
This adds support for running the lldb-server test suite (currently consisting
of only one test) against the debugserver. Currently, the choice which binary
to test is based on the host system. This will need to be replaced b
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
Have you tried that this actually works? (It doesn't work for me)
As far as I can tell, you will have to teach lldb-server to understand the
`--fd` argument before you can flip this
labath added a comment.
In https://reviews.llvm.org/D31172#806804, @jingham wrote:
> This is a good addition. However, it seems to me that since you only need an
> ArchSpec to make one of these Architecture plugins, which plugin you get
> seems fully determined by the Target, not the Process.
labath marked 2 inline comments as done.
labath added a comment.
In https://reviews.llvm.org/D31172#807180, @jingham wrote:
> Sorry I wasn't clear. I meant that since the Target knows everything it
> needs to know to vend the correct Architecture plugin, you should get it from
> the Target, no
labath updated this revision to Diff 106398.
labath added a comment.
Moving the plugin to Target and other minor fixups.
I also wrote a test for the functionality covered by the override callback. (I'm
not including it here to avoid polluting the review, but a part of this change
will be to move
labath created this revision.
This adds support for the extra_cmake_args argument to the
LLDBScriptCommandsFactory and uses that to enable assertions on the
linux bot.
While I'm in there, I also remove the "update ndk" step -- it was a bad
idea because it's introducing android-specific code into
labath added a comment.
In https://reviews.llvm.org/D31172#808038, @clayborg wrote:
> Added a suggestion to make Target::GetArchitecturePlugin lazy and to ask if
> the arch is supported. Most of the time we will set this once and never need
> to change it, even when we attach, change arch, etc.
labath updated this revision to Diff 106600.
labath marked an inline comment as done.
labath added a comment.
The version with a container object for ArchSpec+Plugin combo
https://reviews.llvm.org/D31172
Files:
include/lldb/Core/ArchSpec.h
include/lldb/Core/Architecture.h
include/lldb/Cor
labath added a comment.
In https://reviews.llvm.org/D31172#808177, @clayborg wrote:
> In https://reviews.llvm.org/D31172#808105, @labath wrote:
>
> > - confine all the changes to m_arch to the SetArchitecture method. Right
> > now only one of the assignments to m_arch is done outside of this met
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308282: Remove shared pointer from NativeProcessProtocol
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D35123?vs=105637&id=107034#toc
Repository:
rL LLVM
https://reviews.ll
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
This is completely wrong. The --pipe argument is used to write the port that
lldb-server listens on. Making --fd an alias to that will not help.
Please make sure you test your change
labath created this revision.
Herald added a subscriber: srhines.
Herald added a reviewer: EricWF.
This adds a data formatter for the implementation of forward_list in
libc++. I've refactored the existing std::list data formatter a bit to
enable more sharing of code (mainly the loop detection stuf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308304: Clean up lldb-types.h (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D35113?vs=105980&id=107088#toc
Repository:
rL LLVM
https://reviews.llvm.org/D35113
Files:
lldb
labath added a comment.
In https://reviews.llvm.org/D33213#814041, @DemiMarie wrote:
> In https://reviews.llvm.org/D33213#813037, @clayborg wrote:
>
> > Before any changes are submitted, we assume you are getting a clean test
> > suite run.
>
>
> On my system, I get build failures in clang.
I
labath added a reviewer: jingham.
labath added a comment.
I think Jim (or maybe Greg?) should take a look at this.
Right now I'll just comment on the test.
Comment at: packages/Python/lldbsuite/test/linux/add-symbols/Makefile:1
+all: clean
+ mkdir debug_binaries
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
thanks
https://reviews.llvm.org/D35614
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l
labath accepted this revision.
labath added a comment.
The test looks well written. I've added a couple of suggestions you can
consider including.
Comment at:
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py:15
+
+my
labath created this revision.
Herald added subscribers: mgorny, srhines.
Herald added a reviewer: EricWF.
https://reviews.llvm.org/D35615
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/tuple/Makefile
packages/Python/lldbsuite/test/functionalit
labath created this revision.
The NativeThread class is useless without the containing process (and in
some places it is already assuming the process is always around). This
makes it clear that the NativeProcessProtocol is the object owning the
threads, and makes the destruction order deterministi
labath added a comment.
Btw, will this work correctly if we are cross-debugging from a mac? (because
then we will use the fancy DownloadObjectAndSymbolFile implementation)
https://reviews.llvm.org/D35607
___
lldb-commits mailing list
lldb-commits@l
labath added a comment.
@beanz: It looks like you're doing some debugserver work. :) Any thoughts on
this?
https://reviews.llvm.org/D35311
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
labath added a comment.
In https://reviews.llvm.org/D35311#814941, @jingham wrote:
> This isn't about this patch, but replying to:
>
> > debugserver replies to the k packet instead of just dropping the connection
> > - stopping code adjusted, although we should probably consider aligning the
>
labath added a comment.
In https://reviews.llvm.org/D35607#814982, @clayborg wrote:
> So we should just make sure this works:
>
> (lldb) target symbols add --shlib a.out debug_binaries/a.out
>
>
> The --uuid option is there to help you match up without having to specify the
> file path. If I a
labath created this revision.
Herald added subscribers: mgorny, srhines.
Herald added a reviewer: EricWF.
std::queue is just a fancy wrapper around another container, so all we
need to do is to delegate to the it.
https://reviews.llvm.org/D35666
Files:
packages/Python/lldbsuite/test/function
labath added a reviewer: eugene.
labath added a comment.
I am not able to test this right now. Eugene, can you take a look?
Comment at: tools/lldb-server/lldb-gdbserver.cpp:241
+ std::unique_ptr connection_up;
+ if (connection_fd != -1) {
+// Build the connection string.
labath added a comment.
I looked at this briefly last week but I could not find a good fix in the
amount of time I had left. This fixes the current test failure, but it does not
fix the underlying bug, which is that we (sometimes?) set the compile unit
offset for non-dwo, non-dsym DIEs as 0. Th
labath added inline comments.
Comment at: lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp:389
+ struct __lldb_dlopen_result { void *image_ptr; const char
*error_str; } the_result;
+ the_result.image_ptr = __dl_dlopen ("%s", 2);
labath added a comment.
In https://reviews.llvm.org/D35223#834050, @emaste wrote:
> With this patch I observed three new failures on FreeBSD and three new
> unexpected passes on FreeBSD. An example of a new failure:
>
> ==
>
labath accepted this revision.
labath added a comment.
lgtm
https://reviews.llvm.org/D34776
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a subscriber: eugene.
labath added a comment.
IIUC, the conclusion was that we don't need the mach-o entry. Could you submit
a version of the patch without it. I can't commit this right now, but @eugene
should be able to do that for you.
https://reviews.llvm.org/D36804
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
looks good. plus, it seems to be a no-op, as the following case block
immediately breaks.
Repository:
rL LLVM
https://reviews.llvm.org/D36977
___
labath added a reviewer: eugene.
labath accepted this revision.
labath added a subscriber: eugene.
labath added a comment.
This revision is now accepted and ready to land.
Looks fine to me. Sorry about the delay.
@eugene should be able to help you commit this.
Wrt. the extra register context dis
labath added a comment.
In https://reviews.llvm.org/D38323#889534, @alexandreyy wrote:
> In https://reviews.llvm.org/D38323#889473, @labath wrote:
>
> > Looks fine to me. Sorry about the delay.
> >
> > @eugene should be able to help you commit this.
> >
> > Wrt. the extra register context discuss
labath created this revision.
We had a bug where if we had forked (in the ProcessLauncherPosixFork)
while another thread was writing a log message, we would deadlock. This
happened because the fork child inherited the locked log rwmutex, which
would never get unlocked. This meant the child got stu
labath updated this revision to Diff 119315.
labath added a comment.
Solve the problem using pthread_atfork().
This way the locks are properly taken before forking and released in both child
and parent processes. This behavior is encapsulated within the Log class and is
completely transparent to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316007: Remove shared_pointer from NativeThreadProtocol
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D35618?vs=107289&id=119338#toc
Repository:
rL LLVM
https://reviews.llv
labath added a comment.
In https://reviews.llvm.org/D35311#830779, @beanz wrote:
> This all looks fine to me. The one thing I'd like you to consider is that
> someday (when lldb-server is supported on Darwin) we will want to run these
> tests against both debugserver and lldb-server. I'm not as
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316010: lldb-server tests: Add support for testing
debugserver (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D35311?vs=106247&id=119344#toc
Repository:
rL LLVM
https://revi
labath created this revision.
Without this, the launching of the test inferior may fail if it depends
on some component of the environment (most likely LD_LIBRARY_PATH). This
makes sure we propagate the environment variable to the inferior
process.
https://reviews.llvm.org/D39010
Files:
unitt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316173: Logging: Make sure logging machinery is in a
consistent state after forking (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D38938
Files:
lldb/trunk/include/lldb/Utility/L
labath updated this revision to Diff 119710.
labath added a comment.
The previous fix had a problem where a more paraniod libc (e.g., android, but I
suspect freebds would do that as well) would detect that the
thread unlocking the mutex is not the same one as the one that locked, and
refused to co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316244: lldb-server tests: Propagate environment variables
(pr34192) (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D39010
Files:
lldb/trunk/unittests/tools/lldb-server/tests/Tes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316368: Logging: Disable logging after fork() (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D38938?vs=119710&id=119920#toc
Repository:
rL LLVM
https://reviews.llvm.org/D389
labath added a comment.
Hey Jim,
I wrote a couple of new libc++ data formatters in july. You seem to be the data
formatter owner nowadays. Would you mind taking a look?
https://reviews.llvm.org/D35556
___
lldb-commits mailing list
lldb-commits@lis
labath created this revision.
Herald added a subscriber: mgorny.
Using the in-tree clang should be the default test configuration as that
is the one compiler that we can be sure everyone has (better
reproducibility of test results). Also, it should hopefully reduce the
impact of pr35040.
https:/
labath added a comment.
In https://reviews.llvm.org/D39215#904510, @zturner wrote:
> There is already a CMake variable called `LLDB_TEST_COMPILER`. This
> `LLDB_TEST_CLANG` was introduced later, I guess unaware of the presence of
> `LLDB_TEST_COMPILER`. Would it be possible to standardize on
labath added a comment.
In https://reviews.llvm.org/D39215#904536, @labath wrote:
> In https://reviews.llvm.org/D39215#904510, @zturner wrote:
>
> > There is already a CMake variable called `LLDB_TEST_COMPILER`. This
> > `LLDB_TEST_CLANG` was introduced later, I guess unaware of the presence of
labath added a comment.
I've played around with this, but I couldn't get the `lit/lit.site.cfg.in` file
to see the expanded values of the `$` generator expression
(the reason it works now is because the file is special-casing
LLDB_TEST_CLANG=True). Currently, I do not see how to work around tha
labath added a comment.
In https://reviews.llvm.org/D39215#904677, @zturner wrote:
> Ok the issue is that you cant use CMake generator expressions in this way.
> This should work though:
>
> if (TARGET clang)
> set(LLDB_DEFAULT_TEST_COMPILER
> "${LLVM_BINARY_DIR}/clang${CMAKE_EXECUTABLE_
labath added a comment.
Davide, I reverted this because it breaks the case when you just specify a
filename as a compiler (with the expectation that we will look it up in the
path). I think this is a good thing to have, and our buildbot was using that
behavior.
I like the direction this change
labath created this revision.
Herald added a subscriber: mgorny.
r316368 broke this build when it introduced a reference to a pthread
function to the Utility module. This caused cmake to generate an
incorrect link line (wrong order of libs) because it did not see the
dependency from Utility to the
labath updated this revision to Diff 120102.
labath added a comment.
This removes the LLDB_TEST_CLANG and LLDB_TEST_COMPILER settings.
I've decided to keep the separate C and CXX variables because:
a) that's consistent with other cmake settings
b) in case of gcc, it's not easy to figure out the c
labath added a comment.
I'm back now, and I'd like to try to push this patch to completion.
After re-reading the discussion, I got the impression we have mostly reached a
consensus here. A small issue remained about how to guarantee that the
Architecture plugin and the ArchSpec object are in sy
labath added inline comments.
Comment at: include/lldb/Target/Target.h:1217
+const ArchSpec &GetSpec() const { return m_spec; }
+Architecture *GetPlugin() const { return m_plugin_up.get(); }
+
zturner wrote:
> Can this return a reference instead of a poin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316609: Move StopInfoOverride callback to the new
architecture plugin (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D31172?vs=106600&id=120309#toc
Repository:
rL LLVM
https
labath added a comment.
I thought https://reviews.llvm.org/D33083 was supposed to resolve the
conflicting-symbol-in-another-library issue by giving precedence to the current
module. Why doesn't that apply here?
https://reviews.llvm.org/D39307
___
labath marked 5 inline comments as done.
labath added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/forward_list/main.cpp:5
+{
+ std::forward_list empty{}, one_elt{47}, five_elts{1,22,333,,5};
+ ret
labath updated this revision to Diff 120491.
labath marked 4 inline comments as done.
labath added a comment.
Address review comments.
https://reviews.llvm.org/D35556
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/forward_list/Makefile
packa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316728: Default to using in-tree clang for building test
executables (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D39215
Files:
lldb/trunk/CMakeLists.txt
lldb/trunk/lit/CMake
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316772: Add specific ppc64le hardware watchpoint handler
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D38897?vs=119885&id=120632#toc
Repository:
rL LLVM
https://reviews.ll
labath created this revision.
Herald added subscribers: javed.absar, mgorny.
ArchSpec::SetTriple was taking a Platform as an argument, and used it to
fill in missing pieces of the specified triple. I invert the dependency
by moving this code to other classes. For this purpose, I've created
three n
labath added inline comments.
Comment at: source/Target/Platform.cpp:986-991
+if (normalized_triple.getVendorName().empty())
+ normalized_triple.setVendor(compatible_triple.getVendor());
+if (normalized_triple.getOSName().empty())
+ normalized_triple.setOS(compa
labath marked 3 inline comments as done.
labath added inline comments.
Comment at: include/lldb/Target/Platform.h:524
+ //---
+ ArchSpec GetAugmentedArchSpec(llvm::StringRef triple);
+
ztur
labath updated this revision to Diff 120712.
labath added a comment.
Address review comments
https://reviews.llvm.org/D39387
Files:
include/lldb/Core/ArchSpec.h
include/lldb/Host/HostInfoBase.h
include/lldb/Target/Platform.h
packages/Python/lldbsuite/test/source-manager/main.c
source/
labath updated this revision to Diff 120714.
labath added a comment.
rename argument to normalized_triple, check that the architecture is not empty.
https://reviews.llvm.org/D39387
Files:
include/lldb/Core/ArchSpec.h
include/lldb/Host/HostInfoBase.h
include/lldb/Target/Platform.h
packag
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316987: Invert ArchSpec<->Platform dependency (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D39387?vs=120714&id=120957#toc
Repository:
rL LLVM
https://reviews.llvm.org/D393
labath added a comment.
Thanks.
By the way, I have a couple of other patches lined up that you probably did not
notice:
https://reviews.llvm.org/D35666
https://reviews.llvm.org/D35615
https://reviews.llvm.org/D35305
https://reviews.llvm.org/D35556
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316992: Add data formatter for libc++'s forward_list
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D35556?vs=120491&id=120961#toc
Repository:
rL LLVM
https://reviews.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316997: Fix LLVM_LINK_LLVM_DYLIB build (pr35053) (authored
by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D39246
Files:
lldb/trunk/cmake/LLDBDependencies.cmake
lldb/trunk/scripts/CMakeLi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317093: Remove uint32_t assignment operator from Status
(authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D35305
Files:
lldb/trunk/include/lldb/Utility/Status.h
lldb/trunk/source/
labath added a comment.
There wasn't a strong reason for using nullptr, I can convert those to
ValueObjectSP().
Given that this was your only objection to this patch, I'm going to assume it
is ok to land after this.
https://reviews.llvm.org/D35615
__
labath updated this revision to Diff 121131.
labath added a comment.
s/nullptr/ValueObjectSP()
https://reviews.llvm.org/D35615
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/tuple/Makefile
packages/Python/lldbsuite/test/functionalities/data-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317095: Add data formatter for libc++ std::tuple (authored
by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D35615
Files:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-form
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317099: Add data formatter for libc++ std::queue (authored
by labath).
Changed prior to commit:
https://reviews.llvm.org/D35666?vs=107464&id=121137#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
1301 - 1400 of 6408 matches
Mail list logo
