labath marked 2 inline comments as done. labath added a comment. In https://reviews.llvm.org/D31172#807180, @jingham wrote:
> Sorry I wasn't clear. I meant that since the Target knows everything it > needs to know to vend the correct Architecture plugin, you should get it from > the Target, not the Process. In general, I think that the highest class in > the stack that can vend a plugin is the one that should. Ah, got it. That sounds like a good idea, I'll switch this over to Target. ================ Comment at: include/lldb/Core/Architecture.h:19 +public: + Architecture() = default; + virtual ~Architecture() = default; ---------------- clayborg wrote: > Not sure the constructor is needed? It is, because the default constructor is not emitted automatically if you provide a copy constructor (even a deleted one). https://reviews.llvm.org/D31172 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
