labath added a reviewer: jingham.
labath added a comment.

I think Jim (or maybe Greg?) should take a look at this.

Right now I'll just comment on the test.



================
Comment at: packages/Python/lldbsuite/test/linux/add-symbols/Makefile:1
+all: clean
+       mkdir debug_binaries
----------------
This is a very non-standard Makefile. As it is now, it will fail if running the 
test against android.

I think you should be able to replace the strip command with a `LD_EXTRAS += 
-Wl,--build-id=none`. This should allow you to use Makefile.rules and be more 
portable. Also, I'd recommend setting this up in a way that you don't overwrite 
the `a.out` compiler output, as that will make the rules simpler. I'm thinking 
of something like this (untested) snippet:
```
LEVEL= ???
C_SOURCES := a.c
LD_EXTRAS += -Wl,--build-id=none

include $(LEVEL)/Makefile.rules

b.out: a.out
        $(OBJCOPY) --strip-debug a.out b.out #Have the test use b.out as the 
main executable

all: b.out
clean::
  rm -rf b.out
```


https://reviews.llvm.org/D35607



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to