[Lldb-commits] [PATCH] D53402: [SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView

mgorny created this revision. mgorny added a reviewer: zturner. Herald added a subscriber: JDevlieghere. Repository: rLLDB LLDB https://reviews.llvm.org/D53402 Files: source/Plugins/SymbolFile/NativePDB/CMakeLists.txt Index: source/Plugins/SymbolFile/NativePDB/CMakeLists.txt ==

[Lldb-commits] [PATCH] D53402: [SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL344746: [SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView (authored by mgorny, committed by ). Herald added a

[Lldb-commits] [PATCH] D55837: [cmake] Make libcxx(abi) a dependency when building in-tree clang

mgorny added a comment. How does this affect platforms that use other ABI library than libcxxabi? How does this affect platforms that use libstdc++ as default C++ backend? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55837/new/ https://reviews.llvm.org/D55837

[Lldb-commits] [PATCH] D47812: [lldb] [lit] Do not run Python tests w/ LLDB_DISABLE_PYTHON

mgorny created this revision. mgorny added reviewers: JDevlieghere, labath. Skip all Python-based tests as unsupported when LLDB_DISABLE_PYTHON is enabled. Otherwise, those tests simply fail being unable to import lldb module. https://reviews.llvm.org/D47812 Files: lit/CMakeLists.txt lit/S

[Lldb-commits] [PATCH] D47812: [lldb] [lit] Do not run Python tests w/ LLDB_DISABLE_PYTHON

This revision was automatically updated to reflect the committed changes. Closed by commit rL334080: [lit] Do not run Python tests w/ LLDB_DISABLE_PYTHON (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D47812?vs=150

[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix missing HAVE_LIBZ for tests in stand-alone builds

mgorny created this revision. mgorny added reviewers: labath, zturner, beanz. The HAVE_LIBZ variable is not exported by LLVM, and therefore is not available for reuse in stand-alone builds of other tools. Redefine it based on the value of LLVM_ENABLE_ZLIB. The same change has been already implemen

[Lldb-commits] [PATCH] D41726: [test] Use full PATH lookup for tools

mgorny created this revision. mgorny added reviewers: labath, zturner. Use full PATH when looking up test tools rather than just llvm tools directory. r320813 has added a lookup for 'lldb-test' which is part of LLDB tools rather than LLVM, and therefore is not present in llvm_tools_dir before LLDB

[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix missing HAVE_LIBZ for tests in stand-alone builds

mgorny added a comment. Maybe we could. I presumed people are using the separate variables for some reason. We'd have to check that it's properly sanitized when building in-tree and given to cmake though. https://reviews.llvm.org/D41725 ___ lldb-c

[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix missing HAVE_LIBZ for tests in stand-alone builds

mgorny added a comment. Well, it's actually more complex. In Gentoo we want to let the user choose whether he wants to build against zlib or without zlib support. So in the end there are two uses to be considered: 1. When the value is merely passed down from LLVM to indicate state of compressi

[Lldb-commits] [PATCH] D41726: [test] Use full PATH lookup for tools

This revision was automatically updated to reflect the committed changes. Closed by commit rL321932: [test] Use full PATH lookup for tools (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D41726?vs=128609&id=128843#toc Repository: rL LLVM https://review

[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix missing HAVE_LIBZ for tests in stand-alone builds

mgorny added a comment. I was talking of: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp tools/debugserver/source/RNBRemote.cpp https://reviews.llvm.org/D41725 _

[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB

mgorny updated this revision to Diff 128883. mgorny retitled this revision from "[lldb] [test] Fix missing HAVE_LIBZ for tests in stand-alone builds" to "[lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB". mgorny edited the summary of this revision. mgorny added a comment. Updated th

[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL322081: [test] Fix tests to use more portable LLVM_ENABLE_ZLIB (authored by mgorny, committed by ). Herald added a subscri

[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB

mgorny added a comment. In https://reviews.llvm.org/D41725#970926, @labath wrote: > In https://reviews.llvm.org/D41725#969388, @mgorny wrote: > > > I was talking of: > > > > source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp > > source/Plugins/Process/gdb-remote/GDBRemoteCommunicati

[Lldb-commits] [PATCH] D42317: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux

mgorny created this revision. mgorny added reviewers: k8stone, zturner, beanz. Fix the Linux plugin lookup path to include appropriate libdir suffix for the system. To accomplish this, store the value of LLVM_LIBDIR_SUFFIX in lldb/Host/Config.h as LLDB_LIBDIR_SUFFIX, and use this variable when def

[Lldb-commits] [PATCH] D42317: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux

mgorny added a comment. Disclaimer: I have never seen a plugin for LLDB. I've just noticed the wrong path in `strace` output and fixed it ;-). https://reviews.llvm.org/D42317 ___ lldb-commits mailing list [email protected] http://lists.ll

[Lldb-commits] [PATCH] D42317: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux

mgorny added inline comments. Comment at: source/Host/linux/HostInfoLinux.cpp:208 bool HostInfoLinux::ComputeSystemPluginsDirectory(FileSpec &file_spec) { - FileSpec temp_file("/usr/lib/lldb/plugins", true); + FileSpec temp_file("/usr/lib" LLDB_LIBDIR_SUFFIX "/lldb/plugins", t

[Lldb-commits] [PATCH] D42317: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL323673: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

mgorny added a comment. I can't test this right now but please make sure not to break linking to split shared libraries without dylib. https://reviews.llvm.org/D44379 ___ lldb-commits mailing list [email protected] http://lists.llvm.org/c

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

mgorny added a comment. Yes, full standalone. https://reviews.llvm.org/D44379 ___ lldb-commits mailing list [email protected] http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

mgorny added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:354 + + check_library_exists(dl dlopen "" HAVE_LIBDL) + if (HAVE_LIBDL) krytarowski wrote: > A more portable form of this: > > ``` > foreach(lib ${CMAKE_DL_LIBS}) > list(APPEND system_lib

[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

mgorny created this revision. mgorny added a project: LLDB. Add missing linkage from lldbExpression library to LLVMRuntimeDyld. Otherwise the build against shared LLVM libraries fails with: lib64/liblldbExpression.a(IRExecutionUnit.cpp.o):IRExecutionUnit.cpp:function llvm::RTDyldMemoryManager:

[Lldb-commits] [PATCH] D31369: PluginUnwindAssemblyX86: add missing linkage to MCDisasm

mgorny created this revision. mgorny added a project: LLDB. Add missing linkage of the lldbPluginUnwindAssemblyX86 to LLVMMCDisasm library. This fixes the following build failure when linking against shared libraries: lib64/liblldbPluginUnwindAssemblyX86.a(x86AssemblyInspectionEngine.cpp.o):x8

[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

This revision was automatically updated to reflect the committed changes. Closed by commit rL298776: Expression: add missing linkage to RuntimeDyld component (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D31367?vs=93041&id=93051#toc Repository: rL LLVM https://revi

[Lldb-commits] [PATCH] D31369: PluginUnwindAssemblyX86: add missing linkage to MCDisasm

This revision was automatically updated to reflect the committed changes. Closed by commit rL298777: PluginUnwindAssemblyX86: add missing linkage to MCDisasm (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D31369?vs=93043&id=93052#toc Repository: rL LLVM https://revi

[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

mgorny added a comment. In https://reviews.llvm.org/D31367#713472, @labath wrote: > We don't depend on the RuntimeDyld component of llvm directy -- we only use > it indirectly through the ExecutionEngine component. Shouldn't that be > reflected as a dependency in the build system somehow, so th

[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

mgorny added a comment. In https://reviews.llvm.org/D31367#714305, @beanz wrote: > Please revert your patch. It is *not* the right solution and is masking > underlying problems. Reverted in r299095. Now I'd really appreciate some help in figuring out how to fix it properly. > ExecutionEngine

[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

mgorny added a comment. Well, I can confirm that the hack works for me. Not that I like it but if it's meant to be only temporary, I'm fine with any solution that works. Repository: rL LLVM https://reviews.llvm.org/D31367 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

mgorny reopened this revision. mgorny added a reviewer: chapuni. mgorny added a subscriber: chapuni. mgorny added a comment. This revision is now accepted and ready to land. Well, @chapuni disagrees on https://reviews.llvm.org/D36211. Which way should we go then? Repository: rL LLVM https://

[Lldb-commits] [PATCH] D36358: [lldb] [cmake] Add explicit linkage from Core to curses

mgorny created this revision. The Core library calls functions provided by the curses library. Add an appropriate explicit LINK_LIBS to ${CURSES_LIBRARIES} to propagate the dependency correctly within the build system. It seems that so far the linkage was handled by some kind of implicit magic LL

[Lldb-commits] [PATCH] D36358: [lldb] [cmake] Add explicit linkage from Core to curses

mgorny updated this revision to Diff 109879. mgorny added a comment. Forgive my poor eyesight, obviously this could go into existing LINK_LIBS ;-). https://reviews.llvm.org/D36358 Files: source/Core/CMakeLists.txt Index: source/Core/CMakeLists.txt ===

[Lldb-commits] [PATCH] D36358: [lldb] [cmake] Add explicit linkage from Core to curses

mgorny updated this revision to Diff 109897. mgorny edited the summary of this revision. mgorny added a comment. Updated to explicitly respect LLDB_DISABLE_CURSES and the LLVM HAVE_TERMINFO logic. https://reviews.llvm.org/D36358 Files: source/Core/CMakeLists.txt Index: source/Core/CMakeLis

[Lldb-commits] [PATCH] D36358: [lldb] [cmake] Add explicit linkage from Core to curses

mgorny added a comment. Ping. https://reviews.llvm.org/D36358 ___ lldb-commits mailing list [email protected] http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D36358: [lldb] [cmake] Add explicit linkage from Core to curses

This revision was automatically updated to reflect the committed changes. Closed by commit rL311122: [cmake] Add explicit linkage from Core to curses (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D36358?vs=109897&id=111561#toc Repository: rL LLVM https://reviews.ll

[Lldb-commits] [PATCH] D36885: [cmake] Explicitly link dependency libraries in the Host library

mgorny created this revision. mgorny added a project: LLDB. Add explicit linkage to the necessary system libraries in the Host library. Otherwise, the library fails to build with -Wl,--as-needed. The system libraries ended up being listed on the linker command-line before the static libraries need

[Lldb-commits] [PATCH] D36886: [unittests] Build LLVMTestingSupport for out-of-source builds

mgorny created this revision. mgorny added a project: LLDB. The Process/gdb-remote test now requires the LLVMTestingSupport library that is not installed by LLVM. As a result, when doing an out-of-source build it fails being unable to find the library. To solve that, build a local copy of the libr

[Lldb-commits] [PATCH] D36885: [cmake] Explicitly link dependency libraries in the Host library

mgorny added inline comments. Comment at: source/Host/CMakeLists.txt:166-168 + if (LIBXML2_FOUND) +list(APPEND EXTRA_LIBS ${LIBXML2_LIBRARIES}) + endif() zturner wrote: > Even if libxml is found, that doesn't mean the build is configured to use it, > does

[Lldb-commits] [PATCH] D36885: [cmake] Explicitly link dependency libraries in the Host library

This revision was automatically updated to reflect the committed changes. Closed by commit rL311354: [cmake] Explicitly link dependency libraries in the Host library (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D36885?vs=111708&id=112016#toc Repository: rL LLVM ht

[Lldb-commits] [PATCH] D36886: [unittests] Build LLVMTestingSupport for out-of-source builds

This revision was automatically updated to reflect the committed changes. Closed by commit rL311355: [unittests] Build LLVMTestingSupport for out-of-source builds (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D36886?vs=111710&id=112017#toc Repository: rL LLVM https

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

mgorny added a comment. Please don't risk merging this before the branching. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56531/new/ https://reviews.llvm.org/D56531 ___ lldb-commits mailing list [email protected] http://lists.llv

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

mgorny added inline comments. Comment at: cmake/modules/LLDBStandalone.cmake:9 + find_package(LLVM REQUIRED CONFIG +HINTS "${LLDB_PATH_TO_LLVM_BUILD}" NO_DEFAULT_PATH NO_CMAKE_FIND_ROOT_PATH) + find_package(Clang REQUIRED CONFIG labath wrote: > xiaobai wrot

[Lldb-commits] [PATCH] D57193: [lldb] [Process/NetBSD] Add missing linkage to -lutil

mgorny created this revision. mgorny added a reviewer: krytarowski. Herald added a subscriber: abidh. Add missing linkage to fix build failure with LLD: ld: error: undefined symbol: kinfo_getvmmap >>> referenced by NativeProcessNetBSD.cpp >>> NativeProcessNetBSD.cpp.o:(lldb_p

[Lldb-commits] [PATCH] D57193: [lldb] [Process/NetBSD] Add missing linkage to -lutil

This revision was automatically updated to reflect the committed changes. Closed by commit rL352116: [Process/NetBSD] Add missing linkage to -lutil (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57193?vs=183397&id

[Lldb-commits] [PATCH] D57233: [CMake] Quick-Fix targets don't exist when building against LLVM install-tree with LLDB_INCLUDE_TESTS=ON

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. WFM. A number of tests fail but that's entirely normal at this point and we basically stopped caring. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57233/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D57282: [cmake] Fix get_llvm_lit_path() to respect LLVM_EXTERNAL_LIT always

mgorny created this revision. mgorny added reviewers: EricWF, sgraenitz, zturner. Herald added a subscriber: christof. Refactor the get_llvm_lit_path() logic to respect LLVM_EXTERNAL_LIT, and require the fallback to be defined explicitly as LLVM_DEFAULT_EXTERNAL_LIT. This fixes building libcxx st

[Lldb-commits] [PATCH] D57282: [cmake] Fix get_llvm_lit_path() to respect LLVM_EXTERNAL_LIT always

This revision was automatically updated to reflect the committed changes. Closed by commit rL352374: [cmake] Fix get_llvm_lit_path() to respect LLVM_EXTERNAL_LIT always (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D57282?vs=183693&id=183855#toc Reposit

[Lldb-commits] [PATCH] D57912: [lldb] [unittests] Disable MainLoopTest::DetectsEOF on NetBSD

mgorny updated this revision to Diff 185815. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57912/new/ https://reviews.llvm.org/D57912 Files: lldb/unittests/Host/MainLoopTest.cpp Index: lldb/unittests/Host/MainLoopTest.cpp ==

[Lldb-commits] [PATCH] D57912: [lldb] [unittests] Disable MainLoopTest::DetectsEOF on NetBSD

mgorny created this revision. mgorny added reviewers: labath, krytarowski. Herald added a project: LLDB. mgorny updated this revision to Diff 185815. The NetBSD kernel currently does not support detecting closed slave pty via kevent on master pty. This causes the test to hang forever. To avoid t

[Lldb-commits] [PATCH] D57912: [lldb] [unittests] Disable MainLoopTest::DetectsEOF on NetBSD

mgorny added a comment. Ok, thanks. I consider this only temporary; I have a kernel patch ready already (and waiting for review), so we're going to look into reenabling it soon enough. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57912/new/ https://reviews.llvm.org/D57912 ___

[Lldb-commits] [PATCH] D57959: [lldb] [MainLoop] Initialize empty sigset_t correctly

mgorny created this revision. mgorny added reviewers: zturner, labath, krytarowski. Herald added a project: LLDB. Fix MainLoop::RunImpl::get_sigmask() to correctly return empty sigset_t when SIGNAL_POLLING_UNSUPPORTED is true. On NetBSD (and probably on some other platforms), integers are not imp

[Lldb-commits] [PATCH] D57912: [lldb] [unittests] Disable MainLoopTest::DetectsEOF on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rL353545: [lldb] [unittests] Disable MainLoopTest::DetectsEOF on NetBSD (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D57959: [lldb] [MainLoop] Initialize empty sigset_t correctly

mgorny updated this revision to Diff 186011. mgorny added a comment. Ok, I see that `_WIN32` actually redefines `sigset_t`, so I've added a separate branch for it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57959/new/ https://reviews.llvm.org/D57959 Files: lldb/source/Host/common

[Lldb-commits] [PATCH] D57959: [lldb] [MainLoop] Initialize empty sigset_t correctly

mgorny added a comment. But to what purpose? I think it's better to use consistent macros to refer to the same scenario. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57959/new/ https://reviews.llvm.org/D57959 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

mgorny added a comment. Herald added a project: LLVM. This definitely broke stand-alone builds: FAILED: tools/driver/Options.inc cd /var/tmp/portage/dev-util/lldb-/work/lldb-_build && /usr/lib/llvm/9/bin/llvm-tblgen -gen-opt-parser-defs -I /var/tmp/portage/dev-util/lldb-/work/l

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

mgorny added inline comments. Comment at: lldb/trunk/cmake/modules/LLDBStandalone.cmake:20 + # We set LLVM_MAIN_INCLUDE_DIR so that it gets included in TableGen flags. + set(LLVM_MAIN_INCLUDE_DIR "${LLVM_BUILD_MAIN_INCLUDE_DIR}" CACHE PATH "Path to LLVM's source include dir")

[Lldb-commits] [PATCH] D57995: [lldb] [cmake] Use install directories for LLVM_* variables

mgorny created this revision. mgorny added reviewers: sgraenitz, xiaobai, labath, zturner. mgorny added a project: LLDB. Restore the previous behavior of using install directories for LLVM_MAIN_INCLUDE_DIR, LLVM_LIBRARY_DIR and LLVM_BINARY_DIR. The update from llvm-config to CMake has changed the

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

mgorny added a comment. Submitted a fix as D57995 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56531/new/ https://reviews.llvm.org/D56531 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D57999: [lldb] [lldb-instr] Add missing linkage to ClangLex

mgorny created this revision. mgorny added reviewers: JDevlieghere, labath. mgorny added a project: LLDB. Herald added subscribers: teemperor, abidh. Fixes the following build error: /usr/lib/gcc/x86_64-pc-linux-gnu/7.4.0/../../../../x86_64-pc-linux-gnu/bin/ld: tools/lldb-instr/CMakeFiles/lld

[Lldb-commits] [PATCH] D57999: [lldb] [lldb-instr] Add missing linkage to clang libraries

mgorny updated this revision to Diff 186111. mgorny retitled this revision from "[lldb] [lldb-instr] Add missing linkage to ClangLex" to "[lldb] [lldb-instr] Add missing linkage to clang libraries". mgorny edited the summary of this revision. mgorny added a comment. That's the complete set. CHA

[Lldb-commits] [PATCH] D57999: [lldb] [lldb-instr] Add missing linkage to ClangLex

mgorny planned changes to this revision. mgorny added a comment. Expecting more. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57999/new/ https://reviews.llvm.org/D57999 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D58000: [lldb] [test] Skip lldb-mi test if LLDB_DISABLE_PYTHON is used

mgorny created this revision. mgorny added reviewers: labath, zturner. mgorny added a project: LLDB. Herald added subscribers: abidh, ki.stfu. Herald added a reviewer: serge-sans-paille. Skip running lldb-mi tests when Python support is disabled. This causes lldb-mi to unconditionally fail, and t

[Lldb-commits] [PATCH] D58001: [lldb] [lit] Fix finding lld-link when it is not in 'compiler dir'

mgorny created this revision. mgorny added reviewers: zturner, labath. mgorny added a project: LLDB. Herald added a reviewer: serge-sans-paille. Fix the build helper to find lld-link via PATH lookup, rather than making a fragile assumption that it will be present in the 'compiler directory'. This

[Lldb-commits] [PATCH] D57959: [lldb] [MainLoop] Initialize empty sigset_t correctly

mgorny added a comment. I was experimenting with disabling kevent, and apparently no other NetBSD mechanism is supported by LLDB. Noticed this issue, so figured I'll fix it while at it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57959/new/ https://reviews.llvm.org/D57959 ___

[Lldb-commits] [PATCH] D57959: [lldb] [MainLoop] Initialize empty sigset_t correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353675: [lldb] [MainLoop] Initialize empty sigset_t correctly (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D57959?vs=186011&id=186194#toc Repository: rLLD

[Lldb-commits] [PATCH] D57999: [lldb] [lldb-instr] Add missing linkage to clang libraries

mgorny added a comment. Yes, I'm using the standalone build. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57999/new/ https://reviews.llvm.org/D57999 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/c

[Lldb-commits] [PATCH] D57999: [lldb] [lldb-instr] Add missing linkage to clang libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353680: [lldb] [lldb-instr] Add missing linkage to clang libraries (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D57999?vs=186111&id=186200#toc Repository:

[Lldb-commits] [PATCH] D58001: [lldb] [lit] Fix finding lld-link when it is not in 'compiler dir'

mgorny updated this revision to Diff 186205. mgorny added a comment. Updated to use `find_executable()` unconditionally. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58001/new/ https://reviews.llvm.org/D58001 Files: lldb/lit/helper/build.py Index: lldb/lit/helper/build.py

[Lldb-commits] [PATCH] D58000: [lldb] [test] Skip lldb-mi test if LLDB_DISABLE_PYTHON is used

mgorny updated this revision to Diff 186207. mgorny added a comment. Used `lit.local.cfg`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58000/new/ https://reviews.llvm.org/D58000 Files: lldb/lit/helper/toolchain.py lldb/lit/lit.site.cfg.py.in lldb/lit/tools/lldb-mi/lit.local.cfg

[Lldb-commits] [PATCH] D58001: [lldb] [lit] Fix finding lld-link when it is not in 'compiler dir'

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/lit/helper/build.py:296 +if linker_path is None: raise ValueError('Could not find \'{}\''.format(linker_path)) return linker_path labath wrote: >

[Lldb-commits] [PATCH] D58001: [lldb] [lit] Fix finding lld-link when it is not in 'compiler dir'

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rL353701: [lldb] [lit] Fix finding lld-link when it is not in 'compiler dir' (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscri

[Lldb-commits] [PATCH] D58000: [lldb] [test] Skip lldb-mi test if LLDB_DISABLE_PYTHON is used

This revision was automatically updated to reflect the committed changes. Closed by commit rL353700: [lldb] [test] Skip lldb-mi test if LLDB_DISABLE_PYTHON is used (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D57995: [lldb] [cmake] Use install directories for LLVM_* variables

mgorny added a comment. Indeed it is a problem. However, it seems to be a bug that `LLVM_INCLUDE_DIR` contains two directories. Apparently in regular builds it contains the directory with built includes only, with `LLVM_MAIN_INCLUDE_DIR` being the other directory. In other words, it's a mess ;-

[Lldb-commits] [PATCH] D57995: [lldb] [cmake] Use install directories for LLVM_* variables

mgorny updated this revision to Diff 186427. mgorny added a comment. Updated to use exported LLVM_MAIN_INCLUDE_DIR, as introduced by D58109 . This works both for build-tree and install-tree, and avoids having to introduce any conditionals. CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D58131: [lldb] [unittest] Avoid mixing '127.0.0.1' and 'localhost'

mgorny created this revision. mgorny added reviewers: k8stone, labath, krytarowski. mgorny added a project: LLDB. Fix the tests not to use '127.0.0.1' and 'localhost' interchangeably. More specifically, since tests bind specifically to 127.0.0.1, connect to that address as well; using 'localhost'

[Lldb-commits] [PATCH] D58131: [lldb] [unittest] Avoid mixing '127.0.0.1' and 'localhost'

This revision was automatically updated to reflect the committed changes. Closed by commit rL353868: [lldb] [unittest] Avoid mixing '127.0.0.1' and 'localhost' (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[Lldb-commits] [PATCH] D57995: [lldb] [cmake] Use install directories for LLVM_* variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL353925: [lldb] [cmake] Use install directories for LLVM_* variables (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[Lldb-commits] [PATCH] D58223: [lldb] [unittests] XFAIL two unittests failing on NetBSD

mgorny created this revision. mgorny added reviewers: krytarowski, labath, zturner. mgorny added a project: LLDB. The two following LLDBServerTests fail reliably on NetBSD: StandardStartupTest.TestStopReplyContainsThreadPcs TestBase.LaunchModePreservesEnvironment Establish an XFAIL behavior to

[Lldb-commits] [PATCH] D58223: [lldb] [unittests] XFAIL two unittests failing on NetBSD

mgorny added a comment. FTR, I've tried both @zturner's and @labath's XFAIL suggestions and the former doesn't work because we're not using exeptions, and the latter just gives some creepy C++ errors. Then I figured out this is probably the simplest and most readable possibility. Repository:

[Lldb-commits] [PATCH] D58227: [lldb] [MainLoop] Remove redundant termination clause (NFCI)

mgorny created this revision. mgorny added reviewers: krytarowski, labath. mgorny added a project: LLDB. Herald added a subscriber: abidh. Remove the redundant termination clause from within the loop. Since the check is done at the end of the loop, it's entirely redundant to the 'while' condition

[Lldb-commits] [PATCH] D58228: [lldb] [lldb-server] Catch and report errors from main loop

mgorny created this revision. mgorny added reviewers: labath, krytarowski. mgorny added a project: LLDB. Herald added a subscriber: abidh. Catch the possible error from lldb-gdbserver's main loop, and report it verbosely. Currently, if the loop fails the server exits normally, rendering the probl

[Lldb-commits] [PATCH] D58229: [lldb] [MainLoop] Report errno for failed kevent()

mgorny created this revision. mgorny added reviewers: labath, krytarowski. mgorny added a project: LLDB. Herald added a subscriber: emaste. Modify the kevent() error reporting to use errno rather than returning the return value. At least on FreeBSD and NetBSD, kevent() always returns -1 in case o

[Lldb-commits] [PATCH] D58230: [lldb] [MainLoop] Add kevent() EINTR handling

mgorny created this revision. mgorny added reviewers: krytarowski, labath. mgorny added a project: LLDB. Herald added a subscriber: abidh. Add missing EINTR handling for kevent() calls. If the call is interrupted, return from Poll() as if zero events were returned and let the polling resume on ne

[Lldb-commits] [PATCH] D58229: [lldb] [MainLoop] Report errno for failed kevent()

This revision was automatically updated to reflect the committed changes. Closed by commit rL354029: [lldb] [MainLoop] Report errno for failed kevent() (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[Lldb-commits] [PATCH] D58228: [lldb] [lldb-server] Catch and report errors from main loop

This revision was automatically updated to reflect the committed changes. Closed by commit rL354030: [lldb] [lldb-server] Catch and report errors from main loop (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[Lldb-commits] [PATCH] D58227: [lldb] [MainLoop] Remove redundant termination clause (NFCI)

This revision was automatically updated to reflect the committed changes. Closed by commit rL354050: [lldb] [MainLoop] Remove redundant termination clause (NFCI) (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D58230: [lldb] [MainLoop] Add kevent() EINTR handling

mgorny added a comment. In D58230#1398020 , @krytarowski wrote: > For EINTR we shall use `llvm::sys::RetryAfterSignal` `kevent()` man page indicates: > All changes contained in the changelist are applied before any pending events > are read from the qu

[Lldb-commits] [PATCH] D58223: [lldb] [unittests] XFAIL two unittests failing on NetBSD

mgorny planned changes to this revision. mgorny added a comment. @labath suggested another implementation possibility on IRC, I'll be trying it tomorrow. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58223/new/ https://reviews.llvm.org/D58223 __

[Lldb-commits] [PATCH] D58230: [lldb] [MainLoop] Add kevent() EINTR handling

mgorny updated this revision to Diff 186915. mgorny edited the summary of this revision. mgorny added a comment. Herald added a subscriber: jfb. Added the test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58230/new/ https://reviews.llvm.org/D58230 Files: lldb/source/Host/commo

[Lldb-commits] [PATCH] D58230: [lldb] [MainLoop] Add kevent() EINTR handling

mgorny added a comment. FTR, I've just verified this against NetBSD kernel sources and -- as I suspected and as I believe any reasonable implementation would do -- the only place where EINTR could be returned is when `kevent()` is sleeping, waiting for new events to appear in the event queue. T

[Lldb-commits] [PATCH] D58230: [lldb] [MainLoop] Add kevent() EINTR handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL354122: [lldb] [MainLoop] Add kevent() EINTR handling (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D58223: [lldb] [unittests] XFAIL two unittests failing on NetBSD

mgorny abandoned this revision. mgorny added a comment. Bad news: so far the alternate implementation suggestions don't work. Good news: we don't need after all. The `EINTR` fix seems to have fixed all the remaining tests for us. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D42870: Correct recognition of NetBSD images

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1359 + // p = patchlevel + const uint32_t version_major = version_info / 1; + const uint32_t version_minor = (version_info

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

mgorny updated this revision to Diff 187254. mgorny marked an inline comment as done and an inline comment as not done. mgorny retitled this revision from "Correct recognition of NetBSD images" to "[lldb] [ObjectFile/ELF] Correct recognition of NetBSD images". mgorny edited the summary of this rev

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/lit/Modules/ELF/netbsd-exec.yaml:1 +# Test whether NetBSD executables are recognized correctly. + I'm not sure if we should keep the whole file or try to strip this a bit. C

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

mgorny updated this revision to Diff 187261. mgorny added a comment. Rename tests as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42870/new/ https://reviews.llvm.org/D42870 Files: lldb/lit/Modules/ELF/Inputs/netbsd-amd64.core lldb/lit/Modules/ELF/netbsd-core-amd64.test

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

mgorny updated this revision to Diff 187264. mgorny added a comment. Herald added a subscriber: jdoerfert. Added comments on how test data was generated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42870/new/ https://reviews.llvm.org/D42870 Files: lldb/lit/Modules/ELF/Inputs/netbsd

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

mgorny updated this revision to Diff 187350. mgorny added a comment. Reduced the test .yaml to the absolute minimum. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42870/new/ https://reviews.llvm.org/D42870 Files: lldb/lit/Modules/ELF/Inputs/netbsd-amd64.core lldb/lit/Modules/ELF/ne

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

mgorny updated this revision to Diff 187351. mgorny added a comment. Updated to include a non-stripped core. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42870/new/ https://reviews.llvm.org/D42870 Files: lldb/lit/Modules/ELF/Inputs/netbsd-amd64.core lldb/lit/Modules/ELF/netbsd-cor

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

mgorny updated this revision to Diff 187358. mgorny added a comment. Switched to use shorter identifiers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42870/new/ https://reviews.llvm.org/D42870 Files: lldb/lit/Modules/ELF/Inputs/netbsd-amd64.core lldb/lit/Modules/ELF/netbsd-core-a

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB354466: [lldb] [ObjectFile/ELF] Fix recognizing NetBSD images (authored by mgorny, committed by ). Herald added a proje

  1   2   3   4   5   6   7   8   9   10   >