mgorny added a comment.

Well, it's actually more complex. In Gentoo we want to let the user choose 
whether he wants to build against zlib or without zlib support. So in the end 
there are two uses to be considered:

1. When the value is merely passed down from LLVM to indicate state of 
compression support in LLVM. AFAIR that was the case with clang -- we merely 
wanted to know if we can run tests that require LLVM to have compression 
support.
2. When the value is actually used to use zlib locally. To be honest, in this 
case I believe we should have a separate check & switch. FWICS, this is the 
case with LLDB.

So I don't think using LLVM_ENABLE_ZLIB here is correct, and my patch isn't 
correct as well.

That said, is there a reason for LLDB to use zlib directly instead of using the 
LLVM support compression library?


https://reviews.llvm.org/D41725



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to