mgorny marked 2 inline comments as done.
mgorny added inline comments.

================
Comment at: lldb/lit/helper/build.py:296
+        if linker_path is None:
             raise ValueError('Could not find \'{}\''.format(linker_path))
         return linker_path
----------------
labath wrote:
> `linker_path` isn't going to be terribly useful here when it's none. Probably 
> just replace it with `name`.
Indeed, thanks for catching this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58001/new/

https://reviews.llvm.org/D58001



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to