[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

JDevlieghere marked 4 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Target/Platform.cpp:1277-1279 + // Prefer the selected platform if it matches all architectures. + if (selected_platform_matches_all_archs) +return selected_platform_s

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. In D122684#3415303 , @clayborg wrote: > So this will fix LLDB complaining when a binary contains arm64 and x86_64 > when debugging on either platform? Great, we ran into this qu

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

JDevlieghere added inline comments. Comment at: lldb/source/Target/Platform.cpp:1277-1279 + // Prefer the selected platform if it matches all architectures. + if (selected_platform_matches_all_archs) +return selected_platform_sp; clayborg wrote: > JDevliegh

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

JDevlieghere updated this revision to Diff 419005. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. Change the algorithm to pick the selected/host platform if it matches at least one architecture. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122684/new/

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Target/Platform.cpp:1252 +if (selected_platform_sp) { + if (selected_platform_sp->IsCompatibleArchitecture( + arch, process_host_arch, false, nullptr))

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

JDevlieghere added inline comments. Comment at: lldb/source/Target/Platform.cpp:1252 +if (selected_platform_sp) { + if (selected_platform_sp->IsCompatibleArchitecture( + arch, process_host_arch, false, nullptr)) { JDevlieghere wrote: > jingh

[Lldb-commits] [PATCH] D122767: [lldb] Improve documentation for some of the platform functions

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a project: All. JDevlieghere requested review of this revision. Improve the documentation for the platform functions that take a process host architecture as input. https://reviews.llvm.org/D122767 Files:

[Lldb-commits] [PATCH] D122680: Add a setting to force overwriting commands in "command script add"

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122680/new/ https://reviews.llvm.org/D122680 ___

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

This revision was automatically updated to reflect the committed changes. Closed by commit rGa114ec0c6dc0: [lldb] Change the way we pick a platform for fat binaries (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D122684?vs=419005&id=4

[Lldb-commits] [PATCH] D122753: Fix NSIndexPathSyntheticFrontEnd::Impl::Clear() to only clear the active union member

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122753/new/ https://reviews.llvm.org/D122753 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D122848: Reduce extraneous temp strings in debugserver, free objects when they're not longer needed

JDevlieghere added a comment. If debugserver linked against libSupport we could have saved the additional copy altogether by using `llvm::raw_string_ostream`: std::string str; llvm::raw_string_ostream stream(str); stream.str() // Flushes and returns a reference to the stack allocated str

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jasonmolenda, clayborg. Herald added subscribers: pmatos, asb, atanasyan, jrtc27, kbarton, sbc100, nemanjai, sdardis, emaste. Herald added a project: All. JDevlieghere requested review of this revision. Herald added subscrib

[Lldb-commits] [PATCH] D122523: [lldb] Fix building standalone LLDB on Windows.

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122523/new/ https://reviews.llvm.org/D122523 __

[Lldb-commits] [PATCH] D122882: Add JSONGenerator::DumpBinaryEscaped method in debugserver, update most callers to use this, skip escaping step

JDevlieghere added inline comments. Comment at: lldb/tools/debugserver/source/JSONGenerator.h:233-247 + std::string quoted; + const size_t strsize = m_value.size(); + for (size_t i = 0; i < strsize; ++i) { +char ch = m_value[i]; +if (ch == '"') +

[Lldb-commits] [PATCH] D122912: Simplify ArchSpec::IsFullySpecifiedTriple() (NFC)

JDevlieghere added a comment. LGTM if the answer to both my questions is "yes". Comment at: lldb/source/Utility/ArchSpec.cpp:1399 bool ArchSpec::IsFullySpecifiedTriple() const { - const auto &user_specified_triple = GetTriple(); - - bool user_triple_fully_specified = false;

[Lldb-commits] [PATCH] D122898: [lldb] Move host platform implementations into the base class

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122898/new/ https://reviews.llvm.org/D122898 ___

[Lldb-commits] [PATCH] D122912: Simplify ArchSpec::IsFullySpecifiedTriple() (NFC)

JDevlieghere added inline comments. Comment at: lldb/source/Utility/ArchSpec.cpp:1399 bool ArchSpec::IsFullySpecifiedTriple() const { - const auto &user_specified_triple = GetTriple(); - - bool user_triple_fully_specified = false; - - if ((user_specified_triple.getOS() != llv

[Lldb-commits] [PATCH] D122944: [lldb] Prevent object file plugins from messing with the data buffer if they don't match

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. While discussing D122856 with Pavel on IRC, he pointed out that the current design allo

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

JDevlieghere updated this revision to Diff 419881. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. - Implement Pavel's suggestion of mapping ELF files as writable and casting to a WritableMemoryBuffer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122856/

[Lldb-commits] [PATCH] D122946: Prevent HostInfoBase::GetAugmentedArchSpec() from attaching "unknown" environments

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Fun stuff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122946/new/ https://reviews.llvm.org/D122946 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D122980: make ConstStringTable use std::unordered_map rather than std::map

JDevlieghere added a comment. I feel like this came up in the past and there was a reason an unordered map couldn't work? Maybe I'm confusing this with something else. Added Pavel as he would certainly know. Could we use a `llvm::DenseMap` here, as it's supposedly even faster than its STL coun

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

JDevlieghere added a comment. The ConstString/StringPool is pretty hot so I'm very excited about making it faster. I'm slightly concerned about the two hash values (the "full" hash vs the single byte one). That's not something that was introduced in this patch, but passing it around adds an op

[Lldb-commits] [PATCH] D122944: [lldb] Prevent object file plugins from messing with the data buffer if they don't match

JDevlieghere updated this revision to Diff 419993. JDevlieghere added a comment. Herald added subscribers: pmatos, asb, MaskRay, aheejin, sbc100, emaste. Prevent object files from changing the buffer by passing it by value CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122944/new/ https:

[Lldb-commits] [PATCH] D122944: [lldb] Prevent object file plugins from messing with the data buffer if they don't match

JDevlieghere updated this revision to Diff 420193. JDevlieghere added a comment. Update `CreateMemoryInstance` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122944/new/ https://reviews.llvm.org/D122944 Files: lldb/include/lldb/lldb-private-interfaces.h lldb/source/Plugins/ObjectFil

[Lldb-commits] [PATCH] D122980: make ConstStringTable use DenseMap rather than std::map

JDevlieghere accepted this revision. JDevlieghere added a comment. In D122980#3426196 , @labath wrote: > In D122980#3424636 , @JDevlieghere > wrote: > >> I feel like this came up in the past and there was a reaso

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

JDevlieghere added a comment. Is this really something we want to hardcode at all? It seems like this should be a setting that is configured by the test harness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123020/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D122944: [lldb] Prevent object file plugins from messing with the data buffer if they don't match

This revision was automatically updated to reflect the committed changes. Closed by commit rGc69307e5eeb5: [lldb] Prevent object file plugins from changing the data buffer (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D122944?vs=4201

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

JDevlieghere added a comment. In D123020#3426839 , @llunak wrote: > In D123020#3426252 , @labath wrote: > >>> BTW, does it make sense to get even things like this reviewed, or is it ok >>> if I push these directl

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

JDevlieghere updated this revision to Diff 420262. JDevlieghere marked 7 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122856/new/ https://reviews.llvm.org/D122856 Files: lldb/include/lldb/Core/ValueObject.h lldb/include/lldb/Host/FileSystem.h lldb/include/

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:361 // Update the data to contain the entire file if it doesn't already if (data_sp->GetByteSize() < length) { +data_sp = MapFileDataWritable(*file, length, file_offset)

[Lldb-commits] [PATCH] D123073: [lldb] Change CreateMemoryInstance to take a WritableDataBuffer

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added subscribers: pmatos, asb, sbc100, emaste. Herald added a project: All. JDevlieghere requested review of this revision. Herald added subscribers: MaskRay, aheejin. Change CreateMemoryInstance to take a WritableD

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:382 ObjectFile *ObjectFileELF::CreateMemoryInstance( const lldb::ModuleSP &module_sp, DataBufferSP &data_sp, const lldb::ProcessSP &process_sp, lldb::addr_t header_addr

[Lldb-commits] [PATCH] D123098: [lldb] Fix undefined behavior: left shift of negative value

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jingham, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Fix undefined behavior in AppleObjCRuntimeV2 where we were left shifting a signed value. rdar://91242879 https://review

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

JDevlieghere updated this revision to Diff 420540. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. I don't really like the idea of making the argument to createInstance writable. That seems like an implementation detail. Instead I added a virtual method IsWritable()

[Lldb-commits] [PATCH] D123098: [lldb] Fix undefined behavior: left shift of negative value

This revision was automatically updated to reflect the committed changes. Closed by commit rG73714a3c603c: [lldb] Fix undefined behavior: left shift of negative value (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D123098?vs=420342&id

[Lldb-commits] [PATCH] D122767: [lldb] Improve documentation for some of the platform functions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe90d8f024b2b: [lldb] Improve documentation for some of the platform functions (authored by JDevlieghere). Herald added a p

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

JDevlieghere updated this revision to Diff 420589. JDevlieghere added a comment. Herald added a subscriber: mgorny. - Copy the buffer if ObjectFileELF didn't map it - Use LLVM style RTTI CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122856/new/ https://reviews.llvm.org/D122856 Files:

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

JDevlieghere added a comment. Still LGTM. Apologies for the new rebase conflict introduced by e90d8f024b2b . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120810/new/ https://rev

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

JDevlieghere added a comment. After applying this patch I started seeing data races reported by TSan when running the shell tests (`check-lldb-shell`). It seems to happen to different tests on different runs but the backtraces are the same. WARNING: ThreadSanitizer: data race (pid=40880)

[Lldb-commits] [PATCH] D123073: [lldb] Change CreateMemoryInstance to take a WritableDataBuffer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2ea125ea09d: [lldb] Change CreateMemoryInstance to take a WritableDataBuffer (authored by JDevlieghere). Herald added a project: LLDB. Changed prio

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc54427e76c8: [lldb] Refactor DataBuffer so we can map files as read-only (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [PATCH] D123202: [lldb] Fix detecting warning options for GCC

JDevlieghere added a comment. Cool, I learned something new today. Thanks for adding that comment! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123202/new/ https://reviews.llvm.org/D123202 ___ lldb-comm

[Lldb-commits] [PATCH] D123203: [lldb] Silence GCC warnings about missing returns after fully covered switches. NFC.

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123203/new/ https://reviews.llvm.org/D123203 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D123254: [lldb] Disable GCC's -Wstringop-truncation warning. NFC.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I saw this warning on the bots and was confused because I too came to the conclusion that we were using strncpy correctly. LGTM. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D123269: debugserver would never write modified xmm/ymm/zmm register values into the inferior

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123269/new/ https://reviews.llvm.org/D123269 ___

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

JDevlieghere updated this revision to Diff 421256. JDevlieghere added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91835/new/ https://reviews.llvm.org/D91835 Files: lldb/bindings/interface/SBDebugger.i lldb/include/lldb/API/SBDebugger.h lldb/packages/Python/lld

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

This revision was automatically updated to reflect the committed changes. Closed by commit rGee2d9b872356: [lldb] Add Python bindings to print stack traces on crashes. (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91835/ne

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

JDevlieghere added a comment. In D123020#3437246 , @llunak wrote: > In D123020#3426867 , @JDevlieghere > wrote: > >> FWIW the official policy is outlined here: >> https://llvm.org/docs/CodeReview.html > > I'm aw

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

JDevlieghere added a comment. In D123020#3437512 , @clayborg wrote: > So the setting should take care of everything and we should be able to > increase it when running with valgrind right? I would rather not have code > all over LLDB making valgrind tes

[Lldb-commits] [PATCH] D123340: Applying clang-tidy modernize-use-override over LLDB

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo the redundant comment Comment at: lldb/unittests/Target/RemoteAwarePlatformTest.cpp:40 const ModuleSpec &module_spec, lldb::ModuleSP &exe_modul

[Lldb-commits] [PATCH] D123401: [lldb] Fix debug_info decorators for NO_DEBUG_INFO_TESTCASE

JDevlieghere created this revision. JDevlieghere added reviewers: labath, mib. Herald added a project: All. JDevlieghere requested review of this revision. Currently a NO_DEBUG_INFO_TESTCASE will return None as it's debug info type, causing the decorator to consider it a match. If such a test case

[Lldb-commits] [PATCH] D123401: [lldb] Fix debug_info decorators for NO_DEBUG_INFO_TESTCASE

JDevlieghere added a comment. In D123401#3439560 , @labath wrote: > I think this is actually a wider problem. I also ran into this recently (with > triples), but didn't have time to create a patch yet. I don't think that > `None` as the "actual" value

[Lldb-commits] [PATCH] D123421: Handle the new "selector-specific stub" ObjC Method dispatch method

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp:52-53 +return_struct.impl_addr = +class_getMethodImplementation_stret (return_struct.class_addr, +

[Lldb-commits] [PATCH] D123426: [lldb] Don't report progress in the REPL

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. Herald added a project: All. JDevlieghere requested review of this revision. Don't report progress events in the REPL. Most of the progress events are very debugger specific which are very useful when you're debugging, but

[Lldb-commits] [PATCH] D123421: Handle the new "selector-specific stub" ObjC Method dispatch method

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Jim. This LGTM. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp:637-643 // Also we will use the

[Lldb-commits] [PATCH] D123421: Handle the new "selector-specific stub" ObjC Method dispatch method

JDevlieghere closed this revision. JDevlieghere added a comment. Closed by 833882b32701ce3713c9dd9afdedf1126db691f0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123421/new/ htt

[Lldb-commits] [PATCH] D123426: [lldb] Don't report progress in the REPL

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbcb3bcee3ef: [lldb] Don't report progress in the REPL (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D123501: [lldb][NFC] Simplify part of Options::GenerateOptionUsage

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123501/new/ https://reviews.llvm.org/D123501 ___

[Lldb-commits] [PATCH] D123502: [lldb][NFC] Refactor printing of short options in help

JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/Options.cpp:457 - if (!options.empty()) { -// We have some required options with no arguments + if (required_options.size()) { strm.PutCString(" -"); I'm surprise

[Lldb-commits] [PATCH] D123616: [debugserver] Add HAVE_LIBCOMPRESSION guards

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. The current debugserver CMake allows it to be built with or without libcompression. It conditionally links against libcompression if it's a

[Lldb-commits] [PATCH] D123616: [debugserver] Add HAVE_LIBCOMPRESSION guards

JDevlieghere added a comment. That also works for me, but then let's remove the corresponding logic in CMake as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123616/new/ https://reviews.llvm.org/D123616 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D123616: [debugserver ] Un-conditionalize use of libcompression

JDevlieghere updated this revision to Diff 422262. JDevlieghere retitled this revision from "[debugserver] Add HAVE_LIBCOMPRESSION guards" to "[debugserver ] Un-conditionalize use of libcompression". JDevlieghere edited the summary of this revision. Herald added a subscriber: mgorny. CHANGES SINC

[Lldb-commits] [PATCH] D104629: [lldb] Escape semicolons for all shells

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07a722c574d1: [lldb] Escape semicolons for all shells (authored by teemperor, committed by JDevlieghere). Herald added a subscriber: lldb-commits. He

[Lldb-commits] [PATCH] D123690: [lldb] Expand $ when using tcsh

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a project: All. JDevlieghere requested review of this revision. Unlike for any of the other shells, we were escaping $ when using tcsh. There's nothing special about $ in tcsh and this prevents you from expand

[Lldb-commits] [PATCH] D123698: [lldb] Port Process::PrintWarning* to use the new diagnostic events

JDevlieghere created this revision. JDevlieghere added a reviewer: kastiglione. Herald added a project: All. JDevlieghere requested review of this revision. Port the two Process::PrintWarning functions to use the new diagnostic events through Debugger::ReportWarning. I kept the wrapper function

[Lldb-commits] [PATCH] D123690: [lldb] Expand $ when using tcsh

This revision was automatically updated to reflect the committed changes. Closed by commit rGacc56e55feee: [lldb] Expand $ when using tcsh (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D123690?vs=422551&id=422622#toc Repository: r

[Lldb-commits] [PATCH] D123698: [lldb] Port Process::PrintWarning* to use the new diagnostic events

JDevlieghere updated this revision to Diff 422647. JDevlieghere added a comment. Update tests to check stderr CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123698/new/ https://reviews.llvm.org/D123698 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Target/Process.h lldb/

[Lldb-commits] [PATCH] D123616: [debugserver ] Un-conditionalize use of libcompression

This revision was automatically updated to reflect the committed changes. Closed by commit rG763ff89c0e0d: [debugserver ] Un-conditionalize use of libcompression (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D123401: [lldb] Fix debug_info decorators for NO_DEBUG_INFO_TESTCASE

This revision was automatically updated to reflect the committed changes. Closed by commit rG343f3de559c6: [lldb] Fix a bug in the decorator matching logic. (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D123401?vs=421548&id=422673#to

[Lldb-commits] [PATCH] D123743: [lldb] Show the DBGError if dsymForUUID can't find a dSYM

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Show the user the DBGError (if available) when dsymForUUID fails. rdar://90949180 https://reviews.llvm.org/D123743 Files: lldb/include

[Lldb-commits] [PATCH] D123743: [lldb] Show the DBGError if dsymForUUID can't find a dSYM

JDevlieghere updated this revision to Diff 422688. JDevlieghere added a comment. Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123743/new/ https://reviews.llvm.org/D123743 Files: lldb/include/lldb/Symbol/LocateSymbolFile.h lldb/source/Commands/CommandObjectTarget.cpp lld

[Lldb-commits] [PATCH] D123746: [lldb] Prevent crash when adding a stop hook with --shlib

JDevlieghere created this revision. JDevlieghere added a reviewer: mib. Herald added a project: All. JDevlieghere requested review of this revision. Currently, lldb crashes when adding a stop hook with --shlib because we unconditionally use the target in `SymbolContextSpecifier::AddSpecification`

[Lldb-commits] [PATCH] D123698: [lldb] Port Process::PrintWarning* to use the new diagnostic events

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/Module.h:820-825 + void ReportWarningOptimization( + llvm::Optional debugger_id = llvm::None); + + void ReportWarningUnsupportedLanguage( + lldb::Lang

[Lldb-commits] [PATCH] D123698: [lldb] Port Process::PrintWarning* to use the new diagnostic events

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG99d9c44434f5: [lldb] Port Process::PrintWarning* to use the new diagnostic events (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [PATCH] D123746: [lldb] Prevent crash when adding a stop hook with --shlib

This revision was automatically updated to reflect the committed changes. Closed by commit rG64d9b233b990: [lldb] Prevent crash when adding a stop hook with --shlib (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D123746?vs=422695&id=4

[Lldb-commits] [PATCH] D123793: [lldb] Handle empty search string in "memory find"

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123793/new/ https://reviews.llvm.org/D123793 ___

[Lldb-commits] [PATCH] D123743: [lldb] Show the DBGError if dsymForUUID can't find a dSYM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf91446aa290: [lldb] Show the DBGError if dsymForUUID can't find a dSYM (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to c

[Lldb-commits] [PATCH] D124028: Add some docs on how to use container commands to the python reference doc

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/docs/use/python-reference.rst:675 + +:: + (lldb) help my-utilities For this to be formatted as code you need an extra newl

[Lldb-commits] [PATCH] D124029: Add a mutex to the ThreadPlanStackMap to prevent it getting corrupted

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Jim and I discussed this offline last week. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124029/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D124338: [lldb] Update online help text (consistency, typo)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the inline comment addressed. Do you need someone to commit this for you? Comment at: lldb/source/Commands/Options.td:155 Arg<"Selector">, Require

[Lldb-commits] [PATCH] D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class.

JDevlieghere accepted this revision. JDevlieghere added a comment. Before I read the comments I was going to make the same suggestion as Greg, but this makes sense to limit churn. LGMT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124110/new/ htt

[Lldb-commits] [PATCH] D124338: [lldb] Update online help text (consistency, typo)

This revision was automatically updated to reflect the committed changes. Closed by commit rGe07c092b8529: [lldb] Update online help text (consistency, typo) (authored by hawkinsw, committed by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D124429: [lldb] Remove Python 2 support from the ScriptInterpreter plugin

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, lanza. Herald added a project: All. JDevlieghere requested review of this revision. We dropped downstream support for Python 2 in the previous release. Now that we have branched for the next release the window whe

[Lldb-commits] [PATCH] D124430: [lldb] Remove Python 2 checks from the test suite

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, lanza. Herald added a project: All. JDevlieghere requested review of this revision. Herald added a project: LLDB. Remove Python 2 checks from the test suite Repository: rG LLVM Github Monorepo https://reviews.

[Lldb-commits] [PATCH] D124430: [lldb] Remove Python 2 checks from the test suite

JDevlieghere updated this revision to Diff 425113. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124430/new/ https://reviews.llvm.org/D124430 Files: lldb/test/API/functionalities/step_scripted/TestStepScripted.py lldb/test/API/lldbtest.py lldb/test/API/macosx/nslog/TestDarwinNSLogO

[Lldb-commits] [PATCH] D124430: [lldb] Remove Python 2 checks from the test suite

JDevlieghere added a comment. In D124430#3475136 , @clayborg wrote: > Are we removing Python2 support? Yep, AFAIK we were the only ones that still needed it. We dropped support downstream in the previous release and we just rebranched for the next one,

[Lldb-commits] [PATCH] D124429: [lldb] Remove Python 2 support from the ScriptInterpreter plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rG90537673302f: Remove Python 2 support from the ScriptInterpreter plugin (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D124430: [lldb] Remove Python 2 checks from the test suite

JDevlieghere closed this revision. JDevlieghere added a comment. 0e9af88b7099 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124430/new/ https://reviews.llvm.org/D124430 __

[Lldb-commits] [PATCH] D124535: [lldb] Fix crash when launching in terminal

JDevlieghere created this revision. JDevlieghere added reviewers: mgorny, labath. Herald added a project: All. JDevlieghere requested review of this revision. This patch fixes a crash when using `process launch -t` to launch the inferior from a TTY. The issue is that on Darwin, Host.mm is calling

[Lldb-commits] [PATCH] D124568: [lldb] Fix escaping when launching in terminal with AppleScript

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. Herald added a subscriber: kristof.beyls. Herald added a project: All. JDevlieghere requested review of this revision. Fix escaping when launching in terminal with AppleScript. The invocation we're building up is wrapped

[Lldb-commits] [PATCH] D124568: [lldb] Fix escaping when launching in terminal with AppleScript

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Host/macosx/objcxx/Host.mm:267 + + printf("%s\n", applescript_source.GetString().str().c_str()); + aprantl wrote: > Is this leftover debugging code? Yup, I

[Lldb-commits] [PATCH] D124568: [lldb] Fix escaping when launching in terminal with AppleScript

JDevlieghere updated this revision to Diff 425638. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Address Adrian's code review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124568/new/ https://reviews.llvm.org/D124568 Files: lldb/source/Host/ma

[Lldb-commits] [PATCH] D124568: [lldb] Fix escaping when launching in terminal with AppleScript

This revision was automatically updated to reflect the committed changes. Closed by commit rG5205c1774950: [lldb] Fix escaping when launching in terminal with AppleScript (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D124000: [lldb] Add FixAnyAddress to ABI plugins

JDevlieghere accepted this revision. JDevlieghere added a comment. Yes, this makes a lot of sense to me. Thanks for taking care of this. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124000/new/ https://reviews.llvm.org/D124000 _

[Lldb-commits] [PATCH] D124499: Rename conflict testcase

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Don't forget to rename the class name as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124499/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D124601: [lldb] Use shutil.which instead of distutils find_executable

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124601/new/ https://reviews.llvm.org/D124601

[Lldb-commits] [PATCH] D124604: [lldb] Use shutil.which in Shell tests find_executable

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124604/new/ https://reviews.llvm.org/D124604 ___

[Lldb-commits] [PATCH] D124535: [lldb] Fix crash when launching in terminal

This revision was automatically updated to reflect the committed changes. Closed by commit rG9aa6a479738c: [lldb] Fix crash when launching in terminal (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D124535?vs=425542&id=425910#toc Rep

[Lldb-commits] [PATCH] D124672: [lldb] Define LLDB_VERSION_PATCH correctly

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Good catch. Seems like there's another reference to this in `llvm/utils/gn/secondary/lldb/include/lldb/Version/BUILD.gn` but otherwise LGTM. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D124314: lldb: Disable unittests if llvm_gtest target does not exist

JDevlieghere added a comment. Could this go in LLDBStandalone.cmake? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124314/new/ https://reviews.llvm.org/D124314 ___ lldb-commits mailing list lldb-commits@

<    9   10   11   12   13   14   15   16   17   18   >