JDevlieghere updated this revision to Diff 422262.
JDevlieghere retitled this revision from "[debugserver] Add HAVE_LIBCOMPRESSION
guards" to "[debugserver ] Un-conditionalize use of libcompression".
JDevlieghere edited the summary of this revision.
Herald added a subscriber: mgorny.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123616/new/
https://reviews.llvm.org/D123616
Files:
lldb/tools/debugserver/source/CMakeLists.txt
Index: lldb/tools/debugserver/source/CMakeLists.txt
===================================================================
--- lldb/tools/debugserver/source/CMakeLists.txt
+++ lldb/tools/debugserver/source/CMakeLists.txt
@@ -106,8 +106,6 @@
set(CMAKE_OSX_ARCHITECTURES "arm64;arm64e")
endif ()
-check_library_exists(compression compression_encode_buffer ""
HAVE_LIBCOMPRESSION)
-
find_library(SECURITY_LIBRARY Security)
add_subdirectory(MacOSX)
@@ -125,6 +123,7 @@
LLDB_DEBUGSERVER_CODESIGN_IDENTITY ${debugserver_codesign_identity})
if(APPLE)
+ set(LIBCOMPRESSION compression)
if(APPLE_EMBEDDED)
find_library(BACKBOARD_LIBRARY BackBoardServices
PATHS ${CMAKE_OSX_SYSROOT}/System/Library/PrivateFrameworks)
@@ -146,10 +145,6 @@
endif()
endif()
-if(HAVE_LIBCOMPRESSION)
- set(LIBCOMPRESSION compression)
-endif()
-
if(LLDB_USE_ENTITLEMENTS)
if(APPLE_EMBEDDED)
set(entitlements
${DEBUGSERVER_RESOURCE_DIR}/debugserver-entitlements.plist)
@@ -258,10 +253,6 @@
${SECURITY_LIBRARY}
${LIBCOMPRESSION}
${ENERGY_LIBRARY})
-if(HAVE_LIBCOMPRESSION)
- set_property(TARGET lldbDebugserverCommon APPEND PROPERTY
- COMPILE_DEFINITIONS HAVE_LIBCOMPRESSION)
-endif()
add_lldb_tool(debugserver ADD_TO_FRAMEWORK
debugserver.cpp
LINK_LIBS lldbDebugserverCommon
@@ -325,10 +316,6 @@
lldbDebugserverArchSupport
${SECURITY_LIBRARY}
${LIBCOMPRESSION})
- if(HAVE_LIBCOMPRESSION)
- set_property(TARGET lldbDebugserverCommon_NonUI APPEND PROPERTY
- COMPILE_DEFINITIONS HAVE_LIBCOMPRESSION)
- endif()
add_lldb_tool(debugserver-nonui
debugserver.cpp
Index: lldb/tools/debugserver/source/CMakeLists.txt
===================================================================
--- lldb/tools/debugserver/source/CMakeLists.txt
+++ lldb/tools/debugserver/source/CMakeLists.txt
@@ -106,8 +106,6 @@
set(CMAKE_OSX_ARCHITECTURES "arm64;arm64e")
endif ()
-check_library_exists(compression compression_encode_buffer "" HAVE_LIBCOMPRESSION)
-
find_library(SECURITY_LIBRARY Security)
add_subdirectory(MacOSX)
@@ -125,6 +123,7 @@
LLDB_DEBUGSERVER_CODESIGN_IDENTITY ${debugserver_codesign_identity})
if(APPLE)
+ set(LIBCOMPRESSION compression)
if(APPLE_EMBEDDED)
find_library(BACKBOARD_LIBRARY BackBoardServices
PATHS ${CMAKE_OSX_SYSROOT}/System/Library/PrivateFrameworks)
@@ -146,10 +145,6 @@
endif()
endif()
-if(HAVE_LIBCOMPRESSION)
- set(LIBCOMPRESSION compression)
-endif()
-
if(LLDB_USE_ENTITLEMENTS)
if(APPLE_EMBEDDED)
set(entitlements ${DEBUGSERVER_RESOURCE_DIR}/debugserver-entitlements.plist)
@@ -258,10 +253,6 @@
${SECURITY_LIBRARY}
${LIBCOMPRESSION}
${ENERGY_LIBRARY})
-if(HAVE_LIBCOMPRESSION)
- set_property(TARGET lldbDebugserverCommon APPEND PROPERTY
- COMPILE_DEFINITIONS HAVE_LIBCOMPRESSION)
-endif()
add_lldb_tool(debugserver ADD_TO_FRAMEWORK
debugserver.cpp
LINK_LIBS lldbDebugserverCommon
@@ -325,10 +316,6 @@
lldbDebugserverArchSupport
${SECURITY_LIBRARY}
${LIBCOMPRESSION})
- if(HAVE_LIBCOMPRESSION)
- set_property(TARGET lldbDebugserverCommon_NonUI APPEND PROPERTY
- COMPILE_DEFINITIONS HAVE_LIBCOMPRESSION)
- endif()
add_lldb_tool(debugserver-nonui
debugserver.cpp
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
