JDevlieghere added a comment.

In D123401#3439560 <https://reviews.llvm.org/D123401#3439560>, @labath wrote:

> I think this is actually a wider problem. I also ran into this recently (with 
> triples), but didn't have time to create a patch yet.  I don't think that 
> `None` as the "actual" value should ever be considered a match (except when 
> the pattern is `None`, I guess), regardless of whether it is a debug info 
> variant, triple, or anything else. (`None` as a "pattern" should of course 
> continue to match anything.)

Agreed. I tried that but that caused a bunch of test failures. It's probably 
worth investigating, but my current focus is addressing some issues with our 
on-device test suite.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123401/new/

https://reviews.llvm.org/D123401

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to