[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 added inline comments. Comment at: lldb/include/lldb/Target/Target.h:496 + std::once_flag target_once_flag; // These two functions fill out the Broadcaster interface: kastiglione wrote: > did you mean to use this, or should it be deleted? Leftov

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 marked an inline comment as done. augusto2112 added inline comments. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:133-135 + << "note: object description requested, but type doesn't implement " + "a custom object description. Conside

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 updated this revision to Diff 546275. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153489/new/ https://reviews.llvm.org/D153489 Files: lldb/include/lldb/Core/Debugger.h lldb/source/C

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f45a87bf029: [lldb] Print hint if object description is requested but not implemented (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

augusto2112 created this revision. augusto2112 added reviewers: JDevlieghere, aprantl, jingham. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thread sanitizer is catching data races in OptionValue,

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

augusto2112 added a comment. > Do all of these need to be protected with a mutex? In your description you're > saying TSan is detecting data races. What piece of data are you observing the > data race on? Only SetAsBoolean/GetAsBoolean are being caught when running our test suite at the moment

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

augusto2112 marked 2 inline comments as done. augusto2112 added inline comments. Comment at: lldb/source/Interpreter/OptionValue.cpp:49 + std::lock_guard lock(m_mutex); if (GetType() == OptionValue::eTypeBoolean) return static_cast(this); kastiglione wro

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

augusto2112 updated this revision to Diff 547284. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157041/new/ https://reviews.llvm.org/D157041 Files: lldb/include/lldb/Interpreter/OptionValue.h lld

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

augusto2112 updated this revision to Diff 547318. augusto2112 added a comment. Remove lock from DeepCopy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157041/new/ https://reviews.llvm.org/D157041 Files: lldb/include/lldb/Interpreter/OptionValue.

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

This revision was automatically updated to reflect the committed changes. Closed by commit rG318f600722e3: [lldb] Protect OptionValue accesses from data races (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157041/new/ https

[Lldb-commits] [PATCH] D157153: [lldb] Fix ThreadList::Update not locking the rhs's mutex

augusto2112 created this revision. augusto2112 added reviewers: jingham, JDevlieghere. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ThreadList::Update is being caught by thread sanitizer. There's

[Lldb-commits] [PATCH] D157153: [lldb] Fix ThreadList::Update not locking the rhs's mutex

This revision was automatically updated to reflect the committed changes. Closed by commit rGd75dc9a8a86c: [lldb] Fix ThreadList::Update not locking the rhs's mutex (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157153/new/

[Lldb-commits] [PATCH] D157159: [lldb] Properly protect the Communication class with reader/writer lock

augusto2112 accepted this revision. augusto2112 added a comment. This revision is now accepted and ready to land. On the description you mention `unique_ptr` but I only see `shared_ptr` here. Was that a typo or do you mean that users of this class kept it behind a `unique_ptr`? In any case I th

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in ConnectionFileDescriptor

augusto2112 accepted this revision. augusto2112 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157347/new/ https://reviews.llvm.org/D157347 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

augusto2112 accepted this revision. augusto2112 added a comment. I have one nit that I'll leave up to you whether it should be addressed now or not. Comment at: lldb/source/Host/common/File.cpp:545 num_bytes = bytes_read; - } else if (StreamIsValid()) { + } else if (V

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

augusto2112 added inline comments. Comment at: lldb/source/Host/common/File.cpp:609 num_bytes = bytes_written; - } else if (StreamIsValid()) { + } else if (ValueGuard stream_guard = StreamIsValid()) { bytes_written = ::fwrite(buf, 1, num_bytes, m_stream); --

[Lldb-commits] [PATCH] D157648: [lldb] Fix data race in Process

augusto2112 created this revision. augusto2112 added reviewers: bulbazord, JDevlieghere. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thread sanitizer reports a data race in Process.cpp in the usa

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 created this revision. augusto2112 added reviewers: JDevlieghere, bulbazord. Herald added a subscriber: kristof.beyls. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thread sanitizer rep

[Lldb-commits] [PATCH] D157648: [lldb] Fix data race in Process

augusto2112 added a comment. In D157648#4578420 , @JDevlieghere wrote: > Is the reported race specifically about the shared pointer being accessed > concurrently or operations on the `IOHandler`? I believe it's the shared pointer being accessed. Here's

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 added inline comments. Comment at: lldb/source/Host/posix/PipePosix.cpp:69 PipeBase::operator=(std::move(pipe_posix)); - m_fds[READ] = pipe_posix.ReleaseReadFileDescriptor(); - m_fds[WRITE] = pipe_posix.ReleaseWriteFileDescriptor(); + std::lock_guard guard(m_loc

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 updated this revision to Diff 549454. augusto2112 added a comment. Lock earlier in operator= Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157654/new/ https://reviews.llvm.org/D157654 Files: lldb/include/lldb/Host/posix/PipePosix.h

[Lldb-commits] [PATCH] D157760: [lldb] Properly protect the Communication class with reader/writer lock

augusto2112 created this revision. augusto2112 added reviewers: JDevlieghere, bulbazord. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch picks up where https://reviews.llvm.org/D157159 lef

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 updated this revision to Diff 549539. augusto2112 added a comment. Update to two shared mutexes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157654/new/ https://reviews.llvm.org/D157654 Files: lldb/include/lldb/Host/posix/PipePosix.

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 added a comment. @JDevlieghere I updated this to two shared mutexes because I'm assuming you can have more than one concurrent read and more than one concurrent write. If this is wrong I can go back to two regular mutexes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 updated this revision to Diff 549548. augusto2112 added a comment. Changed to regular mutex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157654/new/ https://reviews.llvm.org/D157654 Files: lldb/include/lldb/Host/posix/PipePosix.h

[Lldb-commits] [PATCH] D157760: [lldb] Properly protect the Communication class with reader/writer lock

augusto2112 added inline comments. Comment at: lldb/include/lldb/Core/Communication.h:86-89 + lldb_private::Connection *GetConnection() { +std::shared_lock guard(m_connection_mutex); +return m_connection_sp.get(); + } bulbazord wrote: > This isn't neces

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

This revision was automatically updated to reflect the committed changes. Closed by commit rG22413641e236: [lldb] Fix data race in PipePosix (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157654/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D157648: [lldb] Fix data race in Process

augusto2112 added a comment. @JDevlieghere do you have any opinions on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157648/new/ https://reviews.llvm.org/D157648 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D157760: [lldb] Properly protect the Communication class with reader/writer lock

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5d16957207ce: [lldb] Properly protect the Communication class with reader/writer lock (authored by augusto2112). Reposito

[Lldb-commits] [PATCH] D158034: [lldb] Fix data race in ThreadList

augusto2112 created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ThreadSanitizer reports the following issue: Write of size 8 at 0x00010

[Lldb-commits] [PATCH] D158035: [lldb] Protect RNBRemote from a data race

augusto2112 created this revision. augusto2112 added reviewers: JDevlieghere, bulbazord, jingham. Herald added a subscriber: kristof.beyls. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thread sani

[Lldb-commits] [PATCH] D158034: [lldb] Fix data race in ThreadList

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb9006324970: [lldb] Fix data race in ThreadList (authored by augusto2112). Changed prior to commit: https://reviews.llvm.org/D158034?vs=550519&id=551673#toc Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [PATCH] D157648: [lldb] Fix data race in Process

This revision was automatically updated to reflect the committed changes. Closed by commit rG79a8e006dbc4: [lldb] Fix data race in Process (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157648/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D115723: [lldb] Fix ABIMacOSX_arm64::PrepareTrivialCall logging

augusto2112 created this revision. Herald added subscribers: pengfei, kristof.beyls. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Make the logging message print ABIMacOSX_arm64 instead of ABISysV_x86_64. Repository: rG LL

[Lldb-commits] [PATCH] D115723: [lldb] Fix ABIMacOSX_arm64::PrepareTrivialCall logging

augusto2112 abandoned this revision. augusto2112 added a comment. Looks like this was already fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115723/new/ https://reviews.llvm.org/D115723 ___ lldb-co

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

augusto2112 accepted this revision. augusto2112 added a comment. This revision is now accepted and ready to land. I liked the small cleanups in the code as well! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116491/new/ https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D118265: [lldb] Make ReadCStringFromMemory default to read from the file-cache.

augusto2112 created this revision. augusto2112 added reviewers: jasonmolenda, aprantl. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118265 Files: lldb/includ

[Lldb-commits] [PATCH] D118265: [lldb] Make ReadCStringFromMemory default to read from the file-cache.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb414954a5f1c: [lldb] Make ReadCStringFromMemory default to read from the file-cache. (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D118494: [lldb] Observe SG_READ_ONLY flag in MachO binaries

augusto2112 requested changes to this revision. augusto2112 added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1436 result |= ePermissionsReadable; - if (seg_cmd.initprot & VM_PROT_WRIT

[Lldb-commits] [PATCH] D120578: [lldb] Implement ObjectFile::GetCStrFromSection

augusto2112 created this revision. augusto2112 added reviewers: aprantl, JDevlieghere. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120578 Files: lldb/includ

[Lldb-commits] [PATCH] D120578: [lldb] Implement ObjectFile::GetCStrFromSection

augusto2112 added inline comments. Comment at: lldb/include/lldb/Symbol/ObjectFile.h:677 + const char *GetCStrFromSection(Section *section, + lldb::offset_t section_offset) const; + aprantl wrote: > Should we call it `GetCStringFr

[Lldb-commits] [PATCH] D129319: [lldb] Add comments to describe m_memory_addr and IsInMemory

augusto2112 created this revision. augusto2112 added a reviewer: jasonmolenda. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129319

[Lldb-commits] [PATCH] D129319: [lldb] Add comments to describe m_memory_addr and IsInMemory

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ade38c28573: [lldb] Add comments to describe m_memory_addr and IsInMemory (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129319/ne

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

augusto2112 created this revision. augusto2112 added reviewers: jingham, labath, aprantl. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It may be useful to search symbol table entries by mangled in

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

augusto2112 added a comment. @aprantl do you mean dumping this with `lldb-test`? I'm not seeing a way to do this. If you're thinking about `symbols` that reads the symbol file not the symbol table. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

augusto2112 added a comment. In D130803#3690754 , @labath wrote: > Who sets this flag? How do you intend to use it? I need this change downstream to search for certain swift mangled names by querying `Module::FindSymbolsMatchingRegExAndType`. It seemed

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

augusto2112 updated this revision to Diff 449440. augusto2112 added a comment. Added test and updated functions to use Mangled::NamePreference instead of a bool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130803/new/ https://reviews.llvm.org/D13

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

augusto2112 updated this revision to Diff 449483. augusto2112 added a comment. Removed __unwind_info and __eh_frame sections from test yaml file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130803/new/ https://reviews.llvm.org/D130803 Files: l

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

augusto2112 updated this revision to Diff 449712. augusto2112 added a comment. Updated test to use elf object file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130803/new/ https://reviews.llvm.org/D130803 Files: lldb/include/lldb/Core/Module.h

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3aef968ec3fa: [lldb] Allow SymbolTable regex search functions to match mangled name (authored by augusto2112). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

augusto2112 created this revision. augusto2112 added reviewers: clayborg, labath, jingham. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

augusto2112 added a comment. In D131531#3711618 , @clayborg wrote: > Is this new constructor going to be used elsewhere? It would be great to get > more description on why this is desired/needed? I'm implementing a cache for swift type metadata for down

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

augusto2112 updated this revision to Diff 451549. augusto2112 added a comment. Added a static 'GetLLDBIndexCachePolicy' function, removed the constructor without any policies Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131531/new/ https://review

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

augusto2112 updated this revision to Diff 451565. augusto2112 added a comment. Made GetLLDBIndexCachePolicy public Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131531/new/ https://reviews.llvm.org/D131531 Files: lldb/include/lldb/Core/DataFileC

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6c5944d05e8: [lldb] Allow DataFileCache to be constructed with a different policy (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D132382: [lldb] Remove prefer-dynamic-value test override

augusto2112 accepted this revision. augusto2112 added a comment. I think this is a good change. One related thing that we could look into fixing is that currently both run-target and no-run-target do the **exact** same thing. Not sure if we could remove one of them since this could break user's

[Lldb-commits] [PATCH] D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type

augusto2112 added a comment. Hi @zequanwu, your patch's new test seems to be failing on CI (https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/). Could you fix it or revert the changes? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

augusto2112 created this revision. augusto2112 added a reviewer: aprantl. Herald added a subscriber: inglorion. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Make the lldb test target depend on LTO

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

augusto2112 added a comment. @DavidSpickett right now if you don't have LTO the test will run but fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140051/new/ https://reviews.llvm.org/D140051 ___ lldb

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

augusto2112 added a comment. @DavidSpickett thanks for the review, I've updated the commit message to be clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140051/new/ https://reviews.llvm.org/D140051 _

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

This revision was automatically updated to reflect the committed changes. Closed by commit rGf85cc6009aa7: [lldb] Add LTO dependency to lldb test suite (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140051/new/ https://revi

[Lldb-commits] [PATCH] D141165: [lldb] Fix symbol table use after free

augusto2112 created this revision. augusto2112 added reviewers: labath, jingham, JDevlieghere. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The symbol file stores a raw pointer to the main object

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 created this revision. augusto2112 added reviewers: labath, clayborg, aprantl. Herald added a reviewer: shafik. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Storing raw pointers in Die

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 added a comment. Herald added a subscriber: JDevlieghere. I changed the value of the map to a shared pointer, but could change it to a weak pointer instead, not sure which is more appropriate in this case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 added a comment. In D141318#4037557 , @JDevlieghere wrote: > In D141318#4037541 , @augusto2112 > wrote: > >> I changed the value of the map to a shared pointer, but could change it to a >> weak poin

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 added a comment. In D141318#4037687 , @JDevlieghere wrote: > In D141318#4037640 , @augusto2112 > wrote: > >> In D141318#4037557 , @JDevlieghere >> wrote: >>

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 added a comment. In D141318#4045372 , @clayborg wrote: > Each SymbolFile has its own type list that keeps the shared pointers to all > types. So there should be no need for any of these changes here unless > someone isn't correctly storing a

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 updated this revision to Diff 489137. augusto2112 added a comment. Make Type constructor private Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141318/new/ https://reviews.llvm.org/D141318 Files: lldb/include/lldb/Symbol/SymbolFile.h

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 added a comment. @clayborg I went with your suggestion and made Type's constructor private, and any new Type created is automatically added to the TypeList. I think later on we should make TypeList keep a vector of unique pointers instead of shared ones. Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

augusto2112 created this revision. augusto2112 added a reviewer: clayborg. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. SymbolFiles should be the only point of creation of Types to ensure that the

[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

augusto2112 added a comment. @clayborg the intended usage here is to create a copy of the type in the same symbol file. I could add a sanity check that makes sure we're not creating a copy of something that isn't in the symbol file's type list in debug mode. Would that be enough? Repository:

[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

augusto2112 added a comment. @clayborg we have one instance downstream where we need to keep two types around. One for the original type and one for a slightly modified one (here

[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

augusto2112 updated this revision to Diff 490951. augusto2112 added a comment. Added check for same symbol file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142052/new/ https://reviews.llvm.org/D142052 Files: lldb/include/lldb/Symbol/SymbolFile

[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG901ba0fcae36: [lldb] Implement SymbolFile::CopyType (authored by a

[Lldb-commits] [PATCH] D143772: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN

augusto2112 created this revision. augusto2112 added reviewers: JDevlieghere, jingham, aprantl. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In situations where only LLDB is ASANified, a false pos

[Lldb-commits] [PATCH] D143772: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN

augusto2112 added a comment. In D143772#4119213 , @JDevlieghere wrote: > Why are only these two tests affected? Should this be something we set > globally for all the tests? The API tests already have support for forwarding > `ASAN_OPTIONS` and lit has

[Lldb-commits] [PATCH] D143772: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN

This revision was automatically updated to reflect the committed changes. Closed by commit rG294ca122956f: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN (authored by augusto2112). Changed prior to commit: https://reviews.llvm.org/D143772?vs=496567&id=496643#toc Repository:

[Lldb-commits] [PATCH] D145612: [lldb] Only replace valobj with persisted one if not null in DWIMPrint

augusto2112 created this revision. augusto2112 added a reviewer: kastiglione. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145612

[Lldb-commits] [PATCH] D145612: [lldb] Only replace valobj with persisted one if not null in DWIMPrint

This revision was automatically updated to reflect the committed changes. Closed by commit rG581ac50d58b9: [lldb] Only replace valobj with persisted one if not null in DWIMPrint (authored by augusto2112). Changed prior to commit: https://reviews.llvm.org/D145612?vs=503503&id=503518#toc Reposit

[Lldb-commits] [PATCH] D146265: [lldb] Introduce SymbolFile::ParseAllLanguages

augusto2112 created this revision. augusto2112 added a reviewer: aprantl. Herald added a project: All. augusto2112 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, jplehr, sstefan1. Herald added a project: LLDB. SymbolFile::ParseAllLang

[Lldb-commits] [PATCH] D146265: [lldb] Introduce SymbolFile::ParseAllLanguages

This revision was automatically updated to reflect the committed changes. Closed by commit rGf03cd763384b: [lldb] Introduce SymbolFile::ParseAllLanguages (authored by augusto2112). Changed prior to commit: https://reviews.llvm.org/D146265?vs=505952&id=506307#toc Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D146679: [lldb] Add support for the DW_AT_trampoline attribute with mangled names

augusto2112 created this revision. augusto2112 added reviewers: aprantl, jingham, dblaikie. Herald added a reviewer: shafik. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds support fo

[Lldb-commits] [PATCH] D146679: [lldb] Add support for the DW_AT_trampoline attribute with mangled names

augusto2112 updated this revision to Diff 507841. augusto2112 marked 14 inline comments as done. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146679/new/ https://reviews.llvm.org/D146679 Files: ll

[Lldb-commits] [PATCH] D146679: [lldb] Add support for the DW_AT_trampoline attribute with mangled names

augusto2112 added inline comments. Comment at: lldb/include/lldb/Target/Target.h:253 + bool GetEnableTrampolineSupport() const; + JDevlieghere wrote: > What does trampoline "support" mean? Could this be named something more > descriptive? From the description

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

augusto2112 created this revision. augusto2112 added reviewers: aprantl, jingham, dblaikie. Herald added a reviewer: shafik. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds support fo

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

augusto2112 added a comment. In D147292#4238820 , @JDevlieghere wrote: > There seems to be overlap in the code added in this patch and D146679 > . Does one supersede the other or is there > a dependency? If it's the la

[Lldb-commits] [PATCH] D146679: [lldb] Add support for the DW_AT_trampoline attribute with mangled names

augusto2112 abandoned this revision. augusto2112 added a comment. Abandoning in favor of https://reviews.llvm.org/D147292/. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146679/new/ https://reviews.llvm.org/D146679

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

augusto2112 updated this revision to Diff 511549. augusto2112 marked 3 inline comments as done. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147292/new/ https://reviews.llvm.org/D147292 Files: lld

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::ContainsCompileOption

augusto2112 created this revision. augusto2112 added a reviewer: aprantl. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Implement SymbolFile::ContainsCompileOption, which returns true if the string

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::ContainsCompileOption

augusto2112 added a comment. In D147748#4251543 , @JDevlieghere wrote: > At a higher level I wonder if this is really the best interface. If you ever > need all the compile options, you probably want something like `Args > SymbolFile::GetCompileOptions

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::ContainsCompileOption

augusto2112 updated this revision to Diff 511815. augusto2112 marked an inline comment as done. augusto2112 added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. Changed implementation to GetCompileOptions Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::GetCompileOptions

augusto2112 added inline comments. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:441 + /// associated with that compilation unit. + std::unordered_map GetCompileOptions() { +std::unordered_map args; JDevlieghere wrote: > Any reason you picked `unordered

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::GetCompileOptions

This revision was automatically updated to reflect the committed changes. Closed by commit rG19d969e340c9: [lldb] Implement SymbolFile::GetCompileOptions (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147748/new/ https://re

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

augusto2112 created this revision. augusto2112 added a reviewer: aprantl. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Value::ValueType is a superset of AddressType. Add a function to convert an A

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

augusto2112 added a comment. In D150826#4351518 , @bulbazord wrote: > Where do you plan on using this? Downstream I assume? Yes, I need this downstream, but seemed general enough to add upstream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

augusto2112 updated this revision to Diff 523219. augusto2112 added a comment. Add llvm_unreachable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150826/new/ https://reviews.llvm.org/D150826 Files: lldb/include/lldb/Core/Value.h lldb/source/Co

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fe9718dd5f2: [lldb] Implement GetValueTypeFromAddressType (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150826/new/ https://revi

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

augusto2112 created this revision. augusto2112 added reviewers: kastiglione, aprantl, DavidSpickett. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The `target.max-children-depth` setting and `--dep

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

augusto2112 updated this revision to Diff 527670. augusto2112 added a comment. Herald added a subscriber: JDevlieghere. Add radar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151950/new/ https://reviews.llvm.org/D151950 Files: lldb/source/DataF

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

augusto2112 updated this revision to Diff 529463. augusto2112 added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151950/new/ https://reviews.llvm.org/D151950 Files: lldb/source/DataFormatters/ValueObjectPrinter.cpp lldb/te

  1   2   3   >