augusto2112 requested changes to this revision.
augusto2112 added inline comments.
This revision now requires changes to proceed.
================
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1436
result |= ePermissionsReadable;
- if (seg_cmd.initprot & VM_PROT_WRITE)
+ if ((seg_cmd.initprot & VM_PROT_WRITE) && !(seg_cmd.flags & SG_READ_ONLY))
result |= ePermissionsWritable;
----------------
Could we add a new value in the enumeration? Something like
ePermissionsLinkerWritable? As it is right now this would be dangerous for the
existing file-cache optimization as we'd happily read pointers that are
supposed to be fixed by the linker from the file-cache.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118494/new/
https://reviews.llvm.org/D118494
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
