augusto2112 added a comment. In D147748#4251543 <https://reviews.llvm.org/D147748#4251543>, @JDevlieghere wrote:
> At a higher level I wonder if this is really the best interface. If you ever > need all the compile options, you probably want something like `Args > SymbolFile::GetCompileOptions()`. Wouldn't that be a more generic way to do > the same thing here? Or do we expect that for `DW_AT_APPLE_flags` the only > possible use case is to check whether a particular flag is set? I agree. I implemented it in such a a way to mirror the `GetCompileOption` function (which apparently doesn't exist upstream anymore). I'll update it to return the `Args` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147748/new/ https://reviews.llvm.org/D147748 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
