augusto2112 created this revision.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
augusto2112 requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
ThreadSanitizer reports the following issue:
Write of size 8 at 0x00010a70abb0 by thread T3 (mutexes: write M0):
#0 lldb_private::ThreadList::Update(lldb_private::ThreadList&)
ThreadList.cpp:741 (liblldb.18.0.0git.dylib:arm64+0x5dedf4) (BuildId:
9bced2aafa373580ae9d750d9cf79a8f32000000200000000100000000000e00)
#1 lldb_private::Process::UpdateThreadListIfNeeded() Process.cpp:1212
(liblldb.18.0.0git.dylib:arm64+0x53bbec) (BuildId:
9bced2aafa373580ae9d750d9cf79a8f32000000200000000100000000000e00)
Previous read of size 8 at 0x00010a70abb0 by main thread (mutexes: write M1):
#0 lldb_private::ThreadList::GetMutex() const ThreadList.cpp:785
(liblldb.18.0.0git.dylib:arm64+0x5df138) (BuildId:
9bced2aafa373580ae9d750d9cf79a8f32000000200000000100000000000e00)
#1 lldb_private::ThreadList::DidResume() ThreadList.cpp:656
(liblldb.18.0.0git.dylib:arm64+0x5de5c0) (BuildId:
9bced2aafa373580ae9d750d9cf79a8f32000000200000000100000000000e00)
#2 lldb_private::Process::PrivateResume() Process.cpp:3130
(liblldb.18.0.0git.dylib:arm64+0x53cd7c) (BuildId:
9bced2aafa373580ae9d750d9cf79a8f32000000200000000100000000000e00)
Fix this by only using the mutex in ThreadList and removing the one in
process entirely.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D158034
Files:
lldb/include/lldb/Target/Process.h
lldb/include/lldb/Target/ThreadCollection.h
lldb/include/lldb/Target/ThreadList.h
lldb/source/Target/Process.cpp
lldb/source/Target/ThreadList.cpp
Index: lldb/source/Target/ThreadList.cpp
===================================================================
--- lldb/source/Target/ThreadList.cpp
+++ lldb/source/Target/ThreadList.cpp
@@ -736,7 +736,8 @@
if (this != &rhs) {
// Lock both mutexes to make sure neither side changes anyone on us while
// the assignment occurs
- std::scoped_lock<std::recursive_mutex, std::recursive_mutex>
guard(GetMutex(), rhs.GetMutex());
+ std::scoped_lock<std::recursive_mutex, std::recursive_mutex> guard(
+ GetMutex(), rhs.GetMutex());
m_process = rhs.m_process;
m_stop_id = rhs.m_stop_id;
@@ -781,10 +782,6 @@
(*pos)->Flush();
}
-std::recursive_mutex &ThreadList::GetMutex() const {
- return m_process->m_thread_mutex;
-}
-
ThreadList::ExpressionExecutionThreadPusher::ExpressionExecutionThreadPusher(
lldb::ThreadSP thread_sp)
: m_thread_list(nullptr), m_tid(LLDB_INVALID_THREAD_ID) {
Index: lldb/source/Target/Process.cpp
===================================================================
--- lldb/source/Target/Process.cpp
+++ lldb/source/Target/Process.cpp
@@ -435,7 +435,7 @@
Listener::MakeListener("lldb.process.internal_state_listener")),
m_mod_id(), m_process_unique_id(0), m_thread_index_id(0),
m_thread_id_to_index_id_map(), m_exit_status(-1), m_exit_string(),
- m_exit_status_mutex(), m_thread_mutex(), m_thread_list_real(this),
+ m_exit_status_mutex(), m_thread_list_real(this),
m_thread_list(this), m_thread_plans(*this), m_extended_thread_list(this),
m_extended_thread_stop_id(0), m_queue_list(this),
m_queue_list_stop_id(0),
m_notifications(), m_image_tokens(), m_listener_sp(listener_sp),
@@ -2457,7 +2457,7 @@
}
void Process::LoadOperatingSystemPlugin(bool flush) {
- std::lock_guard<std::recursive_mutex> guard(m_thread_mutex);
+ std::lock_guard<std::recursive_mutex> guard(GetThreadList().GetMutex());
if (flush)
m_thread_list.Clear();
m_os_up.reset(OperatingSystem::FindPlugin(this, nullptr));
Index: lldb/include/lldb/Target/ThreadList.h
===================================================================
--- lldb/include/lldb/Target/ThreadList.h
+++ lldb/include/lldb/Target/ThreadList.h
@@ -133,8 +133,6 @@
void SetStopID(uint32_t stop_id);
- std::recursive_mutex &GetMutex() const override;
-
void Update(ThreadList &rhs);
protected:
Index: lldb/include/lldb/Target/ThreadCollection.h
===================================================================
--- lldb/include/lldb/Target/ThreadCollection.h
+++ lldb/include/lldb/Target/ThreadCollection.h
@@ -47,7 +47,7 @@
return ThreadIterable(m_threads, GetMutex());
}
- virtual std::recursive_mutex &GetMutex() const { return m_mutex; }
+ std::recursive_mutex &GetMutex() const { return m_mutex; }
protected:
collection m_threads;
Index: lldb/include/lldb/Target/Process.h
===================================================================
--- lldb/include/lldb/Target/Process.h
+++ lldb/include/lldb/Target/Process.h
@@ -2957,7 +2957,6 @@
std::string m_exit_string; ///< A textual description of why a process
exited.
std::mutex m_exit_status_mutex; ///< Mutex so m_exit_status m_exit_string can
///be safely accessed from multiple threads
- std::recursive_mutex m_thread_mutex;
ThreadList m_thread_list_real; ///< The threads for this process as are known
///to the protocol we are debugging with
ThreadList m_thread_list; ///< The threads for this process as the user will
Index: lldb/source/Target/ThreadList.cpp
===================================================================
--- lldb/source/Target/ThreadList.cpp
+++ lldb/source/Target/ThreadList.cpp
@@ -736,7 +736,8 @@
if (this != &rhs) {
// Lock both mutexes to make sure neither side changes anyone on us while
// the assignment occurs
- std::scoped_lock<std::recursive_mutex, std::recursive_mutex> guard(GetMutex(), rhs.GetMutex());
+ std::scoped_lock<std::recursive_mutex, std::recursive_mutex> guard(
+ GetMutex(), rhs.GetMutex());
m_process = rhs.m_process;
m_stop_id = rhs.m_stop_id;
@@ -781,10 +782,6 @@
(*pos)->Flush();
}
-std::recursive_mutex &ThreadList::GetMutex() const {
- return m_process->m_thread_mutex;
-}
-
ThreadList::ExpressionExecutionThreadPusher::ExpressionExecutionThreadPusher(
lldb::ThreadSP thread_sp)
: m_thread_list(nullptr), m_tid(LLDB_INVALID_THREAD_ID) {
Index: lldb/source/Target/Process.cpp
===================================================================
--- lldb/source/Target/Process.cpp
+++ lldb/source/Target/Process.cpp
@@ -435,7 +435,7 @@
Listener::MakeListener("lldb.process.internal_state_listener")),
m_mod_id(), m_process_unique_id(0), m_thread_index_id(0),
m_thread_id_to_index_id_map(), m_exit_status(-1), m_exit_string(),
- m_exit_status_mutex(), m_thread_mutex(), m_thread_list_real(this),
+ m_exit_status_mutex(), m_thread_list_real(this),
m_thread_list(this), m_thread_plans(*this), m_extended_thread_list(this),
m_extended_thread_stop_id(0), m_queue_list(this), m_queue_list_stop_id(0),
m_notifications(), m_image_tokens(), m_listener_sp(listener_sp),
@@ -2457,7 +2457,7 @@
}
void Process::LoadOperatingSystemPlugin(bool flush) {
- std::lock_guard<std::recursive_mutex> guard(m_thread_mutex);
+ std::lock_guard<std::recursive_mutex> guard(GetThreadList().GetMutex());
if (flush)
m_thread_list.Clear();
m_os_up.reset(OperatingSystem::FindPlugin(this, nullptr));
Index: lldb/include/lldb/Target/ThreadList.h
===================================================================
--- lldb/include/lldb/Target/ThreadList.h
+++ lldb/include/lldb/Target/ThreadList.h
@@ -133,8 +133,6 @@
void SetStopID(uint32_t stop_id);
- std::recursive_mutex &GetMutex() const override;
-
void Update(ThreadList &rhs);
protected:
Index: lldb/include/lldb/Target/ThreadCollection.h
===================================================================
--- lldb/include/lldb/Target/ThreadCollection.h
+++ lldb/include/lldb/Target/ThreadCollection.h
@@ -47,7 +47,7 @@
return ThreadIterable(m_threads, GetMutex());
}
- virtual std::recursive_mutex &GetMutex() const { return m_mutex; }
+ std::recursive_mutex &GetMutex() const { return m_mutex; }
protected:
collection m_threads;
Index: lldb/include/lldb/Target/Process.h
===================================================================
--- lldb/include/lldb/Target/Process.h
+++ lldb/include/lldb/Target/Process.h
@@ -2957,7 +2957,6 @@
std::string m_exit_string; ///< A textual description of why a process exited.
std::mutex m_exit_status_mutex; ///< Mutex so m_exit_status m_exit_string can
///be safely accessed from multiple threads
- std::recursive_mutex m_thread_mutex;
ThreadList m_thread_list_real; ///< The threads for this process as are known
///to the protocol we are debugging with
ThreadList m_thread_list; ///< The threads for this process as the user will
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
