[Lldb-commits] [lldb] 8be3021 - [lldb] Move clang-based files out of Symbol

2020-01-31 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2020-01-31T12:20:10-08:00 New Revision: 8be30215feeff1d82fe2bde0c9fb0e6cd1bfc15c URL: https://github.com/llvm/llvm-project/commit/8be30215feeff1d82fe2bde0c9fb0e6cd1bfc15c DIFF: https://github.com/llvm/llvm-project/commit/8be30215feeff1d82fe2bde0c9fb0e6cd1bfc15c.diff

[Lldb-commits] [lldb] 8e36d24 - [lldb] Remove unused CPPLanguageRuntime dependency

2020-01-31 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2020-01-31T15:23:18-08:00 New Revision: 8e36d24fca9f4586bcde588a10c8892ff62e1ff5 URL: https://github.com/llvm/llvm-project/commit/8e36d24fca9f4586bcde588a10c8892ff62e1ff5 DIFF: https://github.com/llvm/llvm-project/commit/8e36d24fca9f4586bcde588a10c8892ff62e1ff5.diff

[Lldb-commits] [lldb] 2637769 - [lldb] Remove LanguageRuntime::GetOverrideExprOptions

2020-01-31 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2020-01-31T22:05:23-08:00 New Revision: 2637769b9f38010082276b7b839a17b102d1ac93 URL: https://github.com/llvm/llvm-project/commit/2637769b9f38010082276b7b839a17b102d1ac93 DIFF: https://github.com/llvm/llvm-project/commit/2637769b9f38010082276b7b839a17b102d1ac93.diff

[Lldb-commits] [lldb] 5b0c8dd - [lldb] Delete ClangForward.h

2020-02-03 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2020-02-03T10:43:12-08:00 New Revision: 5b0c8dd3a4fdeafd0a4414e43c94c10732d3d2d8 URL: https://github.com/llvm/llvm-project/commit/5b0c8dd3a4fdeafd0a4414e43c94c10732d3d2d8 DIFF: https://github.com/llvm/llvm-project/commit/5b0c8dd3a4fdeafd0a4414e43c94c10732d3d2d8.diff

[Lldb-commits] [lldb] 3014efe - [lldb] Remove unused parameter from ValueObject::GetExpressionPath

2020-02-03 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2020-02-03T10:50:38-08:00 New Revision: 3014efe071988724b67f2dc106d36002aa03fa7d URL: https://github.com/llvm/llvm-project/commit/3014efe071988724b67f2dc106d36002aa03fa7d DIFF: https://github.com/llvm/llvm-project/commit/3014efe071988724b67f2dc106d36002aa03fa7d.diff

[Lldb-commits] [lldb] 7c9ebdd - [lldb] Remove clang classes from lldb-forward.h

2020-02-04 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2020-02-04T14:23:58-08:00 New Revision: 7c9ebdd3d6ae405dc6702e544453a51862daf948 URL: https://github.com/llvm/llvm-project/commit/7c9ebdd3d6ae405dc6702e544453a51862daf948 DIFF: https://github.com/llvm/llvm-project/commit/7c9ebdd3d6ae405dc6702e544453a51862daf948.diff

[Lldb-commits] [lldb] 8b79bed - [lldb] Remove unused references to ClangExpressionDeclMap

2020-02-04 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2020-02-04T14:41:24-08:00 New Revision: 8b79bed0f3c90c539865f2e55f664daa7930865d URL: https://github.com/llvm/llvm-project/commit/8b79bed0f3c90c539865f2e55f664daa7930865d DIFF: https://github.com/llvm/llvm-project/commit/8b79bed0f3c90c539865f2e55f664daa7930865d.diff

[Lldb-commits] [lldb] 48b8e3b - [lldb] Delete commented-out code

2020-02-04 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2020-02-04T15:33:06-08:00 New Revision: 48b8e3be51c7fa2bda904bc495af47c7b368e748 URL: https://github.com/llvm/llvm-project/commit/48b8e3be51c7fa2bda904bc495af47c7b368e748 DIFF: https://github.com/llvm/llvm-project/commit/48b8e3be51c7fa2bda904bc495af47c7b368e748.diff

[Lldb-commits] [lldb] fc0ba63 - [lldb] Rename Type::ResolveClangType to Type::ResolveCompilerType

2020-02-04 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2020-02-04T15:40:48-08:00 New Revision: fc0ba63f8691eb98e9f7d670f23b145c66deec7e URL: https://github.com/llvm/llvm-project/commit/fc0ba63f8691eb98e9f7d670f23b145c66deec7e DIFF: https://github.com/llvm/llvm-project/commit/fc0ba63f8691eb98e9f7d670f23b145c66deec7e.diff

[Lldb-commits] [lldb] [lldb] Add early CMake check for 'make' tool (PR #111531)

2024-10-08 Thread Alex Langford via lldb-commits
bulbazord wrote: +1 to what Jonas said. Making `dotest.py` more explicit makes reproducing test behavior more reliable. :) https://github.com/llvm/llvm-project/pull/111531 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [lldb][Docs] Fix typo in `tutorial.rst` (PR #111326)

2024-10-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/111326 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] DynamicLoaderDarwin load images in parallel (PR #110439)

2024-10-07 Thread Alex Langford via lldb-commits
bulbazord wrote: Love to see this kind of work done. FWIW I worked on improving the performance of `ObjectFileMachO::ParseSymtab` in https://github.com/llvm/llvm-project/pull/106791. That change to reverted and I haven't had the time to figure out what happened yet though... https://github.com

[Lldb-commits] [lldb] [llvm] [lldb] Move SBLanguages.h out of API tree (PR #111929)

2024-10-15 Thread Alex Langford via lldb-commits
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions { /// Set the language using a pair of language code and version as /// defined by the DWARF 6 specification. /// WARNING: These codes may change until DWARF 6 is finalized. - void SetLanguage(lldb::SBSourceLanguageNam

[Lldb-commits] [lldb] [lldb] Check for Python 'packaging' module at configuration time (PR #111747)

2024-10-09 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/111747 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add include for SBLanguages in lldb-enumerations (PR #111907)

2024-10-10 Thread Alex Langford via lldb-commits
bulbazord wrote: My mental model is that everything in `lldb-enumerations.h` should be public and all the private enumerations should go in `lldb-private-enumerations.h`. In practice I think there are tons of things in `lldb-enumerations.h` that should not be public at all, but I'm not sure wh

[Lldb-commits] [lldb] [lldb] Add include for SBLanguages in lldb-enumerations (PR #111907)

2024-10-11 Thread Alex Langford via lldb-commits
bulbazord wrote: > I agree with that, but the argument here was going the other way. > lldb-enumerations.h are a base set of enumerations that anybody using LLDB, > either lldb_private or the SB API's are free to use. But the SB API's are > purely wrappers around lldb_private API's, and so sho

[Lldb-commits] [lldb] [llvm] [lldb] Move SBLanguages.h out of API tree (PR #111929)

2024-10-11 Thread Alex Langford via lldb-commits
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions { /// Set the language using a pair of language code and version as /// defined by the DWARF 6 specification. /// WARNING: These codes may change until DWARF 6 is finalized. - void SetLanguage(lldb::SBSourceLanguageNam

[Lldb-commits] [lldb] [llvm] [lldb] Move SBLanguages.h out of API tree (PR #111929)

2024-10-11 Thread Alex Langford via lldb-commits
https://github.com/bulbazord requested changes to this pull request. https://github.com/llvm/llvm-project/pull/111929 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Speed up FindInMemory tests (PR #111951)

2024-10-11 Thread Alex Langford via lldb-commits
@@ -6,27 +6,30 @@ UNALIGNED_INSTANCE_PATTERN_HEAP = ALIGNED_INSTANCE_PATTERN_HEAP[1:] -def GetAlignedRange(test_base): +def GetAlignedRange(test_base, shrink=False): frame = test_base.thread.GetSelectedFrame() ex = frame.EvaluateExpression("aligned_string_ptr")

[Lldb-commits] [lldb] [lldb] Document SymbolFileJSON (PR #112938)

2024-10-18 Thread Alex Langford via lldb-commits
@@ -0,0 +1,201 @@ +JSON Symbol File Format +=== + +The JSON symbol file format encodes symbols in a text based, human readable +format. JSON symbol files can be used to symbolicate programs that miss symbol bulbazord wrote: Suggestion: `miss`

[Lldb-commits] [lldb] [lldb] Document SymbolFileJSON (PR #112938)

2024-10-18 Thread Alex Langford via lldb-commits
@@ -0,0 +1,201 @@ +JSON Symbol File Format +=== + +The JSON symbol file format encodes symbols in a text based, human readable +format. JSON symbol files can be used to symbolicate programs that miss symbol +information, for example because they have been strip

[Lldb-commits] [lldb] [lldb] Document SymbolFileJSON (PR #112938)

2024-10-18 Thread Alex Langford via lldb-commits
@@ -0,0 +1,201 @@ +JSON Symbol File Format +=== + +The JSON symbol file format encodes symbols in a text based, human readable +format. JSON symbol files can be used to symbolicate programs that miss symbol +information, for example because they have been strip

[Lldb-commits] [lldb] [lldb] Document SymbolFileJSON (PR #112938)

2024-10-18 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/112938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Narrow scope of -Wno-deprecated-declarations (NFC) (PR #112276)

2024-10-16 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. 🥳 https://github.com/llvm/llvm-project/pull/112276 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][NFC] Document DYLIB_NAME Makefile variable (PR #112735)

2024-10-17 Thread Alex Langford via lldb-commits
@@ -13,6 +13,13 @@ # the building of the a.out executable program. For example, # DYLIB_ONLY := YES # +# When specifying one of the DYLIB_*_SOURCES variables, DYLIB_NAME +# controls the name of the produced dylib. E.g., if set to "foo", +# the generated dylib will be called "f

[Lldb-commits] [lldb] [lldb] Expose structured command diagnostics via the SBAPI. (PR #112109)

2024-10-14 Thread Alex Langford via lldb-commits
@@ -123,30 +123,79 @@ void CommandReturnObject::SetError(llvm::Error error) { } } -llvm::StringRef -CommandReturnObject::GetInlineDiagnosticString(unsigned indent) { - RenderDiagnosticDetails(m_diag_stream, indent, true, m_diagnostics); +std::string CommandReturnObject::Get

[Lldb-commits] [lldb] [lldb] Expose structured command diagnostics via the SBAPI. (PR #112109)

2024-10-14 Thread Alex Langford via lldb-commits
@@ -3187,11 +3185,12 @@ void CommandInterpreter::IOHandlerInputComplete(IOHandler &io_handler, io_handler.GetFlags().Test(eHandleCommandFlagPrintResult)) || io_handler.GetFlags().Test(eHandleCommandFlagPrintErrors)) { // Display any inline diagnostics first. -

[Lldb-commits] [lldb] [lldb] Expose structured command diagnostics via the SBAPI. (PR #112109)

2024-10-14 Thread Alex Langford via lldb-commits
@@ -2636,20 +2636,18 @@ void CommandInterpreter::HandleCommands(const StringList &commands, } if (!success || !tmp_result.Succeeded()) { - llvm::StringRef error_msg = tmp_result.GetErrorString(); + std::string error_msg = tmp_result.GetErrorString();

[Lldb-commits] [lldb] [llvm] [lldb] Move SBLanguages.h out of API tree (PR #111929)

2024-10-14 Thread Alex Langford via lldb-commits
@@ -136,6 +136,8 @@ class LLDB_API SBWatchpoint; class LLDB_API SBWatchpointOptions; class LLDB_API SBUnixSignals; +typedef SourceLanguageName SBSourceLanguageName; bulbazord wrote: I'm not sure a typedef is enough here. It ends up being little more than syn

[Lldb-commits] [lldb] [llvm] [lldb] Move SBLanguages.h out of API tree (PR #111929)

2024-10-14 Thread Alex Langford via lldb-commits
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions { /// Set the language using a pair of language code and version as /// defined by the DWARF 6 specification. /// WARNING: These codes may change until DWARF 6 is finalized. - void SetLanguage(lldb::SBSourceLanguageNam

[Lldb-commits] [lldb] [lldb] Fix API test for file redirection to existing files (PR #114119)

2024-10-29 Thread Alex Langford via lldb-commits
@@ -99,31 +99,45 @@ def test_stdout_stderr_redirection(self): @expectedFlakeyLinux(bugnumber="llvm.org/pr26437") @skipIfDarwinEmbedded # debugserver can't create/write files on the device def test_stdout_stderr_redirection_to_existing_files(self): -"""Exerc

[Lldb-commits] [lldb] [llvm] [DWARF] Fix arity of DW_OP_bra (PR #114136)

2024-10-29 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/114136 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Fix write only file action to truncate the file (PR #112657)

2024-10-29 Thread Alex Langford via lldb-commits
@@ -6,6 +6,8 @@ // //===--===// +#include bulbazord wrote: CI is good enough for me here. I've approved the PR. https://github.com/llvm/llvm-project/pull/112657 ___

[Lldb-commits] [lldb] [llvm] [lldb] Fix write only file action to truncate the file (PR #112657)

2024-10-29 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/112657 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a fuzzer for the DWARF Expression Evaluator (PR #114286)

2024-10-30 Thread Alex Langford via lldb-commits
@@ -0,0 +1,34 @@ +set(LLVM_LINK_COMPONENTS + Support + ) + +add_llvm_fuzzer(lldb-dwarf-expression-fuzzer + EXCLUDE_FROM_ALL + lldb-dwarf-expression-fuzzer.cpp + ) + +include_directories(${LLDB_SOURCE_ROOT}) bulbazord wrote: suggestion: Use `target_include_di

[Lldb-commits] [lldb] [lldb] Add a fuzzer for the DWARF Expression Evaluator (PR #114286)

2024-10-31 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/114286 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Disable automatically opening editor for TestSessionSave (PR #114469)

2024-11-01 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/114469 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve locking in PathMappingLists (NFC) (PR #114576)

2024-11-01 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/114576 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve locking in PathMappingLists (NFC) (PR #114576)

2024-11-01 Thread Alex Langford via lldb-commits
@@ -48,7 +48,10 @@ PathMappingList::PathMappingList(const PathMappingList &rhs) const PathMappingList &PathMappingList::operator=(const PathMappingList &rhs) { if (this != &rhs) { -std::scoped_lock locks(m_mutex, rhs.m_mutex); +std::scoped_lock pairs_locks(m_pairs_m

[Lldb-commits] [lldb] [lldb] Improve locking in PathMappingLists (NFC) (PR #114576)

2024-11-01 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/114576 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve locking in PathMappingLists (NFC) (PR #114576)

2024-11-01 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: It took me some time to read this and think about the implications, but I think this is generally okay. I left 1 comment about the order of lock acquisition for `operator=`. The only way I can see this going wrong is if a callback can mutate the list in

[Lldb-commits] [lldb] [lldb] Support true/false in ValueObject::SetValueFromCString (PR #115780)

2024-11-11 Thread Alex Langford via lldb-commits
@@ -2,10 +2,15 @@ int main() { NSDictionary* dic = @{@1 : @2}; +BOOL b = NO; NSLog(@"hello world"); //% dic = self.frame().FindVariable("dic") //% dic.SetPreferSyntheticValue(True) //% dic.SetPreferDynamicValue(lldb.eDynamicCanRunTarget) //% dic.Set

[Lldb-commits] [lldb] [lldb] Support true/false in ValueObject::SetValueFromCString (PR #115780)

2024-11-11 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/115780 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Disable automatically opening editor for TestSessionSave (PR #114469)

2024-10-31 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/114469 None >From 9a43932849dba04c11cbed2abcac41a3e64b4e06 Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Thu, 31 Oct 2024 14:40:59 -0700 Subject: [PATCH] [lldb] Disable automatically opening editor for TestSes

[Lldb-commits] [lldb] [lldb] Set LLDB_USE_NATIVE_PDB_READER at the directory level (PR #114455)

2024-10-31 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. This looks good to me. Probably want somebody more involved in windows to sign off though. This might not be the right setting to ask this, but is there a plan to use one of the PDB parsers over the other? Would it make sense to add this

[Lldb-commits] [lldb] [lldb/Interpreter] Add requirements to Scripted Interface abstract methods (PR #109063)

2024-09-18 Thread Alex Langford via lldb-commits
@@ -78,8 +100,11 @@ class ScriptedPythonInterface : virtual public ScriptedInterface { using namespace python; using Locker = ScriptInterpreterPythonImpl::Locker; -auto create_error = [](std::string message) { - return llvm::createStringError(llvm::inconverti

[Lldb-commits] [lldb] [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created (PR #106791)

2024-09-17 Thread Alex Langford via lldb-commits
bulbazord wrote: > Do we have a sense of whether it's just a broken test, or if the PR broke > some functionality? We tested the change on some internal scenarios and it > showed good improvement, so we'd like to cherry-pick this patch (or a new > patch). I'm not sure yet, I haven't had time

[Lldb-commits] [lldb] [lldb] Fix typos in various help messages. (PR #109851)

2024-09-24 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/109851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Replace lldb's DWARFFormValue::ValueType with llvm's (PR #109853)

2024-09-24 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM. One thing to note is that llvm's ValueType struct has an additional uint64_t element for a section index. I wonder if LLDB can make use of that element for something useful after some additional refactors? https://github.com/llvm/l

[Lldb-commits] [lldb] [lldb] Fix minor runCmd error message formatting (PR #110150)

2024-09-26 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/110150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread Alex Langford via lldb-commits
@@ -536,6 +536,33 @@ This command will run the thread in the current frame until it reaches line 100 in this frame or stops if it leaves the current frame. This is a pretty close equivalent to GDB's ``until`` command. +One other useful thing to note about the lldb stepping co

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread Alex Langford via lldb-commits
@@ -536,6 +536,33 @@ This command will run the thread in the current frame until it reaches line 100 in this frame or stops if it leaves the current frame. This is a pretty close equivalent to GDB's ``until`` command. +One other useful thing to note about the lldb stepping co

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/110167 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM, a few minor suggestions but nothing of great importance. Thanks for writing this up! https://github.com/llvm/llvm-project/pull/110167 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread Alex Langford via lldb-commits
@@ -536,6 +536,33 @@ This command will run the thread in the current frame until it reaches line 100 in this frame or stops if it leaves the current frame. This is a pretty close equivalent to GDB's ``until`` command. +One other useful thing to note about the lldb stepping co

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread Alex Langford via lldb-commits
@@ -536,6 +536,33 @@ This command will run the thread in the current frame until it reaches line 100 in this frame or stops if it leaves the current frame. This is a pretty close equivalent to GDB's ``until`` command. +One other useful thing to note about the lldb stepping co

[Lldb-commits] [lldb] [lldb/Interpreter] Add requirements to Scripted Interface abstract methods (PR #109063)

2024-09-19 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/109063 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change SymbolContext::GetAddressRangeFromHereToEndLine to return Expected (NFC) (PR #110718)

2024-10-01 Thread Alex Langford via lldb-commits
@@ -201,8 +201,8 @@ class SymbolContext { bool GetAddressRange(uint32_t scope, uint32_t range_idx, bool use_inline_block_range, AddressRange &range) const; - bool GetAddressRangeFromHereToEndLine(uint32_t end_line, AddressRange &range, -

[Lldb-commits] [lldb] [lldb/Interpreter] Add requirements to Scripted Interface abstract methods (PR #109063)

2024-09-19 Thread Alex Langford via lldb-commits
@@ -186,36 +210,49 @@ class ScriptedPythonInterface : virtual public ScriptedInterface { if (!checker_or_err) return checker_or_err.takeError(); +llvm::Error abstract_method_errors = llvm::Error::success(); for (const auto &method_checker : *checker_or_err)

[Lldb-commits] [lldb] [llvm] [lldb] Fix write only file action to truncate the file (PR #112657)

2024-10-25 Thread Alex Langford via lldb-commits
@@ -6,6 +6,8 @@ // //===--===// +#include bulbazord wrote: Will this work on windows? https://github.com/llvm/llvm-project/pull/112657 ___ lldb

[Lldb-commits] [lldb] [lldb] Avoid repeated hash lookups (NFC) (PR #113412)

2024-10-25 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/113412 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Re-apply [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created (PR #117079)

2024-11-20 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/117079 I backed this out due to a problem on one of the bots that myself and others have problems reproducing locally. I'd like to try to land it again, at least to gain more information. Summary: This improves the

[Lldb-commits] [lldb] [lldb] Fix regex support in SBTarget.modules_access (PR #116452)

2024-11-18 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/116452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix regex support in SBTarget.modules_access (PR #116452)

2024-11-18 Thread Alex Langford via lldb-commits
@@ -79,11 +79,11 @@ STRING_EXTENSION_LEVEL_OUTSIDE(SBTarget, lldb::eDescriptionLevelBrief) module = self.sbtarget.GetModuleAtIndex(idx) if module.uuid == key: return module -elif type(k

[Lldb-commits] [lldb] [lldb/DWARF] s/DWARFRangeList/llvm::DWARFAddressRangeVector (PR #116620)

2024-11-19 Thread Alex Langford via lldb-commits
@@ -259,22 +256,19 @@ bool DWARFDebugInfoEntry::GetDIENamesAndRanges( } } - if (ranges.IsEmpty()) { -if (lo_pc != LLDB_INVALID_ADDRESS) { - if (hi_pc != LLDB_INVALID_ADDRESS && hi_pc > lo_pc) -ranges.Append(DWARFRangeList::Entry(lo_pc, hi_pc - lo_pc));

[Lldb-commits] [lldb] [lldb/DWARF] s/DWARFRangeList/llvm::DWARFAddressRangeVector (PR #116620)

2024-11-19 Thread Alex Langford via lldb-commits
@@ -906,13 +907,18 @@ Function *SymbolFileDWARF::ParseFunction(CompileUnit &comp_unit, AddressRanges ranges; ModuleSP module_sp(die.GetModule()); - for (const auto &range : die.GetDIE()->GetAttributeAddressRanges( - die.GetCU(), /*check_hi_lo_pc=*/true)) { -

[Lldb-commits] [lldb] [lldb/API] Hoist some of SBFrame logic to lldb_private::StackFrame (NFC) (PR #116298)

2024-11-14 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/116298 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Target] Add null-check before dereferencing inlined_info (NFC) (PR #116300)

2024-11-14 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/116300 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose discontinuous functions through SBFunction::GetRanges (PR #117532)

2024-12-02 Thread Alex Langford via lldb-commits
@@ -444,8 +444,11 @@ class Function : public UserID, public SymbolContextScope { Function *CalculateSymbolContextFunction() override; + // DEPRECATED: Use GetAddressRanges instead. bulbazord wrote: Can you make this into a Doxygen comment? It will show up

[Lldb-commits] [lldb] [lldb] Expose discontinuous functions through SBFunction::GetRanges (PR #117532)

2024-12-02 Thread Alex Langford via lldb-commits
@@ -0,0 +1,182 @@ +# REQUIRES: x86 bulbazord wrote: Is there any way we can have an architecture-independent test? If it's a ton of work, I say don't worry about it, most folks are going to build the x86 target probably. https://github.com/llvm/llvm-project/pu

[Lldb-commits] [lldb] [lldb] Expose discontinuous functions through SBFunction::GetRanges (PR #117532)

2024-12-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Overall LGTM. It'd be nice if the test could be architecture independent but I understand if that's difficult or not possible right now. https://github.com/llvm/llvm-project/pull/117532 ___ lldb

[Lldb-commits] [lldb] [lldb] Expose discontinuous functions through SBFunction::GetRanges (PR #117532)

2024-12-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/117532 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Remove unused field Platform::m_remote_url (PR #118411)

2024-12-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/118411 None >From 41ce9de83da1a7131bf6c479fd0de3a57f5b8113 Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Mon, 2 Dec 2024 14:42:25 -0800 Subject: [PATCH] [lldb][NFC] Remove unused field Platform::m_remote_url -

[Lldb-commits] [lldb] [lldb][NFC] Remove unused field Platform::m_remote_url (PR #118411)

2024-12-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/118411 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add additional assertions to TestVTableValue.test_overwrite_vtable (PR #118719)

2024-12-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/118719 If this test fails, you're likely going to see something like "Assertion Error: A != B" which doesn't really give much explanation for why this failed. Instead of ignoring the error, we should assert that it

[Lldb-commits] [lldb] [lldb] Add additional assertions to TestVTableValue.test_overwrite_vtable (PR #118719)

2024-12-05 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/118719 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix links to LLVM issue tracked and pull requests (PR #118681)

2024-12-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Makes sense to me. https://github.com/llvm/llvm-project/pull/118681 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/DWARF] s/DWARFRangeList/llvm::DWARFAddressRangeVector (PR #116620)

2024-12-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Looks ok to me. Thanks! https://github.com/llvm/llvm-project/pull/116620 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Remove unused field Platform::m_remote_url (PR #118411)

2024-12-03 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/118411 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-07 Thread Alex Langford via lldb-commits
bulbazord wrote: > Rebased & fixed the existing tests. Looks like `lldb/test/API/functionalities/progress_reporting/TestTrimmedProgressReporting.py` was deleted entirely. Was this intentional? https://github.com/llvm/llvm-project/pull/121860 ___ lld

[Lldb-commits] [lldb] [lldb/Host] Add ability to open URLs on macOS (PR #125893)

2025-02-05 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/125893 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Synchronize Debugger's stdout and stderr at the StreamFile level (PR #126630)

2025-02-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/126630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Synchronize Debugger's stdout and stderr at the StreamFile level (PR #126630)

2025-02-10 Thread Alex Langford via lldb-commits
@@ -7574,7 +7574,9 @@ IOHandlerCursesGUI::IOHandlerCursesGUI(Debugger &debugger) void IOHandlerCursesGUI::Activate() { IOHandler::Activate(); if (!m_app_ap) { -m_app_ap = std::make_unique(GetInputFILE(), GetOutputFILE()); +m_app_ap = std::make_unique( --

[Lldb-commits] [lldb] [lldb] Synchronize Debugger's stdout and stderr at the StreamFile level (PR #126630)

2025-02-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: Overall looks fine, kind of terrified of the number of unguarded `fprintf` calls in Editline, but maybe it's fine? https://github.com/llvm/llvm-project/pull/126630 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [lldb] [lldb] Synchronize Debugger's stdout and stderr at the StreamFile level (PR #126630)

2025-02-10 Thread Alex Langford via lldb-commits
@@ -393,7 +394,7 @@ void Editline::MoveCursor(CursorLocation from, CursorLocation to) { int fromLine = GetLineIndexForLocation(from, editline_cursor_row); int toLine = GetLineIndexForLocation(to, editline_cursor_row); if (toLine != fromLine) { -fprintf(m_output_file,

[Lldb-commits] [lldb] [lldb] Assert on invalid default {S, U}Int64 (NFC) (PR #126590)

2025-02-10 Thread Alex Langford via lldb-commits
@@ -68,11 +68,10 @@ class OptionValueSInt64 : public Cloneable { } bool SetDefaultValue(int64_t value) { -if (value >= m_min_value && value <= m_max_value) { - m_default_value = value; - return true; -} -return false; +assert(value >= m_min_value

[Lldb-commits] [lldb] [lldb][sbapi] Namespace CommandReturnObjectCallbackResult in SBDefines (PR #126606)

2025-02-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Other types are prefixed with the lldb namespace as well, LGTM! https://github.com/llvm/llvm-project/pull/126606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [lldb] [lldb] Add a test for terminal dimensions (PR #126598)

2025-02-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/126598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a test for terminal dimensions (PR #126598)

2025-02-10 Thread Alex Langford via lldb-commits
@@ -0,0 +1,22 @@ +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test.lldbpexpect import PExpectTest + + +class TerminalDimensionsTest(PExpectTest): +NO_DEBUG_INFO_TESTCASE = True

[Lldb-commits] [lldb] [lldb] Assert on invalid default {S, U}Int64 (NFC) (PR #126590)

2025-02-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/126590 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread Alex Langford via lldb-commits
@@ -339,12 +339,9 @@ void REPL::IOHandlerInputComplete(IOHandler &io_handler, std::string &code) { const char *expr_prefix = nullptr; lldb::ValueObjectSP result_valobj_sp; + lldb::ExpressionResults execution_results = UserExpression::Evaluate( + exe_

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/117186 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix index boundaries check, Change wrong int literal (PR #117226)

2024-11-21 Thread Alex Langford via lldb-commits
@@ -3278,7 +3278,7 @@ bool AppleObjCRuntimeV2::NonPointerISACache::EvaluateNonPointerISA( } // If the index is still out of range then this isn't a pointer. - if (index > m_indexed_isa_cache.size()) + if (index >= m_indexed_isa_cache.size())

[Lldb-commits] [lldb] [lldb] Fix incorrect nullptr check in DumpAddressAndContent (PR #117219)

2024-11-21 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. makes sense https://github.com/llvm/llvm-project/pull/117219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Re-apply [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created (PR #117079)

2024-11-21 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/117079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,165 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,165 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,60 @@ +//===-- Statusline.h -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-22 Thread Alex Langford via lldb-commits
@@ -1198,13 +1207,13 @@ bool FormatEntity::Format(const Entry &entry, Stream &s, // FormatEntity::Entry::Definition encoding return false; case Entry::Type::EscapeCode: -if (exe_ctx) { - if (Target *target = exe_ctx->GetTargetPtr

[Lldb-commits] [lldb] [lldb] Make SBProgress move-only (PR #124843)

2025-01-28 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/124843 I wanted to clarify the semantics around SBProgress. Given the nature of Progress events, copying seems like the wrong idea. Making SBProgress move-only (like SBStream) seems like the better choice here. >Fr

<    10   11   12   13   14   15   16   17   >