https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/124843
I wanted to clarify the semantics around SBProgress. Given the nature of
Progress events, copying seems like the wrong idea. Making SBProgress move-only
(like SBStream) seems like the better choice here.
>From cf30e0c12ceef36dbdd65157962b699eebfe8f75 Mon Sep 17 00:00:00 2001
From: Alex Langford <alangf...@apple.com>
Date: Tue, 28 Jan 2025 13:24:32 -0800
Subject: [PATCH] [lldb] Make SBProgress move-only
I wanted to clarify the semantics around SBProgress.
Given the nature of Progress events, copying seems like the wrong idea.
Making SBProgress move-only (like SBStream) seems like the better choice
here.
---
lldb/include/lldb/API/SBProgress.h | 7 +++++++
lldb/source/API/SBProgress.cpp | 3 +++
2 files changed, 10 insertions(+)
diff --git a/lldb/include/lldb/API/SBProgress.h
b/lldb/include/lldb/API/SBProgress.h
index d2eaf0a743cb3a..d574d1d2982b96 100644
--- a/lldb/include/lldb/API/SBProgress.h
+++ b/lldb/include/lldb/API/SBProgress.h
@@ -51,6 +51,10 @@ class LLDB_API SBProgress {
SBProgress(const char *title, const char *details, uint64_t total_units,
SBDebugger &debugger);
+#ifndef SWIG
+ SBProgress(SBProgress &&rhs);
+#endif
+
~SBProgress();
void Increment(uint64_t amount, const char *description = nullptr);
@@ -59,6 +63,9 @@ class LLDB_API SBProgress {
lldb_private::Progress &ref() const;
private:
+ SBProgress(const SBProgress &rhs) = delete;
+ const SBProgress &operator=(const SBProgress &rhs) = delete;
+
std::unique_ptr<lldb_private::Progress> m_opaque_up;
}; // SBProgress
} // namespace lldb
diff --git a/lldb/source/API/SBProgress.cpp b/lldb/source/API/SBProgress.cpp
index d6ed5f0d15fc94..e67e289a60eff4 100644
--- a/lldb/source/API/SBProgress.cpp
+++ b/lldb/source/API/SBProgress.cpp
@@ -32,6 +32,9 @@ SBProgress::SBProgress(const char *title, const char *details,
lldb_private::Progress::Origin::eExternal);
}
+SBProgress::SBProgress(SBProgress &&rhs)
+ : m_opaque_up(std::move(rhs.m_opaque_up)) {}
+
SBProgress::~SBProgress() = default;
void SBProgress::Increment(uint64_t amount, const char *description) {
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
