[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-11-04 Thread Adrian Vogelsgesang via lldb-commits
@@ -910,6 +911,183 @@ void request_attach(const llvm::json::Object &request) { } } +// "BreakpointLocationsRequest": { +// "allOf": [ { "$ref": "#/definitions/Request" }, { +// "type": "object", +// "description": "The `breakpointLocations` request returns all poss

[Lldb-commits] [lldb] Fix pointer to reference type (PR #113596)

2024-11-01 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: FWIW, codelldb also dereferences pointers and references when displaying values. They [provide a user-facing setting](https://github.com/vadimcn/codelldb/blob/v1.10.0/MANUAL.md#pointers) for it and [implement it in the debug adapter](https://github.com/vadimcn/codelldb/blo

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-11-01 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/113787 >From af45bc2e24623d7225d24a4680a28630d67d636e Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Sat, 26 Oct 2024 14:34:31 + Subject: [PATCH 1/5] [lldb-dap] Support column breakpoints This commi

[Lldb-commits] [lldb] [lldb][test] Skip `LibCxxInternalsRecognizerTestCase` on clang <= 17 (PR #114122)

2024-10-30 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/114122 >From 00d136ed33cdc4362f7f23804ee184ddb1fb2539 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 29 Oct 2024 20:23:13 + Subject: [PATCH 1/2] [lldb][test] Skip `LibCxxInternalsRecognizerTestC

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-10-26 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/113787 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][lldb-dap] Clean-up includes (PR #113839)

2024-10-28 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/113839 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-10-28 Thread Adrian Vogelsgesang via lldb-commits
@@ -910,6 +911,183 @@ void request_attach(const llvm::json::Object &request) { } } +// "BreakpointLocationsRequest": { +// "allOf": [ { "$ref": "#/definitions/Request" }, { +// "type": "object", +// "description": "The `breakpointLocations` request returns all poss

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-10-28 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/113787 >From af45bc2e24623d7225d24a4680a28630d67d636e Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Sat, 26 Oct 2024 14:34:31 + Subject: [PATCH 1/3] [lldb-dap] Support column breakpoints This commi

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-10-27 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/113787 >From af45bc2e24623d7225d24a4680a28630d67d636e Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Sat, 26 Oct 2024 14:34:31 + Subject: [PATCH 1/3] [lldb-dap] Support column breakpoints This commi

[Lldb-commits] [lldb] [NFC][lldb-dap] Clean-up includes (PR #113839)

2024-10-27 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/113839 This commit cleans up the includes in the `lldb-dap` subfolder. The main motivation was that I got annoyed by `clangd` always complaining about unused includes while working on lldb-dap. >From 30f5c94795a

[Lldb-commits] [lldb] [NFC][lldb-dap] Clean-up includes (PR #113839)

2024-10-27 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/113839 >From d7dd1a1b6c6948ee04b02f4d07414d28603a2781 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Sun, 27 Oct 2024 22:02:36 + Subject: [PATCH] [NFC][lldb-dap] Clean-up includes This commit cleans

[Lldb-commits] [lldb] [lldb-dap] Refactoring JSONUtils to not use `g_dap` and instead passing in required arguments. (PR #115561)

2024-11-08 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/115561 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring JSONUtils to not use `g_dap` and instead passing in required arguments. (PR #115561)

2024-11-08 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. https://github.com/llvm/llvm-project/pull/115561 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring JSONUtils to not use `g_dap` and instead passing in required arguments. (PR #115561)

2024-11-08 Thread Adrian Vogelsgesang via lldb-commits
@@ -154,7 +154,7 @@ DecodeMemoryReference(llvm::StringRef memoryReference) { std::vector GetStrings(const llvm::json::Object *obj, llvm::StringRef key) { std::vector strs; - auto json_array = obj->getArray(key); + const auto *json_array =

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-10-26 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/113787 This commit adds support for column breakpoints to lldb-dap. To do so, support for `breakpointLocations` was added. To find all available breakpoint positions, we iterate over the line table. The `setBrea

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-10-26 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: Screen recording showing the behavior: https://github.com/user-attachments/assets/ee5129e1-b9af-44e3-acd3-c6e9bbe65a06 https://github.com/llvm/llvm-project/pull/113787 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-10-26 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/113787 >From af45bc2e24623d7225d24a4680a28630d67d636e Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Sat, 26 Oct 2024 14:34:31 + Subject: [PATCH 1/2] [lldb-dap] Support column breakpoints This commi

[Lldb-commits] [lldb] [lldb-dap] Refactor lldb-dap/DAP.{h, cpp} to use its own instance instead of the global instance. (PR #115948)

2024-11-12 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. https://github.com/llvm/llvm-project/pull/115948 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Remove `g_dap` references from lldb-dap/LLDBUtils. (PR #115933)

2024-11-12 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. https://github.com/llvm/llvm-project/pull/115933 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-10-31 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/113787 >From af45bc2e24623d7225d24a4680a28630d67d636e Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Sat, 26 Oct 2024 14:34:31 + Subject: [PATCH 1/4] [lldb-dap] Support column breakpoints This commi

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-10-31 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/113787 >From af45bc2e24623d7225d24a4680a28630d67d636e Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Sat, 26 Oct 2024 14:34:31 + Subject: [PATCH 1/5] [lldb-dap] Support column breakpoints This commi

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-11-10 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/113787 >From af45bc2e24623d7225d24a4680a28630d67d636e Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Sat, 26 Oct 2024 14:34:31 + Subject: [PATCH 1/7] [lldb-dap] Support column breakpoints This commi

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #113787)

2024-11-10 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/113787 >From af45bc2e24623d7225d24a4680a28630d67d636e Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Sat, 26 Oct 2024 14:34:31 + Subject: [PATCH 1/6] [lldb-dap] Support column breakpoints This commi

[Lldb-commits] [lldb] [lldb-dap] Refactoring JSONUtils to not use `g_dap` and instead passing in required arguments. (PR #115561)

2024-11-08 Thread Adrian Vogelsgesang via lldb-commits
@@ -1465,11 +1462,7 @@ CreateRunInTerminalReverseRequest(const llvm::json::Object &launch_request, llvm::StringRef key = envs.GetNameAtIndex(index); llvm::StringRef value = envs.GetValueAtIndex(index); -if (key.empty()) - g_dap.SendOutput(OutputType::Stderr,

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/104589 >From 79684ccb2b6312b0938de73641e89d7cd29ce1a8 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Mon, 12 Aug 2024 14:53:31 + Subject: [PATCH 1/3] [lldb-dap] Implement value locations for function

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
@@ -1198,6 +1198,26 @@ std::string VariableDescription::GetResult(llvm::StringRef context) { return description.trim().str(); } +bool HasValueLocation(lldb::SBValue v) { + if (!v.GetType().IsPointerType() && !v.GetType().IsReferenceType()) { +return false; + } ---

[Lldb-commits] [lldb] Add docs and an example use of the scripted command get_flags API. (PR #109176)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. https://github.com/llvm/llvm-project/pull/109176 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: > What I could imagine is to drive this via attributes instead of a heuristic. > We could potentially mark implementation details of libc++ as such to control > what the debugging experience is like at a much finer grain if we used > attributes, but obviously this would als

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/109219 Sometimes you only want to temporarily disable a frame recognizer instead of deleting it. In particular, when dealing with one of the builtin frame recognizers, which cannot be restored after deletion. >F

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: > We really should add a "disable" to the frame recognizers Do you mean something like #109219? (Test cases still missing; rest should be ready for review) > Seems to me like this feature should be tuned to "users of libc++" not > "developers of libc++". Agree, I think th

[Lldb-commits] [lldb] [lldb][lldb-dap] Added readMemory and WriteMemory, var type correction (PR #108036)

2024-09-17 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: > I actually wrote this for a team that already has their own viewer. We've > suggested that they upstream that as well. Is that viewer in VS-Code or in some other editor? (Trying to avoid duplicating effort, so I don't accidentally implement the same thing) https://github

[Lldb-commits] [lldb] [LLDB][lldb-dap][vscode-lldb] Add Environment configuration for the lldb-dap process (PR #108948)

2024-09-17 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: @serby2000 do you have the necessary permissions to merge this? Or does one of us need to press the button? https://github.com/llvm/llvm-project/pull/108948 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [lldb] [lldb-dap][test] Fix `readMemory` test (PR #109057)

2024-09-17 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/109057 So far, the test case was also testing the offset -1. This test cases failed if the string is immediately at the beginning of the memory region, though, and the offset -1 hence belonged to a different memo

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-09-17 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: I think there is actually an even simpler fix for this test failure... https://github.com/llvm/llvm-project/pull/109057 https://github.com/llvm/llvm-project/pull/104317 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [lldb] [lldb] Fix assert frame recognizer for Ubuntu 22.04 (PR #109594)

2024-09-22 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/109594 On Ubuntu 22.04, the top-most stack frame is the function `__pthread_kill_implementation`. Add it to the list of detected functions. ``` (lldb) bt * thread #1, name = 'a.out', stop reason = signal SIGABRT

[Lldb-commits] [lldb] [lldb] Fix assert frame recognizer for Ubuntu 22.04 (PR #109594)

2024-09-22 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109594 >From d8d611a2d6381a9ae47f49c56a43e6e17cd2559e Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Sun, 22 Sep 2024 21:12:17 + Subject: [PATCH] Fix assert frame recognizer for Ubuntu 22.04 On Ubun

[Lldb-commits] [lldb] [lldb] Fix assert frame recognizer for Ubuntu 22.04 (PR #109594)

2024-09-23 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: I just realized that this was previously mentioned in #56144. The comments on that item make me wonder if this commit here actually even uses the right approach... Should I instead extend the recognizer framework to also match on the non-topmost frame? https://github.com/l

[Lldb-commits] [lldb] [lldb] Fix assert frame recognizer for Ubuntu 22.04 (PR #109594)

2024-09-23 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: CC @labath since you aparrently already put some thoughts into this 2 years ago, when opening #56144 https://github.com/llvm/llvm-project/pull/109594 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-23 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/108870 >From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 27 Aug 2024 17:34:11 + Subject: [PATCH 1/6] [lldb][libc++] Hide all libc++ implementation det

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-23 Thread Adrian Vogelsgesang via lldb-commits
@@ -90,9 +79,26 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer { if (!sc.function) return {}; +// Check if we have a regex match +bool matches_regex = false; for (RegularExpression &r : m_hidden_regex) - if (r.Execute(sc.function->GetN

[Lldb-commits] [lldb] [lldb-dap] Simplify `readMemory` (PR #109485)

2024-09-22 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/109485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Rename `enableDisplayExtendedBacktrace` (PR #109521)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/109521 The `enable` prefix is a filler word which adds no additional information. Rename the setting to `displayExtendedBacktrace` Given that this setitng was only introduced a month ago, and that there has not

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,67 @@ +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class LibCxxInternalsRecognizerTestCase(TestBase): +NO_DEBUG_INFO_TESTCASE = True + +@add_test_categories(["libc++"]) +

[Lldb-commits] [lldb] [lldb-dap] Rename `enableDisplayExtendedBacktrace` (PR #109521)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/109521 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/108870 >From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 27 Aug 2024 17:34:11 + Subject: [PATCH 1/5] [lldb][libc++] Hide all libc++ implementation det

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/108870 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/104589 >From a7876a20b5caa53dace056c84a1b7f1e798088f0 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Mon, 12 Aug 2024 14:53:31 + Subject: [PATCH 1/4] [lldb-dap] Implement value locations for function

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/108870 >From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 27 Aug 2024 17:34:11 + Subject: [PATCH 1/3] [lldb][libc++] Hide all libc++ implementation det

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: > We really should add a "disable" to the frame recognizers Merged #109219 > I wonder if a heuristic for the callback case could be: mark all but the > first libc++ entry point as an implementation detail. Would this be even more > aggressive? Also, the implementation of t

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/108870 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-21 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/108870 >From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 27 Aug 2024 17:34:11 + Subject: [PATCH 1/4] [lldb][libc++] Hide all libc++ implementation det

[Lldb-commits] [lldb] [lldb-dap] Rename `enableDisplayExtendedBacktrace` (PR #109521)

2024-09-22 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/109521 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Simplify `readMemory` (PR #109485)

2024-09-23 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109485 >From 48718649469aae62b2945e7de22cf7280316b757 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Fri, 20 Sep 2024 21:05:54 + Subject: [PATCH 1/2] [lldb-dap] Simplify `readMemory` The `readMemory

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-23 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/108870 >From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 27 Aug 2024 17:34:11 + Subject: [PATCH 1/7] [lldb][libc++] Hide all libc++ implementation det

[Lldb-commits] [lldb] [lldb-dap] Simplify `readMemory` (PR #109485)

2024-09-23 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109485 >From f461249eed7bf26f87b156d071ad2a12ecd231ab Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Fri, 20 Sep 2024 21:05:54 + Subject: [PATCH 1/3] [lldb-dap] Simplify `readMemory` The `readMemory

[Lldb-commits] [lldb] [lldb-dap] Simplify `readMemory` (PR #109485)

2024-09-23 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: > [...] it may returned cached data from disk for running processes (which > means it will be faster, but potentially return incorrect data). I think the 2nd point shouldn't be an issue because `SBTarget::ReadMemory` sets `force_live_memory` to true when calling `Target::Re

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-23 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: @Michael137 thanks for the review! I updated the pull request accordingly https://github.com/llvm/llvm-project/pull/108870 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-23 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/108870 >From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 27 Aug 2024 17:34:11 + Subject: [PATCH 1/6] [lldb][libc++] Hide all libc++ implementation det

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-23 Thread Adrian Vogelsgesang via lldb-commits
@@ -346,6 +346,31 @@ Third-party Integrations Libc++ provides integration with a few third-party tools. +Debugging libc++ internals in LLDB +-- + +LLDB hides the implementation details of libc++ by default. + +E.g., when setting a breakpoint in

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-24 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/108870 >From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 27 Aug 2024 17:34:11 + Subject: [PATCH 1/8] [lldb][libc++] Hide all libc++ implementation det

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-23 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: @jimingham I agree with everything you wrote. I think you misunderstood the context based on the way GitHub provided you some misleadning context in the email notification, though https://github.com/llvm/llvm-project/pull/108870 _

[Lldb-commits] [lldb] [lldb] Fix assert frame recognizer for Ubuntu 22.04 (PR #109594)

2024-09-24 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: > However, with these new "hiding frame" recognizers, we are using the frame > hiding recognizers to handle "step out past hidden frames". So if - as was > done in the original implementation - we're determining this during execution > control, its hard to see how we can a

[Lldb-commits] [lldb] [lldb] Fix error reporting in SBTarget::ReadMemory (PR #109764)

2024-09-24 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. https://github.com/llvm/llvm-project/pull/109764 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-24 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/104589 >From c6962437499858643b8112bcc1c7d155d3c588a9 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Mon, 12 Aug 2024 14:53:31 + Subject: [PATCH 1/4] [lldb-dap] Implement value locations for function

[Lldb-commits] [lldb] [lldb-dap][test] Fix `readMemory` test (PR #109057)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/109057 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
@@ -1611,16 +1624,17 @@ void request_evaluate(const llvm::json::Object &request) { VariableDescription desc(value); EmplaceSafeString(body, "result", desc.GetResult(context)); EmplaceSafeString(body, "type", desc.display_type_name); - if (value.MightHave

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-18 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/104589 >From 79684ccb2b6312b0938de73641e89d7cd29ce1a8 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Mon, 12 Aug 2024 14:53:31 + Subject: [PATCH 1/2] [lldb-dap] Implement value locations for function

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109219 >From c471c2fe615082fb9f9c5f39466bd47ec5b86bb0 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 18 Sep 2024 22:34:30 + Subject: [PATCH 1/4] [lldb] Add support for disabling frame recognizer

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109219 >From c471c2fe615082fb9f9c5f39466bd47ec5b86bb0 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 18 Sep 2024 22:34:30 + Subject: [PATCH 1/5] [lldb] Add support for disabling frame recognizer

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang ready_for_review https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-19 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/109266 * Document how to procure and configure the `lldb-dap` binary * Improve documentation for `launch.json`: * Show the examples before the reference. Most new users just want to get going, and will only nee

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-19 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109266 >From 006f7cbe4aa1621b9490ae534ea6e17f56e3f6af Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Thu, 19 Sep 2024 11:45:29 +0200 Subject: [PATCH] [lldb-dap][docs] Improve README * Document how to pr

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -1 +0,0 @@ -objc vogelsgesang wrote: The intended test coverage of this test case seems to be to test the frame recognizers as indicated by the file path. Making making it run also on non-Mac platforms, we are hence gaining test coverage on other systems. T

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,95 @@ +# Adding Programming Language Support + +LLDB has been architected to make it straightforward to add support for a +programming language. Only a small enum in core LLDB needs to be modified to +make LLDB aware of a new programming language. Everything else can be

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. https://github.com/llvm/llvm-project/pull/109427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -1,77 +1,30 @@ # LLDB DAP -## `lldb-dap` Configurations +## Procuring the `lldb-dap` binary -The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a -command line tool that implements the [Debug Adapter -Protocol](https://microsoft.github.io/debug-ad

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/109266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109266 >From 006f7cbe4aa1621b9490ae534ea6e17f56e3f6af Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Thu, 19 Sep 2024 11:45:29 +0200 Subject: [PATCH 1/8] [lldb-dap][docs] Improve README * Document how t

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: I can't really say if the content is correct, but this was definitely an informative read https://github.com/llvm/llvm-project/pull/109427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -204,12 +171,67 @@ The default hostname being used `localhost`. } ``` -## Custom debugger commands +### Configuration Settings Reference + +For both launch and attach configurations, lldb-dap accepts the following `lldb-dap` +specific key/value pairs: + +|parameter

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/109266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/109266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/104589 >From a7876a20b5caa53dace056c84a1b7f1e798088f0 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Mon, 12 Aug 2024 14:53:31 + Subject: [PATCH 1/3] [lldb-dap] Implement value locations for function

[Lldb-commits] [lldb] [lldb-dap] Simplify `readMemory` (PR #109485)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/109485 The `readMemory` request used the `MemoryRegionInfo` so it could also support short reads. Since #106532, this is no longer necessary, as mentioned by @labath in a comment on #104317. We no longer set the

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: Thanks for that thoughtful write-up! #109485 should address your points > The method I'd recommend is to call `ReadMemory` I assume I should prefer `Target::ReadMemory` over `Process::readMemory`, right? https://github.com/llvm/llvm-project/pull/104317

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,95 @@ +# Adding Programming Language Support + +LLDB has been architected to make it straightforward to add support for a +programming language. Only a small enum in core LLDB needs to be modified to +make LLDB aware of a new programming language. Everything else can be

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109219 >From c471c2fe615082fb9f9c5f39466bd47ec5b86bb0 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 18 Sep 2024 22:34:30 + Subject: [PATCH 1/8] [lldb] Add support for disabling frame recognizer

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -395,6 +389,138 @@ def test_frame_recognizer_not_only_first_instruction(self): variables.GetValueAtIndex(1).GetValueType(), lldb.eValueTypeVariableArgument ) +def test_frame_recognizer_disable(self): +self.build() +exe = self.getBui

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -395,6 +389,138 @@ def test_frame_recognizer_not_only_first_instruction(self): variables.GetValueAtIndex(1).GetValueType(), lldb.eValueTypeVariableArgument ) +def test_frame_recognizer_disable(self): +self.build() +exe = self.getBui

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109266 >From 006f7cbe4aa1621b9490ae534ea6e17f56e3f6af Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Thu, 19 Sep 2024 11:45:29 +0200 Subject: [PATCH 1/2] [lldb-dap][docs] Improve README * Document how t

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/109266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -204,12 +171,67 @@ The default hostname being used `localhost`. } ``` -## Custom debugger commands +### Configuration Settings Reference + +For both launch and attach configurations, lldb-dap accepts the following `lldb-dap` +specific key/value pairs: + +|parameter

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109266 >From 006f7cbe4aa1621b9490ae534ea6e17f56e3f6af Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Thu, 19 Sep 2024 11:45:29 +0200 Subject: [PATCH 1/2] [lldb-dap][docs] Improve README * Document how t

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109219 >From c471c2fe615082fb9f9c5f39466bd47ec5b86bb0 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 18 Sep 2024 22:34:30 + Subject: [PATCH 1/3] [lldb] Add support for disabling frame recognizer

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109219 >From c471c2fe615082fb9f9c5f39466bd47ec5b86bb0 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 18 Sep 2024 22:34:30 + Subject: [PATCH 1/5] [lldb] Add support for disabling frame recognizer

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/104589 >From e5d1caec0bcbc6dd16ae878c2824daa8e6e0863a Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Mon, 12 Aug 2024 14:53:31 + Subject: [PATCH 1/3] [lldb-dap] Implement value locations for function

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: This is ready for review now. While adding the test cases, I had to migrate it from Objective-C to C, since I was unable to run it on my Linux machine otherwise https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mai

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109219 >From c471c2fe615082fb9f9c5f39466bd47ec5b86bb0 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 18 Sep 2024 22:34:30 + Subject: [PATCH 1/5] [lldb] Add support for disabling frame recognizer

<    1   2   3   4   5   6   >