vogelsgesang wrote:

> [...] it may returned cached data from disk for running processes (which 
> means it will be faster, but potentially return incorrect data).

I think the 2nd point shouldn't be an issue because `SBTarget::ReadMemory` sets 
`force_live_memory` to true when calling `Target::ReadMemory`

> [...] but I don't know how you should come to a decision there

I think I found a good criterion: Do whatever the `memory read` command is 
doing. Because users would probably expect the UI view and the results from 
`memory read` to be in-sync. It turns out `memory read` is using 
`Target::ReadMemory`. So I would like to do the same here, except if you are 
aware of good reasons not to do so

https://github.com/llvm/llvm-project/pull/109485
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to