[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

DavidSpickett created this revision. Herald added subscribers: mgrang, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is to be used when you want to know what subranges of a larger range have memory taggin

[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

DavidSpickett created this revision. Herald added a subscriber: mgorny. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The tag map holds a sparse set of memory tags and allows you to query ranges for tags. Granules that do n

[Lldb-commits] [PATCH] D107140: [lldb] Show memory tags in memory read output

DavidSpickett updated this revision to Diff 383374. DavidSpickett added a comment. Herald added a subscriber: dang. Added a command option for showing tags (off by default). Split the patch into three (see parent revisions). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett updated this revision to Diff 384385. DavidSpickett added a comment. Rebase onto latest main. Remove pointer auth from the test. This means we can run it on current buildbots more easily. There are other tests that look at pauth specifically, here we just care that the ABI plugin wa

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett updated this revision to Diff 384389. DavidSpickett added a comment. Update comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102757/new/ https://reviews.llvm.org/D102757 Files: lldb/include/lldb/Target/Process.h lldb/sourc

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett updated this revision to Diff 384393. DavidSpickett added a comment. Change ProcessDebugger to DoGetMemoryRegionInfo also, to reduce confusion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102757/new/ https://reviews.llvm.org/D102757

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f5ce43b4337: [lldb] Remove non address bits when looking up memory regions (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102757

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett added a comment. > Looks like this breaks the build on Windows Should be fixed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102757/new/ https://reviews.llvm.org/D102757 ___ lldb-comm

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett updated this revision to Diff 386108. DavidSpickett added a comment. - Set locations for all general purpose registers - Set register type to DWARF due to that - Add a new test that sets known register values and compares them between signal catch and handler - Remove changes to han

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett added a comment. I'll at least make the floating point/SVE changes children of this review since it'll add some complexity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112069/new/ https://reviews.llvm.org/D112069 _

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett added inline comments. Comment at: lldb/test/API/linux/aarch64/unwind_signal/main.c:23 + SETREG("24") SETREG("25") SETREG("26") SETREG("27") + SETREG("28") SETREG("29") SETREG("30") /* 31 is xzr/sp */ + /* clang-format on */ In my tes

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett updated this revision to Diff 386466. DavidSpickett added a comment. - Set x registers to a different pattern in the signal handler - Don't save frames before and after, just check for the right pattern when unwinding out of the handler to sigill() - Set register kind when we first

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

This revision was automatically updated to reflect the committed changes. Closed by commit rG9db2541d4c30: [lldb][AArch64] Add UnwindPlan for Linux sigreturn (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112069/new/ http

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett added a comment. Thanks for the help, really helped get a high quality fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112069/new/ https://reviews.llvm.org/D112069 ___ lldb-commits maili

[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

DavidSpickett added a comment. Thanks for looking at this bug! I admit I don't know the option parsing very well which is why I shied away from fixing it myself. Some good finds elsewhere too, but better as their own changes I think. (feel free to add me on review there too)

[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

DavidSpickett added a comment. Not sure if you're a regular contributor and already know this but in case not, I tend to use https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting for doing clang-format stuff. It'll format only the lines you've changed. Repository: rG LL

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

DavidSpickett added a comment. > qemu also does not support macOS Do you mean qemu-user here? I agree being able to run the tests there is nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114509/new/ https://reviews.llvm.org/D114509 _

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

DavidSpickett added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/gdbclientutils.py:505 except: +traceback.print_exc() return Is this something that happens every so often during testing and can be mostly igno

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

DavidSpickett added a comment. > some things in this patch are called "Qemu" (the plugin folder, for instance) I wouldn't pay much attention to the `qemu-system` idea, it was just a hypothetical from me. Unless it's something that you would call a public API. Like the platform's name for exampl

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf23b829a2635: Fixed use of -o and -k in LLDB under Windows when statically compiled with… (authored by PatriosTheGreat, committed by DavidSpickett).

[Lldb-commits] [PATCH] D114554: Fix TestFileHandle.py. Remove redundant skipIfReproducer annotation

DavidSpickett added a comment. > David, did you get any breakage emails about that commit ? I did not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114554/new/ https://reviews.llvm.org/D114554 ___ lldb

[Lldb-commits] [PATCH] D114544: [lldb] Fix 'memory write' to not allow specifying values when writing file contents

DavidSpickett added inline comments. Comment at: lldb/source/Interpreter/CommandObject.cpp:457 : OptSetFiltered(opt_set_mask, m_arguments[i]); +if (arg_entry.empty()) + continue; (like I said on the other diff) What does it mean for an arg_

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

DavidSpickett accepted this revision. DavidSpickett added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114509/new/ https://reviews.llvm.org/D114509 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D114544: [lldb] Fix 'memory write' to not allow specifying values when writing file contents

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. > All the comments etc came from that. Yeah it's a bit of a judgement call so it's a safe bet to add them and see what review thinks. I know for sure there are plenty of tests wi

[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

DavidSpickett added a comment. Thanks for splitting the patches. Comment at: lldb/source/Interpreter/OptionGroupFormat.cpp:30 + m_option_definition[2] = default_opt_defs[2]; + m_option_definition[3] = default_opt_defs[3]; You could use a std::copy for this

[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

DavidSpickett updated this revision to Diff 389988. DavidSpickett added a comment. - Range based for loop over memory regions - Reduce number of ->GetRange calls - Check for overlapping regions up front and error if founda - Added test that the range invesion check removes ignores tags - Added the

[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:148 + // For the logic to work regions must be in ascending order. + // We're going to assume that there are no o

[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:160 + // we must use an untagged address. + MemoryRegionInfo::RangeType range(RemoveNonAddressBits(addr), len); + range = ExpandToGranule(range); --

[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114448/new/ https://reviews.llvm.org/D114448 _

[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

DavidSpickett updated this revision to Diff 390073. DavidSpickett added a comment. - Move to Target/ - Doxygen style comments at top of class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112825/new/ https://reviews.llvm.org/D112825 Files: lldb/

[Lldb-commits] [PATCH] D107140: [lldb] Add option to show memory tags in memory read output

DavidSpickett updated this revision to Diff 390076. DavidSpickett added a comment. Rebase after changes to previous patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107140/new/ https://reviews.llvm.org/D107140 Files: lldb/include/lldb/Core

[Lldb-commits] [PATCH] D114796: [lldb/qemu] Add support for pty redirection

DavidSpickett added inline comments. Comment at: lldb/source/Target/Target.cpp:3324 - if (default_to_use_pty && - (!in_file_spec || !out_file_spec || !err_file_spec)) { + if (default_to_use_pty) { llvm::Error Err = info.SetUpPtyRedirection(); ---

[Lldb-commits] [PATCH] D114796: [lldb/qemu] Add support for pty redirection

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114796/new/ https://reviews.llvm.org/D114796 _

[Lldb-commits] [PATCH] D114877: [lldb] Add missing space in C string format memory read warning

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Also add tests to check that we print the warning in the right circumstances. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[Lldb-commits] [PATCH] D114877: [lldb] Add missing space in C string format memory read warning

DavidSpickett updated this revision to Diff 391013. DavidSpickett added a comment. Put the command in a string and add in the size each time since that's all that changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114877/new/ https://reviews.l

[Lldb-commits] [PATCH] D114861: Don't consider frames with different PCs as a loop

DavidSpickett added a comment. Looking at `GetOneMoreFrame` I agree the logic matches up but don't understand the logic enough overall to approve. I'll leave that to others. Comment at: lldb/source/Target/RegisterContextUnwind.cpp:697 + // theory we can have arbitrary number

[Lldb-commits] [PATCH] D114923: [lldb/plugins] Add arm64(e) support to ScriptedProcess

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_process.py:357 +{'name': 'pc', 'bitsize': 64, 'offset': 256, 'encoding': 'uint', 'format': 'hex', 'set': 0, 'g

[Lldb-commits] [PATCH] D133011: [LLDB] Make build.py use uname to set platform

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133011/new/ https://reviews.llvm.org/D133011 _

[Lldb-commits] [PATCH] D133024: [LLDB] Simplify cmake for instruction emulation unit tests

DavidSpickett created this revision. Herald added subscribers: luke957, s.egerton, simoncook, kristof.beyls, mgorny. Herald added a project: All. DavidSpickett requested review of this revision. Herald added subscribers: lldb-commits, pcwang-thead. Herald added a project: LLDB. I got suspicious be

[Lldb-commits] [PATCH] D133024: [LLDB] Simplify cmake for instruction emulation unit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGd46ea783e6fa: [LLDB] Simplify cmake for instruction emulation unit tests (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133024/ne

[Lldb-commits] [PATCH] D133680: Add support for mach-o corefile loading of a platform binary

DavidSpickett added inline comments. Comment at: lldb/include/lldb/Target/DynamicLoader.h:231 + /// Name of the binary, if available. If an empty StringRef is + /// passed here, a name will be constructed for the module. + /// Can you list what it mig

[Lldb-commits] [PATCH] D133763: WIP strawman building perf.cpp on an older kernel

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D133763 Files: lldb/source/Plugins/Process/Li

[Lldb-commits] [PATCH] D133763: WIP strawman building perf.cpp on an older kernel

DavidSpickett planned changes to this revision. DavidSpickett added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Plugins/Process/Linux/Perf.cpp:28 lldb_private::process_linux::LoadPerfTscConversionParameters() { #if LINUX_VERSION_CODE >= KER

[Lldb-commits] [PATCH] D133778: Fix LLDB build on old Linux kernels

DavidSpickett added reviewers: wallace, jj10306. DavidSpickett added a comment. Adding reviewers who know the trace feature. Seems fine at a glance for the functions that return error types already but for example `GetEffectiveDataBufferSize` check who calls it and might crash if it returns 0.

[Lldb-commits] [PATCH] D133763: WIP strawman building perf.cpp on an older kernel

DavidSpickett abandoned this revision. DavidSpickett added a comment. For https://github.com/llvm/llvm-project/issues/57594, succeeded by https://reviews.llvm.org/D133778. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133763/new/ https://reviews.l

[Lldb-commits] [PATCH] D133778: Fix LLDB build on old Linux kernels

DavidSpickett added a comment. llvm_unreachable is equivalent to __builtin_unreachable so yes it aborts with a stack trace. I misread and thought you were returning values still. Worth trying one of the trace commands in this build and see if lldb crashes or we get a nice "not supported" messag

[Lldb-commits] [PATCH] D133778: Fix LLDB build on old Linux kernels

DavidSpickett added a comment. > old Linux kernels Also, could you include the kernel versions (that you know about at least) in the commit message. For the next person who hits this and wonders if your change is what they need to include. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D134029: [LLDB] Properly return errors from "memory region --all"

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When I wrote the initial version I forgot that a region being unmapped is not an error. There are real errors th

[Lldb-commits] [PATCH] D134030: [LLDB] Fix "memory region --all" when there is no ABI plugin

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There are two conditions for the loop exit. Either we hit LLDB_INVALID_ADDRESS or the ABI tells us we are beyond

[Lldb-commits] [PATCH] D134035: [LLDB] Format lldb-server's target XML

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. So that the XML isn't one giant line. Which wasn't a problem for lldb

[Lldb-commits] [PATCH] D134039: [LLDB] Make instruction emulation context type private

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is the first step to being able to handle non trivial types in the union. info_type effects the lifetime o

[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

DavidSpickett created this revision. Herald added subscribers: atanasyan, jrtc27. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In future I want to extend RegisterInfo and that will likely be non

[Lldb-commits] [PATCH] D134043: [lldb] Log when we cannot find an equivalent for a gdb register type

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This happens if the type is described elsewhere in target xml as a or . Also hardcode the function names into

[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

DavidSpickett added reviewers: aprantl, clayborg. DavidSpickett added a comment. Note that this does not add any non trivial types but of course I did test it by adding some to RegisterInfo. This work is early parts of https://discourse.llvm.org/t/rfc-showing-register-fields-in-lldb/64676. =

[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

DavidSpickett added a comment. > As there is no LLVM variant, I would go for std::variant I was under the impression that we can use 17 language features but not library features, yet. Let me check that what the minimum toolchains have. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

DavidSpickett added a comment. Variant is supported from: libstdc++ 7.1 VS 2017 15.0 libcxx 4.0 So far so good relative to https://llvm.org/docs/GettingStarted.html#host-c-toolchain-both-compiler-and-standard-library. https://en.cppreference.com/w/cpp/compiler_support/17#C.2B.2B17_library_featu

[Lldb-commits] [PATCH] D134043: [lldb] Log when we cannot find an equivalent for a gdb register type

DavidSpickett added a comment. I didn't know about that, it's exactly what I wanted - if it worked with msvc https://godbolt.org/z/cqYf3c39n. It is used in lldb but only in tests we know will be compiled with clang (well, we assume) and some Mac OS native code which will be clang compiled. Re

[Lldb-commits] [PATCH] D134035: [LLDB] Format lldb-server's target XML

This revision was automatically updated to reflect the committed changes. Closed by commit rGba822e248d3a: [LLDB] Format lldb-server's target XML (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134035/new/ https://reviews.

[Lldb-commits] [PATCH] D134039: [LLDB] Make instruction emulation context type private

This revision was automatically updated to reflect the committed changes. Closed by commit rG01d8270a1560: [LLDB] Make instruction emulation context type private (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134039/new/

[Lldb-commits] [PATCH] D134043: [lldb] Log when we cannot find an equivalent for a gdb register type

This revision was automatically updated to reflect the committed changes. Closed by commit rGec3e290502db: [lldb] Log when we cannot find an equivalent for a gdb register type (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

DavidSpickett added a comment. > Sorry. I hoped that variant would make your life easier. Np, one can dream (until the next out of reach c++ feature comes along). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134041/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

DavidSpickett added a comment. > I think the main reason that the RegisterInfo struct is such as it is, is > because it wants to be trivially constructible (or whatever the c++ term for > that is). I'm pretty sure that adding a std::string member will make it stop > being that, and I don't thin

[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

DavidSpickett added inline comments. Comment at: lldb/include/lldb/Core/EmulateInstruction.h:196 + struct RegisterPlusOffsetStruct { RegisterInfo reg; // base register int64_t signed_offset; // signed offset added to base register laba

[Lldb-commits] [PATCH] D130534: loading a binary at a slide multiple times leaves old entries in the SectionLoadList

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Test is certainly clearer. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130534/new/ https://reviews.llvm.org/D130534 _

[Lldb-commits] [PATCH] D130534: loading a binary at a slide multiple times leaves old entries in the SectionLoadList

DavidSpickett added a comment. FWIW the intent of the change was always clear but writing a test for it is always going to be fiddly. My usual mindset is "what if this fails out of the blue", so I'm always asking for more comments :) . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D134493: [lldb][TypeSystemClang] Deduce lldb::eEncodingUint for unsigned enum types

DavidSpickett added a comment. > Wasn't sure how to properly test this since the original reproducer > technically relies on implementation-defined behaviour (i.e., initialising a > bitfield with an out-of-range value). Suggestions are welcome Is this undefined behaviour defined at least for cl

[Lldb-commits] [PATCH] D134493: [lldb][TypeSystemClang] Deduce lldb::eEncodingUint for unsigned enum types

DavidSpickett added a comment. It wouldn't need to be same across platforms either really. Can always `@skipifnotarchwhatever` and as long as it's tested somewhere that's fine. Ok clang could change its mind so we mitigate that by making sure the test would fail if it does, then update it as ne

[Lldb-commits] [PATCH] D134515: [lldb] Fix completion of 'settings set' values

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/completion/TestCompletion.py:409 +def test_settings_set_stop_disassembly_display_value(self): +"""Test that 'settins set stop-disassembly-disp

[Lldb-commits] [PATCH] D134516: [lldb] Improve display of absolute symbol lookup

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:1552 strm.IndentMore(); + strm.Indent("Name: "); + strm.PutCString(symbol->GetDisplayName().GetStringRef()

[Lldb-commits] [PATCH] D134515: [lldb] Fix completion of 'settings set' values

DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/completion/TestCompletion.py:409 +def test_settings_set_stop_disassembly_display_value(self): +"""Test that 'settins set stop-disassembly-display ' completes to [ +'never', 'always'

[Lldb-commits] [PATCH] D134516: [lldb] Improve display of absolute symbol lookup

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Commands/CommandObjectTarget.cpp:1552 strm.IndentMore(); + strm.Indent("Name: "); + strm.PutCStrin

[Lldb-commits] [PATCH] D134037: [lldb] Fix CommandInterpreter::DidProcessStopAbnormally() with multiple threads

DavidSpickett added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2443 StopInfoSP stop_info = thread_sp->GetStopInfo(); if (!stop_info) + continue; Please add a comment explaining why we walk all the threads. (though

[Lldb-commits] [PATCH] D134029: [LLDB] Properly return errors from "memory region --all"

This revision was automatically updated to reflect the committed changes. Closed by commit rGee582001bf19: [LLDB] Properly return errors from "memory region --all" (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134029/new/

[Lldb-commits] [PATCH] D134030: [LLDB] Fix "memory region --all" when there is no ABI plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rGc831cea5efaa: [LLDB] Fix "memory region --all" when there is no ABI plugin (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134030/

[Lldb-commits] [PATCH] D134037: [lldb] Fix CommandInterpreter::DidProcessStopAbnormally() with multiple threads

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/Shell/Driver/CommandOnCrashMultiThreaded.test:1 +# XFAIL: system-windows +# REQUIRES: native && (target-x86 || target-x86_64) ---

[Lldb-commits] [PATCH] D134536: [LLDB] Add an llvm::Optional version of GetRegisterInfo

DavidSpickett created this revision. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, kbarton, nemanja

[Lldb-commits] [PATCH] D134537: [LLDB] Move MIPS64/PPC64/RISCV and misc. to optional GetRegisterInfo

DavidSpickett created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, shchenz, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, shiva0

[Lldb-commits] [PATCH] D134538: [LLDB][ARM] Move instruction emulation to optional GetRegisterInfo

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Depends on D134537 Repository:

[Lldb-commits] [PATCH] D134539: [LLDB][MIPS] Move instruction emulation to optional GetRegisterInfo

DavidSpickett created this revision. Herald added subscribers: atanasyan, jrtc27, arichardson, sdardis. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Depends on D134538

[Lldb-commits] [PATCH] D134540: [LLDB][AArch64] Move instruction emulation to optional GetRegisterInfo

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Depends on D134539 Repository:

[Lldb-commits] [PATCH] D134541: [LLDB] Remove the bool + RegisterInfo& version of GetRegisterInfo

DavidSpickett created this revision. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, kbarton, nemanja

[Lldb-commits] [PATCH] D134536: [LLDB] Add an llvm::Optional version of GetRegisterInfo

DavidSpickett added a reviewer: clayborg. DavidSpickett added a subscriber: clayborg. DavidSpickett added a comment. @clayborg As promised on https://reviews.llvm.org/D134041. The strategy is: - Make the original function concrete and have it call the optional version. - Derived classes implemen

[Lldb-commits] [PATCH] D134537: [LLDB] Move MIPS64/PPC64/RISCV and misc. to optional GetRegisterInfo

DavidSpickett updated this revision to Diff 462494. DavidSpickett added a comment. Remove stray newline in riscv. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134537/new/ https://reviews.llvm.org/D134537 Files: lldb/source/Core/EmulateInstructi

[Lldb-commits] [PATCH] D134536: [LLDB] Add an llvm::Optional version of GetRegisterInfo

DavidSpickett added a comment. I appreciate this is a lot of churn for code that likely "just works" (or in reality, "isn't used very often") but with the recent riscv changes I'd like to modernise this area where possible. If this is too much at least I know to look for smaller opportunities i

[Lldb-commits] [PATCH] D134515: [lldb] Fix completion of 'settings set' values

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134515/new/ https://reviews.llvm.org/D134515

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

DavidSpickett added a comment. You're the expert on what the linker does and the code looks fine. Is it possible that msvc uses these `IMAGE_SYM_TYPE_NULL` in a different way that could cause a problem? Worst that happens is we get a bunch of symbols available in expressions that shouldn't be?

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

DavidSpickett added a comment. > MSVC/link.exe doesn't write symbols into linked PE images at all. So by the time we get to a debugger, it's not an issue anyway. Then this LGTM. Thanks for all these improvements btw, I expect Linaro's Windows on Arm efforts appreciate them too. Repository:

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Would help if I actually clicked the buttons yes :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134585/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D134536: [LLDB] Add an llvm::Optional version of GetRegisterInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e912417c67d: [LLDB] Add an llvm::Optional version of GetRegisterInfo (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134536/new/

[Lldb-commits] [PATCH] D134037: [lldb] Fix CommandInterpreter::DidProcessStopAbnormally() with multiple threads

DavidSpickett added a comment. > I might add the AArch64 and Arm equivalent if I have some spare time. I looked into this and there's a detail that makes this work on x86 only. So I'll leave it as is, it's getting tested somewhere, and that's what matters. If you're curious this is the spanner

[Lldb-commits] [PATCH] D134656: [LLDB][NativePDB] Add class/union layout bit size.

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp:53 llvm::cantFail(TypeDeserializer::deserializeAs(cvt, m_cvr.cr)); + m_layout.bit_size = m_cvr.cr.getSize() * 8; break; Drive by commen

[Lldb-commits] [PATCH] D134037: [lldb] Fix CommandInterpreter::DidProcessStopAbnormally() with multiple threads

DavidSpickett added a comment. Turns out you're not the only one https://github.com/llvm/llvm-project/issues/56268. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134037/new/ https://reviews.llvm.org/D134037 ___

[Lldb-commits] [PATCH] D134537: [LLDB] Move MIPS64/PPC64 and misc. to optional GetRegisterInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG247714f0a630: [LLDB] Move MIPS64/PPC64 and misc. to optional GetRegisterInfo (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13453

[Lldb-commits] [PATCH] D134538: [LLDB][ARM] Move instruction emulation to optional GetRegisterInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a339b3aeba7: [LLDB][ARM] Move instruction emulation to optional GetRegisterInfo (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D134539: [LLDB][MIPS] Move instruction emulation to optional GetRegisterInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rGebe71605fa89: [LLDB][MIPS] Move instruction emulation to optional GetRegisterInfo (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D134540: [LLDB][AArch64] Move instruction emulation to optional GetRegisterInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rGc87f1f5bfbf6: [LLDB][AArch64] Move instruction emulation to optional GetRegisterInfo (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D134541: [LLDB] Remove the bool + RegisterInfo& version of GetRegisterInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c1a3da8ea1f: [LLDB] Remove the bool + RegisterInfo& version of GetRegisterInfo (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[Lldb-commits] [PATCH] D134873: [LLDB] Add "process status" as equivalent of GDB's "frame" command

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is useful for answering the question "where am I?" and is surprisingly difficult to figure out without just

[Lldb-commits] [PATCH] D134873: [LLDB] Add "process status" as equivalent of GDB's "frame" command

DavidSpickett added a comment. https://lldb.llvm.org/use/map.html#examining-thread-state if you want to see the current page. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134873/new/ https://reviews.llvm.org/D134873 _

[Lldb-commits] [PATCH] D134873: [LLDB] Add "process status" as equivalent of GDB's "frame" command

DavidSpickett updated this revision to Diff 464185. DavidSpickett added a comment. - Add "frame select" and short "f" version on the lldb side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134873/new/ https://reviews.llvm.org/D134873 Files: lld

<    5   6   7   8   9   10   11   12   13   14   >