DavidSpickett added inline comments.
================
Comment at: lldb/include/lldb/Target/DynamicLoader.h:231
+ /// Name of the binary, if available. If an empty StringRef is
+ /// passed here, a name will be constructed for the module.
+ ///
----------------
Can you list what it might be constructed from? My guess:
* the filename if loading from a path
* <format>@<address> if loading from something in memory
================
Comment at: lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp:420
LLDB_LOGF(log,
- "ProcessMachCore::DoLoadCore: Using kernel corefile image "
+ "ProcessMachCore::LoadBinariesAndSetDYLD: Using kernel "
+ "corefile image "
----------------
I think the various log messages could use `__FUNCTION__` instead but hey let's
not make this diff any bigger :) .
(the one time I know you need to write out the name is inside a lambda)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133680/new/
https://reviews.llvm.org/D133680
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
