DavidSpickett added a reviewer: DavidSpickett.
DavidSpickett added inline comments.
================
Comment at: lldb/examples/python/scripted_process/scripted_process.py:357
+ {'name': 'pc', 'bitsize': 64, 'offset': 256,
'encoding': 'uint', 'format': 'hex', 'set': 0, 'gcc': 32, 'dwarf': 32,
'generic': 'pc', 'alt-name': 'pc', },
+ {'name': 'cpsr', 'bitsize': 32, 'offset': 264,
'encoding': 'uint', 'format': 'hex', 'set': 0, 'gcc': 33, 'dwarf': 33, },
+ ]
----------------
You can drop the trailing comma `, },` inside the `}` on each entry.
================
Comment at: lldb/examples/python/scripted_process/scripted_process.py:359
+ ]
return self.register_info
----------------
Is it worth putting an `else: raise Unknown architecture <bla>` here? I assume
the tests would fail later anyway and you're running this for Apple platforms
that are x86/arm64 only.
Would this ever be run against Arm 32 bit?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114923/new/
https://reviews.llvm.org/D114923
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
