DavidSpickett added inline comments.
================
Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2443
StopInfoSP stop_info = thread_sp->GetStopInfo();
if (!stop_info)
+ continue;
----------------
Please add a comment explaining why we walk all the threads.
(though in hindsight it does seem the obvious thing to do)
================
Comment at: lldb/test/Shell/Driver/CommandOnCrashMultiThreaded.test:1
+# XFAIL: system-windows
+# REQUIRES: native && (target-x86 || target-x86_64)
----------------
Isn't this fixing an issue that you saw on Windows as well?
================
Comment at: lldb/test/Shell/Driver/Inputs/CommandOnCrashMultiThreaded.cpp:5
+ asm volatile(
+ "int3\n\t"
+ );
----------------
This is an x86 breakpoint, right? Shame there is no `__builtin_break` (well,
msvc has one apparently but no help for this).
I might add the AArch64 and Arm equivalent if I have some spare time.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134037/new/
https://reviews.llvm.org/D134037
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
