https://github.com/dzhidzhoev approved this pull request.
https://github.com/llvm/llvm-project/pull/125156
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kper wrote:
> Only those with [write
> access](https://docs.github.com/articles/what-are-the-different-access-permissions)
> to this repository can merge pull requests.
@JDevlieghere Thank you, I think that one of you needs to merge it. Next to
this message is also a "Update branch" button bu
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/123521
>From 468f73f8539dcb8addf8ed9618d9eb797dabbb01 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Sun, 19 Jan 2025 09:15:34 -0800
Subject: [PATCH 1/4] [LLDB] Add Lexer (with tests) for DIL (Data Inspection
Langu
cmtice wrote:
I think I have addressed/fixed all the latest review comments. Please take
another look now.
https://github.com/llvm/llvm-project/pull/123521
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125125
>From 24ddc550e3ee61b863cbaea05ff49981bc20f7ad Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 30 Jan 2025 14:25:16 -0800
Subject: [PATCH 1/3] [lldb] Use llvm::Error instead of CommandReturnObje
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 55e22921d0b1b5088540ffa29a6e67a7816949cf Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/3] Only include title on the first message
---
lldb/include/l
@@ -411,6 +412,30 @@ void SendStdOutStdErr(DAP &dap, lldb::SBProcess &process) {
dap.SendOutput(OutputType::Stderr, llvm::StringRef(buffer, count));
}
+static std::string GetStringFromStructuredData(lldb::SBStructuredData &data,
Jlalond wrote:
@JDevlieghe
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/105594
>From 56ca564185bdceea25162a1ce3b1e8c8fa2641e2 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Fri, 19 Jul 2024 17:26:13 -0700
Subject: [PATCH 1/9] [lldb] Change lldb's breakpoint handling behavior
(#96
JDevlieghere wrote:
@kper Please let us know if you need one of us to press the merge button for
you.
https://github.com/llvm/llvm-project/pull/124758
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
I just noticed with these changes lldb-dap was using 200% of my CPU and root
causing the issue it seems that lldb_private::Pipe::Read() (without a timeout)
is using a timeout of `std::chrono::microseconds::ze
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/125132
None
>From 24ddc550e3ee61b863cbaea05ff49981bc20f7ad Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 30 Jan 2025 14:25:16 -0800
Subject: [PATCH 1/4] [lldb] Use llvm::Error instead of CommandRetu
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/125136
I just noticed with these changes lldb-dap was using 200% of my CPU and root
causing the issue it seems that lldb_private::Pipe::Read() (without a timeout)
is using a timeout of `std::chrono::microseconds::zero(
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/125156
A previous change is triggering a failure due to SOCKET not being defined in
IOStream.h. Adjusting the Windows includes to correct the imports and using a
more narrow import (winsock2.h vs windows.h).
Also remo
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/125156
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
A previous change is triggering a failure due to SOCKET not being defined in
IOStream.h. Adjusting the Windows includes to correct the imports and using a
more narrow import (winsock2.h vs windows.h).
Also r
vvereschaka wrote:
@ashgti ,
these changes break the windows build with the following errors:
```
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\tools\lldb-dap\IOStream.h(41):
error C2061: syntax error: identifier 'SOCKET'
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\t
slydiman wrote:
Note that this error occurred on Windows host building
`tools/lldb/tools/lldb-dap/CMakeFiles/lldb-dap.dir/OutputRedirector.cpp` using
MSVC.
https://github.com/llvm/llvm-project/pull/125136
___
lldb-commits mailing list
lldb-commits@li
ashgti wrote:
#125156 should fix this
https://github.com/llvm/llvm-project/pull/125136
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Matthew Bastien
Date: 2025-01-30T12:18:55-08:00
New Revision: 0d46657cb6bf04430ff8222e1974e49441767d47
URL:
https://github.com/llvm/llvm-project/commit/0d46657cb6bf04430ff8222e1974e49441767d47
DIFF:
https://github.com/llvm/llvm-project/commit/0d46657cb6bf04430ff8222e1974e49441767d47.dif
github-actions[bot] wrote:
@matthewbastien Congratulations on having your first Pull Request (PR) merged
into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/124986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 62f6d637c015a6fcf6e493e25e91f5d833da999f
a0ba821cf6f0a20e3cdc8de196b27fb85e0399d1 --e
jimingham wrote:
There were a bunch of review comments that need to be addressed. But I also am
a bit nervous about adding a feature that is intended to be a general "lldb
interesting classes lifecycle notification" but when designed only supports
Debugger Lifecycle Events. Those are the sim
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125125
>From 24ddc550e3ee61b863cbaea05ff49981bc20f7ad Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 30 Jan 2025 14:25:16 -0800
Subject: [PATCH 1/2] [lldb] Use llvm::Error instead of CommandReturnObje
Author: Augusto Noronha
Date: 2025-01-30T14:29:16-08:00
New Revision: 6a05beeb2bed366f7e6e0056a758c6f8d385fdde
URL:
https://github.com/llvm/llvm-project/commit/6a05beeb2bed366f7e6e0056a758c6f8d385fdde
DIFF:
https://github.com/llvm/llvm-project/commit/6a05beeb2bed366f7e6e0056a758c6f8d385fdde.dif
Author: John Harrison
Date: 2025-01-30T16:35:15-08:00
New Revision: adb9ef035552d7fc42a34560677f89f4f6421295
URL:
https://github.com/llvm/llvm-project/commit/adb9ef035552d7fc42a34560677f89f4f6421295
DIFF:
https://github.com/llvm/llvm-project/commit/adb9ef035552d7fc42a34560677f89f4f6421295.diff
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Augusto Noronha (augusto2112)
Changes
…uffer
ValueObjectDynamicValue::UpdateValue() assumes that the dynamic type found by
GetDynamicTypeAndAddress() would return an address in the inferior. This
commit makes it so it can deal with being
@@ -411,6 +412,30 @@ void SendStdOutStdErr(DAP &dap, lldb::SBProcess &process) {
dap.SendOutput(OutputType::Stderr, llvm::StringRef(buffer, count));
}
+static std::string GetStringFromStructuredData(lldb::SBStructuredData &data,
+
ZequanWu wrote:
Is there any update on this PR? I'm interested in working on a similar callback
that can be triggered when target is created, but I want to wait for this one
to get landed first as they will share some common code.
https://github.com/llvm/llvm-project/pull/111206
__
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/125136
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
I worry a bit about the fact that in the host case, GetValueAsData is going to
end up calling:
memcpy(dst, reinterpret_cast(address), byte_size);
where address is the host data buffer and byte_size is the size of the new
dynamic type. But in the case where the Value ha
https://github.com/kuilpd updated
https://github.com/llvm/llvm-project/pull/115005
>From 4d797371598960baf7729d05590aa1a8c7077694 Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Mon, 4 Nov 2024 14:33:45 +0500
Subject: [PATCH 01/10] [lldb] Analyze enum promotion type during parsing
---
clang/
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
tmatheson-arm wrote:
I've just noticed 2/3 of these are redundant now since the existing neon
functions have been removed. I'll remove them.
https://github.com/llvm/llvm-project/pull/125063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
JDevlieghere wrote:
> It's not clear from the patch description whether you actually need the
> ability to suppress the command output, or if you just want the ability to
> "access" the diagnostics. Because, if its the latter, then perhaps an (async)
> event would be a slightly more lightweigh
DavidSpickett wrote:
The easy one to fix is:
```
Traceback (most recent call last):
File
"C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\functionalities\reverse-execution\TestReverseContinueNotSupported.py",
line 25, in test_reverse_continue_not_supported
self
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/125091
Reverts llvm/llvm-project#123945
Has failed on the Windows on Arm buildbot:
https://lab.llvm.org/buildbot/#/builders/141/builds/5865
```
Unresolved Tests (2):
lldb-api ::
functiona
Author: David Spickett
Date: 2025-01-30T16:45:36Z
New Revision: a774de807e56c1147d4630bfec3110c11d41776e
URL:
https://github.com/llvm/llvm-project/commit/a774de807e56c1147d4630bfec3110c11d41776e
DIFF:
https://github.com/llvm/llvm-project/commit/a774de807e56c1147d4630bfec3110c11d41776e.diff
LOG
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Reverts llvm/llvm-project#123945
Has failed on the Windows on Arm buildbot:
https://lab.llvm.org/buildbot/#/builders/141/builds/5865
```
Unresolved Tests (2):
lldb-api ::
funct
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/125091
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Arm and AArch64 Linux were fine (aside from a flaky test on the latter).
Windows on Arm is complaining, I'm investigating.
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: Michael Buch
Date: 2025-01-30T15:09:53Z
New Revision: 38cb69373eef033c219efc7aaa11b84d9b307e69
URL:
https://github.com/llvm/llvm-project/commit/38cb69373eef033c219efc7aaa11b84d9b307e69
DIFF:
https://github.com/llvm/llvm-project/commit/38cb69373eef033c219efc7aaa11b84d9b307e69.diff
LOG:
@@ -575,6 +575,10 @@ Changes to LLDB
24 int main() {
Likely cause: f->b->d accessed 0x4
```
+* LLDB now supports hardware watchpoints for AArch64 Windows targets. Windows
+ does not provide API to query the number of supported hardware watchpoints.
+ Therefore curr
omjavaid wrote:
> This is a problem with watchpoints too, right?
Yes this happens with watchpoints too on both AArch64 and x64 WIndows.
> I can see an argument that says code breakpoints are much more likely to be
> placed before the initial stop, so watchpoints are still useful even with
> t
@@ -575,6 +575,10 @@ Changes to LLDB
24 int main() {
Likely cause: f->b->d accessed 0x4
```
+* LLDB now supports hardware watchpoints for AArch64 Windows targets. Windows
+ does not provide API to query the number of supported hardware watchpoints.
+ Therefore curr
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/125053
>From 310d7d6362a2f36503a9d8f94713fdb16c3bf65c Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 30 Jan 2025 12:04:59 +
Subject: [PATCH 1/3] [lldb][test] Add test for detecting CV-quals of explicit
puremourning wrote:
Hmm seems the behaviour on intel differs to arm. will need to think about it.
https://github.com/llvm/llvm-project/pull/124847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125006
>From fdac9c0292cef848b880904cf84b2c0083065005 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 28 Jan 2025 15:43:31 -0800
Subject: [PATCH 1/5] [lldb] Fix CommandInterpreter formatting (NFC)
---
@@ -743,3 +743,41 @@ void SBCommand::SetFlags(uint32_t flags) {
if (IsValid())
m_opaque_sp->GetFlags().Set(flags);
}
+
+namespace lldb_private {
+struct CommandCallbackData {
+ SBCommandPrintCallback callback;
+ void *callback_baton;
+};
+
+class CommandPrintCallbackBat
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b68b4f64a2bd2e0a22375cf89a4d655fc3667e11
310d7d6362a2f36503a9d8f94713fdb16c3bf65c --e
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/125053
>From 310d7d6362a2f36503a9d8f94713fdb16c3bf65c Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 30 Jan 2025 12:04:59 +
Subject: [PATCH 1/2] [lldb][test] Add test for detecting CV-quals of explicit
@@ -0,0 +1,22 @@
+// XFAIL: *
+
+// Tests that we correctly deduce the CV-quals and storage
+// class of explicit object member functions.
+//
+// RUN: %clangxx_host %s -g -std=c++23 -c -o %t
labath wrote:
I *think* you need -gdwarf to produce dwarf on windows. B
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/125053
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,36 @@
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+from lldbsuite.test.gdbclientutils import *
+from lldbsuite.test.lldbgdbclient import GDBRemoteTestBase
+
+
+class TestReadMemory(GDBRemoteTestBase):
+def test_x_with
@@ -0,0 +1,36 @@
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+from lldbsuite.test.gdbclientutils import *
+from lldbsuite.test.lldbgdbclient import GDBRemoteTestBase
+
+
+class TestReadMemory(GDBRemoteTestBase):
+def test_x_with
Author: Michael Buch
Date: 2025-01-30T12:50:57Z
New Revision: 4b57236bace610d3b05dbba0e9f5b11ed3a9fbee
URL:
https://github.com/llvm/llvm-project/commit/4b57236bace610d3b05dbba0e9f5b11ed3a9fbee
DIFF:
https://github.com/llvm/llvm-project/commit/4b57236bace610d3b05dbba0e9f5b11ed3a9fbee.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/125053
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/124733
>From bf011ccc02c0122e7dfd74e089143eb833c1686e Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 28 Jan 2025 12:27:46 +0100
Subject: [PATCH 1/2] [lldb] Add support for gdb-style 'x' packet
DO NOT SUBMIT unt
DavidSpickett wrote:
Also thanks for tackling this, I know I said once (possibly twice) that I'd do
it but kept getting distracted. I know you put a bunch of research time into
this too.
https://github.com/llvm/llvm-project/pull/108072
___
lldb-commi
https://github.com/DavidSpickett approved this pull request.
We're hitting limitations in Windows itself, and 1 watchpoint is more useful
than zero, so this LGTM.
To preempt a potential discussion: I think this should not be backported to 20.
Unless you've got a very good reason for it. We don
Author: David Spickett
Date: 2025-01-30T14:03:01Z
New Revision: 0caba6c8dc2f6f0da61f30c169f59d40591cddbc
URL:
https://github.com/llvm/llvm-project/commit/0caba6c8dc2f6f0da61f30c169f59d40591cddbc
DIFF:
https://github.com/llvm/llvm-project/commit/0caba6c8dc2f6f0da61f30c169f59d40591cddbc.diff
LOG
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
My inbox is ready :)
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> In most cases user sets breakpoint on main and then set watchpoints which
> masks this problem altogether.
Agreed, this isn't ideal but it is an improvement from the current features.
https://github.com/llvm/llvm-project/pull/108072
__
@@ -0,0 +1,36 @@
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+from lldbsuite.test.gdbclientutils import *
+from lldbsuite.test.lldbgdbclient import GDBRemoteTestBase
+
+
+class TestReadMemory(GDBRemoteTestBase):
+def test_x_with
https://github.com/DavidSpickett approved this pull request.
LGTM, thanks for handling this.
Maybe the final say goes to @rocallahan since `rr` is the origin of the issue?
We have to wait on GDB for a bit anyway I expect.
https://github.com/llvm/llvm-project/pull/124733
___
DavidSpickett wrote:
I want to be 100% sure of the status of this issue:
> Initial Stop Behavior: Hardware breakpoints or watchpoints set on the initial
> stop do not trigger, even though they are correctly written to the Windows
> context. They only trigger if set after the main program has s
@@ -1007,29 +1009,29 @@ class CommandObjectThreadUntil : public
CommandObjectParsed {
addr_t address =
line_entry.range.GetBaseAddress().GetLoadAddress(target);
if (address != LLDB_INVALID_ADDRESS) {
- if (fun_addr_range.Con
puremourning wrote:
> This looks good to me, thanks for fixing this. This method used to take two
> bools, `read`, and `write`, I redefined the second to `modified` when I
> changed the default watchpoints to be modify-style. The method previously had
> a block doing
>
> ```
> -uint32_t w
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/123622
>From 0a80b7a54b49de65758ab48acdb6d92f9b674d71 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 20 Jan 2025 15:03:14 +0100
Subject: [PATCH 1/4] [lldb] Fix "in function" detection in "thread until"
The impl
puremourning wrote:
OK so the test is failing on CI, that's bad news.
will check
```
FAIL: LLDB
(/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-j6q2n-1/llvm-project/github-pull-requests/build/bin/clang-x86_64)
:: test_read_watchpoint_watch_address
(TestWatchpointRead.SetReadOnlyWatchpoin
@@ -970,19 +969,21 @@ class CommandObjectThreadUntil : public
CommandObjectParsed {
return;
}
-AddressRange fun_addr_range = sc.function->GetAddressRange();
-Address fun_start_addr = fun_addr_range.GetBaseAddress();
-line_table->FindL
labath wrote:
> @labath does this pass on x86-via-Rosetta Mac? Should we retry merging with
> this change?
Yes, it passes on Rosetta. I think we're ready for another try :)
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing lis
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/123622
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/125053
This is XFAILed for now until we find a good way to locate the
DW_AT_object_pointer of function declarations (a possible solution being
https://github.com/llvm/llvm-project/pull/124790).
Made it a shell tes
@@ -0,0 +1,22 @@
+// XFAIL: *
+
+// Tests that we correctly deduce the CV-quals and storage
+// class of explicit object member functions.
+//
+// RUN: %clangxx_host %s -g -std=c++23 -c -o %t
+// RUN: %lldb %t -b -o "type lookup Foo" 2>&1 | FileCheck %s
+//
+// CHECK: (lldb)
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This is XFAILed for now until we find a good way to locate the
DW_AT_object_pointer of function declarations (a possible solution being
https://github.com/llvm/llvm-project/pull/124790).
Made it a shell t
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/125006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -743,3 +743,41 @@ void SBCommand::SetFlags(uint32_t flags) {
if (IsValid())
m_opaque_sp->GetFlags().Set(flags);
}
+
+namespace lldb_private {
+struct CommandCallbackData {
+ SBCommandPrintCallback callback;
+ void *callback_baton;
+};
+
+class CommandPrintCallbackBat
@@ -0,0 +1,66 @@
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class BreakpointAPITestCase(TestBase):
+NO_DEBUG_INFO_TESTCASE = True
+
+def run_command_interpreter_with_output_file(sel
https://github.com/labath commented:
It's not clear from the patch description whether you actually need the ability
to suppress the command output, or if you just want the ability to "access" the
diagnostics. Because, if its the latter, then perhaps an (async) event would be
a slightly more l
labath wrote:
Done.
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/puremourning updated
https://github.com/llvm/llvm-project/pull/124847
>From 169a8d84d4af08218227058db4968bed9fc701eb Mon Sep 17 00:00:00 2001
From: Ben Jackson
Date: Tue, 28 Jan 2025 21:47:24 +
Subject: [PATCH] LLDB: WatchAddress ignores modify option
The WatchAddress AP
labath wrote:
GDB has already implemented this, and it looks like they'll do a new release
this weekend: https://sourceware.org/pipermail/gdb/2025-January/051731.html
Robert, any last words before I merge this? :)
https://github.com/llvm/llvm-project/pull/124733
___
https://github.com/tmatheson-arm created
https://github.com/llvm/llvm-project/pull/125063
- Rename AArch64SVEACLETypes.def to AArch64Types.def
- Remove string literals from the macro calls
- Rename macros so that the hierarchy makes sense
>From 63159e8e82b56850213fb0e2479bd708f008ea81 Mon Sep
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Tomas Matheson (tmatheson-arm)
Changes
- Rename AArch64SVEACLETypes.def to AArch64Types.def
- Remove string literals from the macro calls
- Rename macros so that the hierarchy makes sense
---
Patch is 47.44 KiB, truncated to 20.00 KiB bel
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Tomas Matheson (tmatheson-arm)
Changes
- Rename AArch64SVEACLETypes.def to AArch64Types.def
- Remove string literals from the macro calls
- Rename macros so that the hierarchy makes sense
---
Patch is 47.44 KiB, truncated to 20.0
https://github.com/tmatheson-arm edited
https://github.com/llvm/llvm-project/pull/125063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rocallahan wrote:
It sounds fine. rr HEAD uses the Gdb flavour for GDB and the old-LLDB flavor
for LLDB. After a decent amount of time has passed I will update to the new
regime.
https://github.com/llvm/llvm-project/pull/124733
___
lldb-commits maili
rocallahan wrote:
And thanks!
https://github.com/llvm/llvm-project/pull/124733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
> > If this result printing callback was also passed the command string (which
> > it has from just above where the callback is called) then this would also
> > be an easy way to do logging of command execution. That's not needed for
> > your current purpose, but would add ano
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/124971
>From c6a1cd5115894b9f075229e878796c8b343ecde9 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Wed, 29 Jan 2025 10:53:23 -0800
Subject: [PATCH] [NFC][lldb] Document a few ivars on the value object syste
augusto2112 wrote:
Re-requesting review as I added more comments.
https://github.com/llvm/llvm-project/pull/124971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -148,6 +150,32 @@ class Value {
static ValueType GetValueTypeFromAddressType(AddressType address_type);
protected:
+ /// Represents a value, which can be a scalar, a load address, a file
address,
+ /// or a host address.
+ ///
+ /// The interpretation of `m_value` de
@@ -148,6 +150,32 @@ class Value {
static ValueType GetValueTypeFromAddressType(AddressType address_type);
protected:
+ /// Represents a value, which can be a scalar, a load address, a file
address,
+ /// or a host address.
+ ///
+ /// The interpretation of `m_value` de
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/124971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/124971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGMT with some formatting nits.
https://github.com/llvm/llvm-project/pull/124971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
Michael137 wrote:
I do th
1 - 100 of 140 matches
Mail list logo
