puremourning wrote: > This looks good to me, thanks for fixing this. This method used to take two > bools, `read`, and `write`, I redefined the second to `modified` when I > changed the default watchpoints to be modify-style. The method previously had > a block doing > > ``` > - uint32_t watch_type = 0; > - if (read) > - watch_type |= LLDB_WATCH_TYPE_READ; > - if (write) > - watch_type |= LLDB_WATCH_TYPE_WRITE; > ``` > > and in rewriting this to set an SBWatchpointOptions object, I didn't update > it correctly to allow someone to request a read-only watchpoint. The test > cases look good, thanks for taking the time to write those. I'd address the > nit Jonas pointed out.
Thanks, yeah I figured. Nit squashed. https://github.com/llvm/llvm-project/pull/124847 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
