================
@@ -148,6 +150,32 @@ class Value {
static ValueType GetValueTypeFromAddressType(AddressType address_type);
protected:
+ /// Represents a value, which can be a scalar, a load address, a file
address,
+ /// or a host address.
+ ///
+ /// The interpretation of `m_value` depends on `m_value_type`:
+ /// - Scalar: `m_value` contains the scalar value.
+ /// - Load Address: `m_value` contains the load address.
+ /// - File Address: `m_value` contains the file address.
+ /// - Host Address: `m_value` contains a pointer to the start of the buffer
in
+ /// host memory.
+ /// Currently, this can point to either:
+ /// - The `m_data_buffer` of this Value instance (e.g., in DWARF
+ /// computations).
+ /// - The `m_data` of a Value Object containing this Value.
+ // TODO: the GetScalar() API relies on knowledge not codified by the type
+ // system, making it hard to understand and easy to misuse.
+ // - Separate the scalar from the variable that contains the address (be it a
+ // load, file or host address).
+ // - Rename GetScalar() to something more indicative to what the scalar is,
+ // like GetScalarOrAddress() for example.
+ // - Split GetScalar() into two functions, GetScalar() and GetAddress(),
which
+ // verify (or assert) what m_value_type is to make sure users of the class
are
+ // querying the right thing.
----------------
JDevlieghere wrote:
```suggestion
// - Separate the scalar from the variable that contains the address (be it a
// load, file or host address).
// - Rename GetScalar() to something more indicative to what the scalar is,
// like GetScalarOrAddress() for example.
// - Split GetScalar() into two functions, GetScalar() and GetAddress(), which
// verify (or assert) what m_value_type is to make sure users of the class
are
// querying the right thing.
```
https://github.com/llvm/llvm-project/pull/124971
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
