[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat added a comment. Thanks Greg, Can you or someone please take this commit to main branch since I don't have a commit permission? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 ___ ll

[Lldb-commits] [lldb] 13e1cf8 - Reland "[lldb] Add --all option to "memory region""

Author: David Spickett Date: 2022-05-19T13:16:36+01:00 New Revision: 13e1cf806567bc4987817e14a774198c3e3f2709 URL: https://github.com/llvm/llvm-project/commit/13e1cf806567bc4987817e14a774198c3e3f2709 DIFF: https://github.com/llvm/llvm-project/commit/13e1cf806567bc4987817e14a774198c3e3f2709.diff

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

DavidSpickett added a comment. Relanded in https://reviews.llvm.org/rG13e1cf806567bc4987817e14a774198c3e3f2709. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111791/new/ https://reviews.llvm.org/D111791

[Lldb-commits] [PATCH] D125090: [lldb] Add --show-tags option to "memory find"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG068f14f1e4ec: [lldb] Add --show-tags option to "memory find" (authored by DavidSpickett). Changed prior to commit: https://reviews.llvm.org/D12509

[Lldb-commits] [lldb] 068f14f - [lldb] Add --show-tags option to "memory find"

Author: David Spickett Date: 2022-05-19T14:40:01+01:00 New Revision: 068f14f1e4ec69d218df544487f9420f2b3ab29b URL: https://github.com/llvm/llvm-project/commit/068f14f1e4ec69d218df544487f9420f2b3ab29b DIFF: https://github.com/llvm/llvm-project/commit/068f14f1e4ec69d218df544487f9420f2b3ab29b.diff

[Lldb-commits] [PATCH] D125503: [trace][intelpt] Support system-wide tracing [7] - Create a base IntelPTProcessTrace class

jj10306 requested changes to this revision. jj10306 added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Process/Linux/IntelPTCollector.h:73 + /// The target process. NativeProcessProtocol &m_process; /// Threads traced due

[Lldb-commits] [PATCH] D125850: [trace][intelpt] Support system-wide tracing [8] - Improve the single buffer perf_event configuration

jj10306 requested changes to this revision. jj10306 added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Process/Linux/IntelPTSingleBufferTrace.cpp:186 attr.exclude_kernel = 1; - attr.sample_type = PERF_SAMPLE_TIME; - attr.sam

[Lldb-commits] [PATCH] D125897: [trace][intelpt] Support system-wide tracing [9] - Collect and return context switch traces

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. Submitting my comments so far, will continue my review in a bit Comment at: lldb/include/lldb/Utility/TraceIntelPTGDBRemotePackets.h:26-28 static const char *k

[Lldb-commits] [PATCH] D125995: [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer

JDevlieghere created this revision. JDevlieghere added reviewers: mib, aprantl. Herald added a project: All. JDevlieghere requested review of this revision. Herald added a project: LLDB. A deployment target that's less than 10.13.4 causes an error saying that 'ptsname_r' is only available on mac

[Lldb-commits] [PATCH] D125995: [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125995/new/ https://reviews.llvm.org/D125995 ___ lldb-

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw updated this revision to Diff 430781. hawkinsw added a comment. Stupidly missed a few of the places where bare assertions were used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731 Files: lldb/

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw marked 2 inline comments as done. hawkinsw added a comment. @JDevlieghere So sorry! I cannot believe I missed those. Thanks for putting up with me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731

[Lldb-commits] [PATCH] D126013: Add [opt] suffix to optimized stack frame in lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. To help user identify optimized code T

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, aadsm. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes an issue t

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. A little background: we have people that end up debugging optimized code and when a variable's SBValue had an error, we wouldn't show anything in the variables window for the value. Repo

[Lldb-commits] [PATCH] D126013: Add [opt] suffix to optimized stack frame in lldb-vscode

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:754-755 object.try_emplace("id", frame_id); - EmplaceSafeString(object, "name", frame.GetFunctionName()

[Lldb-commits] [PATCH] D126013: Add [opt] suffix to optimized stack frame in lldb-vscode

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:754-755 object.try_emplace("id", frame_id); - EmplaceSafeString(object, "name", frame.GetFunctionName()); + bool is_optimized = + frame.GetFunction().IsValid() && frame.GetFunction().GetIsO

[Lldb-commits] [PATCH] D126021: [lldb/test] Fix PExpect.launch issue when disabling color support

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. This patch should fix a bug in PExpect.launch that happened when color support is not enabled. In that case, we need to add the `--no-use-c

[Lldb-commits] [lldb] 027499a - [lldb/test] Fix PExpect.launch issue when disabling color support

Author: Med Ismail Bennani Date: 2022-05-19T14:47:04-07:00 New Revision: 027499a82434ea7a784b2e5a0227540f00fbc307 URL: https://github.com/llvm/llvm-project/commit/027499a82434ea7a784b2e5a0227540f00fbc307 DIFF: https://github.com/llvm/llvm-project/commit/027499a82434ea7a784b2e5a0227540f00fbc307.

[Lldb-commits] [PATCH] D126021: [lldb/test] Fix PExpect.launch issue when disabling color support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG027499a82434: [lldb/test] Fix PExpect.launch issue when disabling color support (authored by mib). Herald added a subscriber: lldb-commits. Reposito

[Lldb-commits] [PATCH] D125897: [trace][intelpt] Support system-wide tracing [9] - Collect and return context switch traces

jj10306 added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTMultiCoreTrace.cpp:122-129 void IntelPTMultiCoreTrace::ForEachCore( std::function callback) { for (auto &it : m_traces_per_core) -callback(it.first, *it.second); +callbac

[Lldb-commits] [lldb] ea48640 - [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer

Author: Jonas Devlieghere Date: 2022-05-19T21:39:52-07:00 New Revision: ea4864007c72bfe1523013e28ceae4e391b66afc URL: https://github.com/llvm/llvm-project/commit/ea4864007c72bfe1523013e28ceae4e391b66afc DIFF: https://github.com/llvm/llvm-project/commit/ea4864007c72bfe1523013e28ceae4e391b66afc.d

[Lldb-commits] [PATCH] D125995: [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer

This revision was automatically updated to reflect the committed changes. Closed by commit rGea4864007c72: [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[Lldb-commits] [lldb] b9a30b6 - [lldb] Update test_software_breakpoint_set_and_remove_work for AS

Author: Jonas Devlieghere Date: 2022-05-19T21:40:20-07:00 New Revision: b9a30b69d814971de5bd90a134b17b5954a8a2b4 URL: https://github.com/llvm/llvm-project/commit/b9a30b69d814971de5bd90a134b17b5954a8a2b4 DIFF: https://github.com/llvm/llvm-project/commit/b9a30b69d814971de5bd90a134b17b5954a8a2b4.d