clayborg added inline comments.

================
Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:754-755
   object.try_emplace("id", frame_id);
-  EmplaceSafeString(object, "name", frame.GetFunctionName());
+  bool is_optimized =
+      frame.GetFunction().IsValid() && frame.GetFunction().GetIsOptimized();
+  if (is_optimized) {
----------------
clayborg wrote:
> No need to test if the function is valid, the SBFunction::IsValid() does this 
> already for us and will return false if it isn't valid.
I meant to say "the SBFunction::GetIsOptimized()" does this already and will 
return false if it isn't valid


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126013/new/

https://reviews.llvm.org/D126013

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to