Author: Med Ismail Bennani Date: 2022-05-19T14:47:04-07:00 New Revision: 027499a82434ea7a784b2e5a0227540f00fbc307
URL: https://github.com/llvm/llvm-project/commit/027499a82434ea7a784b2e5a0227540f00fbc307 DIFF: https://github.com/llvm/llvm-project/commit/027499a82434ea7a784b2e5a0227540f00fbc307.diff LOG: [lldb/test] Fix PExpect.launch issue when disabling color support This patch should fix a bug in PExpect.launch that happened when color support is not enabled. In that case, we need to add the `--no-use-colors` flag to lldb's launch argument list. However, previously, each character to the string was appended separately to the `args` list. This patch solves that by adding the whole string to the list. This should fix the TestIOHandlerResize failure on GreenDragon. Differential Revision: https://reviews.llvm.org/D126021 Signed-off-by: Med Ismail Bennani <medismail.benn...@gmail.com> Added: Modified: lldb/packages/Python/lldbsuite/test/lldbpexpect.py Removed: ################################################################################ diff --git a/lldb/packages/Python/lldbsuite/test/lldbpexpect.py b/lldb/packages/Python/lldbsuite/test/lldbpexpect.py index 1083705a20119..22a30c5d22c45 100644 --- a/lldb/packages/Python/lldbsuite/test/lldbpexpect.py +++ b/lldb/packages/Python/lldbsuite/test/lldbpexpect.py @@ -34,7 +34,7 @@ def launch(self, executable=None, extra_args=None, timeout=60, args += run_under args += [lldbtest_config.lldbExec, '--no-lldbinit'] if not use_colors: - args += '--no-use-colors' + args.append('--no-use-colors') for cmd in self.setUpCommands(): if "use-color false" in cmd and use_colors: continue _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
