mib created this revision.
mib added a reviewer: JDevlieghere.
mib added a project: LLDB.
Herald added a project: All.
mib requested review of this revision.
This patch should fix a bug in PExpect.launch that happened when color
support is not enabled.
In that case, we need to add the `--no-use-colors` flag to lldb's launch
argument list. However, previously, each character to the string was
appended separately to the `args` list. This patch solves that by adding
the whole string to the list.
This should fix the TestIOHandlerResize failure on GreenDragon.
Signed-off-by: Med Ismail Bennani <[email protected]>
https://reviews.llvm.org/D126021
Files:
lldb/packages/Python/lldbsuite/test/lldbpexpect.py
Index: lldb/packages/Python/lldbsuite/test/lldbpexpect.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/lldbpexpect.py
+++ lldb/packages/Python/lldbsuite/test/lldbpexpect.py
@@ -34,7 +34,7 @@
args += run_under
args += [lldbtest_config.lldbExec, '--no-lldbinit']
if not use_colors:
- args += '--no-use-colors'
+ args.append('--no-use-colors')
for cmd in self.setUpCommands():
if "use-color false" in cmd and use_colors:
continue
Index: lldb/packages/Python/lldbsuite/test/lldbpexpect.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/lldbpexpect.py
+++ lldb/packages/Python/lldbsuite/test/lldbpexpect.py
@@ -34,7 +34,7 @@
args += run_under
args += [lldbtest_config.lldbExec, '--no-lldbinit']
if not use_colors:
- args += '--no-use-colors'
+ args.append('--no-use-colors')
for cmd in self.setUpCommands():
if "use-color false" in cmd and use_colors:
continue
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
