[Lldb-commits] [PATCH] D114675: [lldb] [Target] Support fallback to file address in ReadMemory()

labath requested changes to this revision. labath added a reviewer: jingham. labath added a comment. This revision now requires changes to proceed. I don't think this is the right solution to this problem. The way I see it, there are two separate questions here: - why is the module containing `h

[Lldb-commits] [PATCH] D114675: [lldb] [Target] Support fallback to file address in ReadMemory()

mgorny added a comment. In D114675#3157595 , @labath wrote: > I don't think this is the right solution to this problem. If it's not, then the expression parser should probably be changed for consistency. > The way I see it, there are two separate quest

[Lldb-commits] [PATCH] D114675: [lldb] [Target] Support fallback to file address in ReadMemory()

labath added a comment. In D114675#3157622 , @mgorny wrote: > In D114675#3157595 , @labath wrote: > >> I don't think this is the right solution to this problem. > > If it's not, then the expression parser should p

[Lldb-commits] [PATCH] D114675: [lldb] [Target] Support fallback to file address in ReadMemory()

mgorny added a comment. (lldb) image list [ 0] 199D1036-3762-54C0-1775-361BD9AF5B17-C58273BB 0x8020 /home/mgorny/git/libfbsdvmcore/kernel CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114675/new/ https://reviews.llvm.org/D114675 __

[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

JDevlieghere added a comment. I can't speak to the correctness of the Windows parts, but all the utility function stuff looks sane to me. LGTM if Pavel has no outstanding objections. Comment at: lldb/source/Plugins/Platform/Windows/PlatformWindows.h:47-51 + uint32_t DoLoadIma

[Lldb-commits] [PATCH] D114554: Fix TestFileHandle.py. Remove redundant skipIfReproducer annotation

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114554/new/ https://reviews.llvm.org/D114554 ___

[Lldb-commits] [PATCH] D114554: Fix TestFileHandle.py. Remove redundant skipIfReproducer annotation

PatriosTheGreat abandoned this revision. PatriosTheGreat added a comment. Closing this revision since Pavel already fixed this in rGc0e3bb4d4ba306 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D114369: [lldb] Remove 'extern "C"' from the lldb-swig-python interface

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114369/new/ https://reviews.llvm.org/D114369 _

[Lldb-commits] [PATCH] D114719: [lldb] Move non-clang specific method to the generic DWARF Parser

ljmf00 created this revision. Herald added a reviewer: shafik. ljmf00 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch renames DW_ACCESS_to_AccessType function and move it to the abstract DWARFASTParser, since there is no cla

[Lldb-commits] [PATCH] D114719: [lldb] Move non-clang specific method to the generic DWARF Parser

ljmf00 updated this revision to Diff 390392. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114719/new/ https://reviews.llvm.org/D114719 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h lldb/source/Plugins/SymbolFil

[Lldb-commits] [PATCH] D114467: [LLDB][NativePDB] Allow find functions by full names

stella.stamenova added a comment. This broke the windows bot: https://lab.llvm.org/buildbot/#/builders/83/builds/12270 I'd like to get it back to green, so please address this ASAP or I'll follow up with a reverting change later today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D114722: [LLDB] Fix Python GIL-not-held issues

rupprecht created this revision. rupprecht added a reviewer: labath. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The GIL must be held when calling any Python C API functions. In multithreaded applications that use callbacks t

[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: lldb/source/Plugins/Platform/Windows/PlatformWindows.h:47-51 + uint32_t DoLoadImage(lldb_private::Process *process, + const lldb_private::FileSpec &remote_file, +

[Lldb-commits] [lldb] 34d02fa - [LLDB][NativePDB] fix find-functions.cpp failure on windows bots

Author: Zequan Wu Date: 2021-11-29T10:05:09-08:00 New Revision: 34d02fada28753221eda576e2f651f9b23c3f1af URL: https://github.com/llvm/llvm-project/commit/34d02fada28753221eda576e2f651f9b23c3f1af DIFF: https://github.com/llvm/llvm-project/commit/34d02fada28753221eda576e2f651f9b23c3f1af.diff LOG

[Lldb-commits] [PATCH] D114467: [LLDB][NativePDB] Allow find functions by full names

zequanwu added a comment. In D114467#3158778 , @stella.stamenova wrote: > This broke the windows bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/12270 > > I'd like to get it back to green, so please address this ASAP or I'll follow > up with

[Lldb-commits] [PATCH] D114719: [lldb] Move non-clang specific method to the generic DWARF Parser

ljmf00 updated this revision to Diff 390412. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114719/new/ https://reviews.llvm.org/D114719 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h lldb/source/Plugins/SymbolFil

[Lldb-commits] [PATCH] D114467: [LLDB][NativePDB] Allow find functions by full names

stella.stamenova added a comment. @zequanwu : It looks like the bot is still broken: https://lab.llvm.org/buildbot/#/builders/83/builds/12413 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114467/new/ https://reviews.llvm.org/D114467 _

[Lldb-commits] [lldb] fe270ab - [LLDB][NativePDB] fix find-functions.cpp failure on windows bots (2)

Author: Zequan Wu Date: 2021-11-29T11:06:06-08:00 New Revision: fe270ab061fa1200d1f7e121ac6671f7d24b73d6 URL: https://github.com/llvm/llvm-project/commit/fe270ab061fa1200d1f7e121ac6671f7d24b73d6 DIFF: https://github.com/llvm/llvm-project/commit/fe270ab061fa1200d1f7e121ac6671f7d24b73d6.diff LOG

[Lldb-commits] [PATCH] D114467: [LLDB][NativePDB] Allow find functions by full names

zequanwu added a comment. In D114467#3158960 , @stella.stamenova wrote: > @zequanwu : It looks like the bot is still broken: > https://lab.llvm.org/buildbot/#/builders/83/builds/12413 The printed names are different between windows and linux. https://

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

clayborg updated this revision to Diff 390444. clayborg added a comment. Let the call_once protect the ObjectFile::m_symtab_up as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114288/new/ https://reviews.llvm.org/D114288 Files: lldb/i

[Lldb-commits] [lldb] 4f215bf - Update unit test API usage (NFC)

Author: Adrian Prantl Date: 2021-11-29T13:14:35-08:00 New Revision: 4f215bfa6ee525b245b81462d75c3e1e47d18f13 URL: https://github.com/llvm/llvm-project/commit/4f215bfa6ee525b245b81462d75c3e1e47d18f13 DIFF: https://github.com/llvm/llvm-project/commit/4f215bfa6ee525b245b81462d75c3e1e47d18f13.diff

[Lldb-commits] [PATCH] D114719: [lldb] Move non-clang specific method to the generic DWARF Parser

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. This makes sense to me. Out of curiosity, do you have plans to use this for non-clang-based languages? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114719/new/ https://reviews

[Lldb-commits] [PATCH] D114742: [lldb] Search PrivateFrameworks when using an internal SDK

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jasonmolenda. JDevlieghere requested review of this revision. Herald added a project: LLDB. Make sure to add the PrivateFrameworks directory to the frameworks path when using an internal SDK. This is necessary for the "on-

[Lldb-commits] [PATCH] D114668: [lldb] Move generic DWARFASTParser code out of Clang-specific code

bulbazord added a comment. I think breaking it out of the Clang-specific class makes sense if we want LLDB to be more language-agnostic. Do you have an idea of what bits of `DWARFASTParserClang` can be moved out other than `ParseChildArrayInfo` and `GetAccessTypeFromDWARF` (from the patch on to

[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

ljmf00 created this revision. Herald added a reviewer: shafik. ljmf00 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch generalizes the ParsedDWARFTypeAttributes struct to be able to share with other DWARF parsers other than clang

[Lldb-commits] [PATCH] D114746: [lldb][NFC] Generalize ParsedDWARFTypeAttributes

ljmf00 updated this revision to Diff 390487. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114746/new/ https://reviews.llvm.org/D114746 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h lldb/source/Plugins

[Lldb-commits] [PATCH] D114719: [lldb] Move non-clang specific method to the generic DWARF Parser

ljmf00 added a comment. In D114719#3159587 , @bulbazord wrote: > This makes sense to me. Out of curiosity, do you have plans to use this for > non-clang-based languages? Yes. I'm currently working on a D language plugin. You can see my fork, until I up

[Lldb-commits] [PATCH] D114746: [lldb][NFC] Generalize ParsedDWARFTypeAttributes

ljmf00 updated this revision to Diff 390489. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114746/new/ https://reviews.llvm.org/D114746 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h lldb/source/Plugins

[Lldb-commits] [lldb] 6f99e1a - [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

Author: Luís Ferreira Date: 2021-11-29T23:55:58Z New Revision: 6f99e1aa58e3566fcce689bc986b7676e818c038 URL: https://github.com/llvm/llvm-project/commit/6f99e1aa58e3566fcce689bc986b7676e818c038 DIFF: https://github.com/llvm/llvm-project/commit/6f99e1aa58e3566fcce689bc986b7676e818c038.diff LOG:

[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f99e1aa58e3: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h (authored by ljmf00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://rev

[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

dblaikie added inline comments. Comment at: lldb/include/lldb/Symbol/Type.h:205-206 + static bool GetTypeScopeAndBasename(const llvm::StringRef name, + llvm::StringRef scope, + llvm::StringRef basename,

[Lldb-commits] [lldb] 2e5c47e - Revert "[lldb][NFC] Format lldb/include/lldb/Symbol/Type.h"

Author: Luís Ferreira Date: 2021-11-30T00:52:53Z New Revision: 2e5c47eda14a547c21e57d869a1e51ffd9938289 URL: https://github.com/llvm/llvm-project/commit/2e5c47eda14a547c21e57d869a1e51ffd9938289 DIFF: https://github.com/llvm/llvm-project/commit/2e5c47eda14a547c21e57d869a1e51ffd9938289.diff LOG:

[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

dblaikie requested changes to this revision. dblaikie added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Symbol/Type.h:204-206 + static bool GetTypeScopeAndBasename(const llvm::StringRef name, +

[Lldb-commits] [PATCH] D114675: [lldb] [Target] Support fallback to file address in ReadMemory()

jingham added a comment. Is this the proposal: If you are talking to a live process (including a Core File process) and the plugin you are using says it knows nothing about 0x1234, then as a fallback you ask some file if it has that address? Why do you need to do this? Are you guessing that t

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp:1 +#include "DWARFASTParser.h" +#include "DWARFAttribute.h" bulbazord wrote: > This file will need a license header. Yes, my bad. Thanks for noticing it. =

[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

ljmf00 added a comment. I'm not sure if this falls into NFC category since I'm changing how flags are stored. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114746/new/ https://reviews.llvm.org/D114746 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D114675: [lldb] [Target] Support fallback to file address in ReadMemory()

mgorny added a comment. Well, that's what happens with the core file I have and what you're asking for is really above my paygrade. That said, this is kernel core dump, so load addresses should probably be the same as vm-addresses in the file. If adding something simple to the core file will ac