dblaikie added inline comments.
================
Comment at: lldb/include/lldb/Symbol/Type.h:205-206
+ static bool GetTypeScopeAndBasename(const llvm::StringRef name,
+ llvm::StringRef scope,
+ llvm::StringRef basename,
lldb::TypeClass &type_class);
----------------
Looks like this could've broken some tests - might be best to revert and retest?
The `const StringRef&` should've been changed to `StringRef` per
@JDevlieghere's comment, but the non-const `StringRef&` were/are probably
load-bearing - they're the result of calling this function (using mutable ref
parameters as "out" parameters) & passing them by value breaks that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113604/new/
https://reviews.llvm.org/D113604
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
