[Lldb-commits] [PATCH] D76407: [lldb/testsuite] Remove "healthy process" test from TestProcessCrashInfo.py

labath added a comment. In D76407#1931335 , @friss wrote: > In D76407#1930693 , @labath wrote: > > > Could the inferior manually wipe the crash annotation? > > > This is not something you're supposed to wipe. It's a

[Lldb-commits] [PATCH] D76407: [lldb/testsuite] Remove "healthy process" test from TestProcessCrashInfo.py

labath added a comment. In D76407#1931551 , @jingham wrote: > This test just seems wrong to me. We can pretend that processes that haven't > crashed don't have crash_info, and manually suppress the output in lldb if > the stop state isn't a crash. But

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

labath accepted this revision. labath marked an inline comment as done. labath added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py:55-56 +# Wait until the underlying lldb-vscode process dies. +# We need to do this because

[Lldb-commits] [PATCH] D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector (WIP)

labath added a comment. looking forward to seeing the final form of this In D76449#1932293 , @mib wrote: > Note that this diff is more a quick draft than a “finished” patch, I’m not > expecting to submit this until the DW_OP_bit_piece support is done.

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This is great. The new test looks even better than I had hoped for. Thanks for sticking with this. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/threads

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I think this needs a lot more discussion. First, there's some weird layering going on here, where the class SDK is declared in lldb/Utility, but it's implemented in PlatformDarwin. B

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

labath added a comment. I think this is a good change, and is in line with what we have discussed previously. I have just one question about the exact variable interactions here. Since the raison d'être of the new setting is to be able to "un-inherit" a particular environment variable, I'm wond

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

labath accepted this revision. labath added a comment. This looks good to me. I still have some doubts about the ConstStringification of the returned values (I am not a fan of constifying everything), but I don't want to block this review for that. Comment at: lldb/source/API

[Lldb-commits] [lldb] 467c490 - [lldb] Enable now passing part of TestDataFormatterStdString.py

Author: Raphael Isemann Date: 2020-03-20T11:35:15+01:00 New Revision: 467c4902a10999f792bea653147641ac8b89cca5 URL: https://github.com/llvm/llvm-project/commit/467c4902a10999f792bea653147641ac8b89cca5 DIFF: https://github.com/llvm/llvm-project/commit/467c4902a10999f792bea653147641ac8b89cca5.dif

[Lldb-commits] [lldb] 089cfe1 - Improve step over performance

Author: Jaroslav Sevcik Date: 2020-03-20T11:41:56+01:00 New Revision: 089cfe113da1395427dd31f21067d5b618b89d7c URL: https://github.com/llvm/llvm-project/commit/089cfe113da1395427dd31f21067d5b618b89d7c DIFF: https://github.com/llvm/llvm-project/commit/089cfe113da1395427dd31f21067d5b618b89d7c.dif

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

labath added inline comments. Comment at: lldb/source/Host/common/DebugInfoD.cpp:59 + char *cache_path = nullptr; + int rc = debuginfod_find_source(client, buildID.GetBytes().data(), + buildID.GetBytes().size(), path.c_str(), fc

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

labath added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/environmentVariables/main.cpp:8 + +int main(int argc, char const *argv[], char const *envp[]) { + char **env_var_pointer = environ; I guess you don't need the `envp` argument if you're goi

[Lldb-commits] [PATCH] D76216: Improve step over performance

This revision was automatically updated to reflect the committed changes. Closed by commit rG089cfe113da1: Improve step over performance (authored by jarin, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76216/new/ https://revie

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

labath added a comment. In D76168#1929733 , @shafik wrote: > In D76168#1929211 , @labath wrote: > > > In D76168#1925176 , @shafik wrote: > > > > > Long-term I would like to m

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

labath added a comment. In D75929#1928964 , @ikudrin wrote: > In D75929#1926834 , @labath wrote: > > > (btw, is there a test case for the "unknown column" code path?) > > > Yes, it is checked in > `llvm/test/DebugI

[Lldb-commits] [PATCH] D75562: Add an opque payload field to lldb::Type (NFC).

labath added inline comments. Comment at: lldb/include/lldb/Symbol/Type.h:201-202 + uint32_t GetPayload() { return m_payload; } + /// Return the language-specific payload. + void SetPayload(uint32_t opaque_payload) { m_payload = opaque_payload; } It doesn't

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

jankratochvil added inline comments. Comment at: lldb/source/Host/common/DebugInfoD.cpp:59 + char *cache_path = nullptr; + int rc = debuginfod_find_source(client, buildID.GetBytes().data(), + buildID.GetBytes().size(), path.c_str(),

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

fche2 added inline comments. Comment at: lldb/source/Host/common/DebugInfoD.cpp:59 + char *cache_path = nullptr; + int rc = debuginfod_find_source(client, buildID.GetBytes().data(), + buildID.GetBytes().size(), path.c_str(), jan

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

jhenderson added a comment. @HsiangKai, have you noticed that there are some test failures according to the harbourmaster bot? They look like they could be related to this somehow. Comment at: llvm/unittests/Support/ELFAttributeParserTest.cpp:21 + Error handler(uint64_t tag,

[Lldb-commits] [PATCH] D76476: Add formatter for libc++ std::unique_ptr

vsk added a comment. Awesome :) Comment at: lldb/include/lldb/DataFormatters/FormattersHelpers.h:59 +lldb::ValueObjectSP GetValueOfCompressedPair(ValueObject &pair); + Mind adding ‘libcxx’ somewhere in the function name, to avoid confusion?

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

friss added a comment. In D76470#1933062 , @labath wrote: > I think this is a good change, and is in line with what we have discussed > previously. I have just one question about the exact variable interactions > here. > > Since the raison d'être of the

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

friss updated this revision to Diff 251670. friss added a comment. Add tests and update m_launch_info when undet-vars change. Improve docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76470/new/ https://reviews.llvm.org/D76470 Files: lldb/incl

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

shafik added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1318 + +static llvm::VersionTuple ParseSDKVersion(llvm::StringRef &name) { + unsigned i = 0; We should document what we expect the format to be. I mean I can deduce

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

aprantl added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusNameParser.cpp:333 + if (token.getKind() == tok::lessless) { +if (m_next_token_index + 1 < m_tokens.size()) { + clang::Token n_token = m_tokens[m_next_token_index + 1]; --

[Lldb-commits] [PATCH] D76009: [lldb/Target] Initialize new targets environment variables from target.env-vars

friss updated this revision to Diff 251675. friss added a comment. Make helper function name more descriptive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76009/new/ https://reviews.llvm.org/D76009 Files: lldb/include/lldb/Target/Target.h ll

[Lldb-commits] [lldb] 0b18b56 - [lldb-vscode] Don't use SBLaunchInfo in request_attach

Author: Anton Kolesov Date: 2020-03-20T20:15:23+03:00 New Revision: 0b18b568e91a3ebe3ab33d13328a1614fb94cf07 URL: https://github.com/llvm/llvm-project/commit/0b18b568e91a3ebe3ab33d13328a1614fb94cf07 DIFF: https://github.com/llvm/llvm-project/commit/0b18b568e91a3ebe3ab33d13328a1614fb94cf07.diff

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl added a comment. Thanks, Pavel, these are all very valid concerns and in retrospect I should have at least slapped an RFC label on this before dumping into phabricator last night. The goal of this (and I should have mentioned that in the description) is to make the Xcode SDK something t

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

jingham added a comment. Is there any command-based way to see the entire environment that a process will get when it launches? By populating target.env-vars with the inherited environment there was a way to mostly do that, but I don't see that anymore. It seems a shame not to be able to see

[Lldb-commits] [PATCH] D76351: [lldb-vscode] Don't use SBLaunchInfo in request_attach

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b18b568e91a: [lldb-vscode] Don't use SBLaunchInfo in request_attach (authored by anton.kolesov, committed by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [lldb] 5de4ba1 - Cleanup the plumbing for DILineInfoSpecifier. [NFC - Try 2]

Author: Sterling Augustine Date: 2020-03-20T10:29:57-07:00 New Revision: 5de4ba1770f4815dd36d449a9b64b0aec783159d URL: https://github.com/llvm/llvm-project/commit/5de4ba1770f4815dd36d449a9b64b0aec783159d DIFF: https://github.com/llvm/llvm-project/commit/5de4ba1770f4815dd36d449a9b64b0aec783159d.

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1933985 , @djtodoro wrote: > Oh sorry, I thought it all has been fixed, since all the tests pass. > > We should revert the D75036 until we fix > all the issues. @dstenb do you agree?

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

manojgupta added a comment. Still causing a crash using a previously supplied test https://bugs.chromium.org/p/chromium/issues/detail?id=1061533#c7. Any reason this was not tested with a previous repro? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Oh sorry, I thought it all has been fixed, since all the tests pass. We should revert the D75036 until we fix all the issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___

[Lldb-commits] [PATCH] D76476: Add formatter for libc++ std::unique_ptr

shafik updated this revision to Diff 251707. shafik marked 4 inline comments as done. shafik added a comment. Addressing comments on naming and not duplicating the regex CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76476/new/ https://reviews.llvm.org/D76476 Files: lldb/include/lldb/

[Lldb-commits] [PATCH] D76476: Add formatter for libc++ std::unique_ptr

shafik added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:618 + "unique_ptr synthetic children", + ConstString("^(std::__[[:alnum:]]+::)unique_ptr<.+>(( )?&)?$"), + stl_synth_flags, true); vsk wrote: > D

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

friss added a comment. In D76470#1933910 , @jingham wrote: > Is there any command-based way to see the entire environment that a process > will get when it launches? By populating target.env-vars with the inherited > environment there was a way to mostl

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1934105 , @vsk wrote: > In D73534#1933988 , @djtodoro wrote: > > > In D73534#1933985 , @djtodoro > > wrote: > > > > > Oh sorry, I thought

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

vsk added a comment. @manojgupta I apologize for not catching this earlier. The issue should really be fixed by 636665331bbd4c369a9f33c4d35fb9a863c94646 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ http

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

vsk added a comment. In D73534#1933988 , @djtodoro wrote: > In D73534#1933985 , @djtodoro wrote: > > > Oh sorry, I thought it all has been fixed, since all the tests pass. > > > > We should revert the D75036

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

jingham added a comment. In D76470#1934146 , @friss wrote: > In D76470#1933910 , @jingham wrote: > > > Is there any command-based way to see the entire environment that a process > > will get when it launches? By

[Lldb-commits] [PATCH] D76476: Add formatter for libc++ std::unique_ptr

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM with some added test coverage. Jim? Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/main.cpp:9 + std::unique_ptr up_int = std::

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

jarin updated this revision to Diff 251714. jarin marked 3 inline comments as done. jarin added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74398/new/ https://reviews.llvm.org/D74398 Files: lldb/packages/Python/

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

wallace added a comment. Thanks a lot, guys. I learned a lot from you doing this patch :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76111/new/ https://reviews.llvm.org/D76111 ___ lldb-commits maili

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

wallace updated this revision to Diff 251740. wallace added a comment. apply last suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76111/new/ https://reviews.llvm.org/D76111 Files: lldb/bindings/headers.swig lldb/bindings/interface/SB

[Lldb-commits] [lldb] 6385c2a - [AppleObjCRuntimeV2] Force lazily allocated class names to be resolved.

Author: Davide Italiano Date: 2020-03-20T13:43:08-07:00 New Revision: 6385c2ab8ff8304eafa822012c40934690bde124 URL: https://github.com/llvm/llvm-project/commit/6385c2ab8ff8304eafa822012c40934690bde124 DIFF: https://github.com/llvm/llvm-project/commit/6385c2ab8ff8304eafa822012c40934690bde124.dif

Re: [Lldb-commits] [lldb] 6385c2a - [AppleObjCRuntimeV2] Force lazily allocated class names to be resolved.

> On Mar 20, 2020, at 1:43 PM, Davide Italiano via lldb-commits > wrote: > > > Author: Davide Italiano > Date: 2020-03-20T13:43:08-07:00 > New Revision: 6385c2ab8ff8304eafa822012c40934690bde124 > > URL: > https://github.com/llvm/llvm-project/commit/6385c2ab8ff8304eafa822012c40934690bde124 >

Re: [Lldb-commits] [lldb] 6385c2a - [AppleObjCRuntimeV2] Force lazily allocated class names to be resolved.

Yes, I’m working on a fix. Can you use regular expressions or globs in FileCheck matching? It means if you ever add a test that makes an expression above this test in the file, you have to go renumber everything. That's kind of annoying even if the numbering was still working, and you aren’t

Re: [Lldb-commits] [lldb] 6385c2a - [AppleObjCRuntimeV2] Force lazily allocated class names to be resolved.

> On Mar 20, 2020, at 1:48 PM, Jim Ingham wrote: > > Yes, I’m working on a fix. > > Can you use regular expressions or globs in FileCheck matching? It means if > you ever add a test that makes an expression above this test in the file, you > have to go renumber everything. That's kind of

[Lldb-commits] [lldb] 696ae6f - [StopHook] Use wildcard matching. Pointed out by Jim Ingham.

Author: Davide Italiano Date: 2020-03-20T13:57:40-07:00 New Revision: 696ae6f7d8e170c82d5f2978fc99cc061f52b4ef URL: https://github.com/llvm/llvm-project/commit/696ae6f7d8e170c82d5f2978fc99cc061f52b4ef DIFF: https://github.com/llvm/llvm-project/commit/696ae6f7d8e170c82d5f2978fc99cc061f52b4ef.dif

Re: [Lldb-commits] [lldb] 6385c2a - [AppleObjCRuntimeV2] Force lazily allocated class names to be resolved.

> On Mar 20, 2020, at 1:49 PM, Davidino Italiano via lldb-commits > wrote: > > > >> On Mar 20, 2020, at 1:48 PM, Jim Ingham wrote: >> >> Yes, I’m working on a fix. >> >> Can you use regular expressions or globs in FileCheck matching? It means >> if you ever add a test that makes an exp

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace updated this revision to Diff 251754. wallace added a comment. I added some tests cases to show why I used "settings set target.inherit-env". There are currently two ways to launch a process. Either with the plain "program" argument, or with the "launchCommands" argument. The latter is a

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace updated this revision to Diff 251756. wallace added a comment. improve comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvsco

[Lldb-commits] [lldb] 2dec826 - Create basic SBEnvironment class

Author: Walter Erquinigo Date: 2020-03-20T14:38:50-07:00 New Revision: 2dec82652e4b6424e46e7bd674cb6404e01e218e URL: https://github.com/llvm/llvm-project/commit/2dec82652e4b6424e46e7bd674cb6404e01e218e DIFF: https://github.com/llvm/llvm-project/commit/2dec82652e4b6424e46e7bd674cb6404e01e218e.di

[Lldb-commits] [lldb] 576105c - [lldb-vscode] stop read loop after termination

Author: Walter Erquinigo Date: 2020-03-20T14:38:49-07:00 New Revision: 576105c322b6b9cd48c82c8551be45707044a83d URL: https://github.com/llvm/llvm-project/commit/576105c322b6b9cd48c82c8551be45707044a83d DIFF: https://github.com/llvm/llvm-project/commit/576105c322b6b9cd48c82c8551be45707044a83d.di

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace updated this revision to Diff 251760. wallace added a comment. test pass now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace updated this revision to Diff 251762. wallace added a comment. simplify code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace updated this revision to Diff 251766. wallace added a comment. further simplify code. Sorry for the noise Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files: lldb/packages/Python/lldbsuite/test

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2dec82652e4b: Create basic SBEnvironment class (authored by Walter Erquinigo ). Repository: rG LLVM

[Lldb-commits] [PATCH] D76529: [lldb-vscode] Add missing launchCommands entry in the package.json

wallace created this revision. wallace added reviewers: clayborg, labath, kusmour, aadsm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. https://reviews.llvm.org/D65363 introduced the launchCommands argument. However, it did not add a corresponding definition in the packag

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

This revision was automatically updated to reflect the committed changes. Closed by commit rG576105c322b6: [lldb-vscode] stop read loop after termination (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D76476: Add formatter for libc++ std::unique_ptr

shafik updated this revision to Diff 251783. shafik marked an inline comment as done. shafik added a comment. Adding addition tests for references CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76476/new/ https://reviews.llvm.org/D76476 Files: lldb/include/lldb/DataFormatters/Formatte

[Lldb-commits] [PATCH] D76532: Internal expressions should not increment the next result variable numbering

jingham created this revision. jingham added a reviewer: davide. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. For instance, breakpoints run an expression when evaluating a condition. If each of these expression evaluations incremented the result numbering, you could en

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

friss updated this revision to Diff 251794. friss added a comment. Herald added a subscriber: mgrang. Add a new target command to dump the launch environment Make env-vars override unset-env-vars Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76470/n

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

friss added a comment. In D76470#1934201 , @jingham wrote: > In D76470#1934146 , @friss wrote: > > > In D76470#1933910 , @jingham wrote: > > > > > Is there any command-based

[Lldb-commits] [lldb] 0a5fbf3 - Temporarily Revert "Create basic SBEnvironment class"

Author: Adrian Prantl Date: 2020-03-20T16:47:50-07:00 New Revision: 0a5fbf30937a12b0330ca0a59fe123f4992873f7 URL: https://github.com/llvm/llvm-project/commit/0a5fbf30937a12b0330ca0a59fe123f4992873f7 DIFF: https://github.com/llvm/llvm-project/commit/0a5fbf30937a12b0330ca0a59fe123f4992873f7.diff

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

aprantl added a comment. It looks like this test doesn't work on the bots: http://green.lab.llvm.org/green//view/LLDB/job/lldb-cmake/lastCompletedBuild//testReport/junit/lldb-api/python_api_sbenvironment/TestSBEnvironment_py/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

aprantl added a comment. Since it's late on Friday afternoon I'm taking the liberty to revert the patch to get the bots running again. Feel free to re-land with a fix or ask for another round of review if you have more questions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76535: [lldb]/Tablegen] Use ElementType instead of DefaultValueUnsinged for Array and Dictionary

JDevlieghere created this revision. JDevlieghere added a reviewer: friss. The fourth field in the property struct is the default unsigned or enum value for all types, except for `Array` and `Dictionary` types. For those, it is the element type. During the tablegen conversion, this was incorrectl

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

jingham added a comment. Except for the suggestion to use eCommandRequiresTarget for the new command, this looks good. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:690 +interpreter, "target show-launch-environment", +"Shows the environemtn b

[Lldb-commits] [PATCH] D76529: [lldb-vscode] Add missing launchCommands entry in the package.json

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/package.json:150 + "type": "array", +

[Lldb-commits] [lldb] 09c8845 - [lldb]/Tablegen] Use ElementType instead of DefaultValueUnsinged

Author: Jonas Devlieghere Date: 2020-03-20T18:35:13-07:00 New Revision: 09c8845adfd9e86a227d6413d57b462d8566d399 URL: https://github.com/llvm/llvm-project/commit/09c8845adfd9e86a227d6413d57b462d8566d399 DIFF: https://github.com/llvm/llvm-project/commit/09c8845adfd9e86a227d6413d57b462d8566d399.d

[Lldb-commits] [lldb] a8c22ba - [lldb-vscode] Add missing launchCommands entry in the package.json

Author: Walter Erquinigo Date: 2020-03-20T18:51:25-07:00 New Revision: a8c22ba4162976894b34b75fd12aced379e0569b URL: https://github.com/llvm/llvm-project/commit/a8c22ba4162976894b34b75fd12aced379e0569b DIFF: https://github.com/llvm/llvm-project/commit/a8c22ba4162976894b34b75fd12aced379e0569b.di

[Lldb-commits] [lldb] 34c0759 - Create basic SBEnvironment class

Author: Walter Erquinigo Date: 2020-03-20T18:51:25-07:00 New Revision: 34c0759f846447454714c8faa0e1753a8713637b URL: https://github.com/llvm/llvm-project/commit/34c0759f846447454714c8faa0e1753a8713637b DIFF: https://github.com/llvm/llvm-project/commit/34c0759f846447454714c8faa0e1753a8713637b.di

[Lldb-commits] [lldb] 4ec6eba - [lldb-vscode] Add inheritEnvironment option

Author: Hector Diaz Date: 2020-03-20T18:51:25-07:00 New Revision: 4ec6ebabfc3ec03d3ad4d3bdf05a7292d01391b3 URL: https://github.com/llvm/llvm-project/commit/4ec6ebabfc3ec03d3ad4d3bdf05a7292d01391b3 DIFF: https://github.com/llvm/llvm-project/commit/4ec6ebabfc3ec03d3ad4d3bdf05a7292d01391b3.diff L

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

friss updated this revision to Diff 251813. friss added a comment. Simplify command definition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76470/new/ https://reviews.llvm.org/D76470 Files: lldb/include/lldb/Target/Target.h lldb/source/Comman

[Lldb-commits] [PATCH] D76535: [lldb]/Tablegen] Use ElementType instead of DefaultValueUnsinged for Array and Dictionary

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG09c8845adfd9: [lldb]/Tablegen] Use ElementType instead of DefaultValueUnsinged (authored by JDevlieghere). Herald added a

[Lldb-commits] [PATCH] D76529: [lldb-vscode] Add missing launchCommands entry in the package.json

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rGa8c22ba41629: [lldb-vscode] Add missing launchCommands entry in the package.json (authored by Walter Erquinigo

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG4ec6ebabfc3e: [lldb-vscode] Add inheritEnvironment option (authored by Hector Diaz , committed by Walter Erq

[Lldb-commits] [lldb] e292cdf - Revert "[lldb-vscode] Add missing launchCommands entry in the package.json"

Author: Walter Erquinigo Date: 2020-03-20T19:25:12-07:00 New Revision: e292cdfb33829952fb5a837d4e9c528281a3fffd URL: https://github.com/llvm/llvm-project/commit/e292cdfb33829952fb5a837d4e9c528281a3fffd DIFF: https://github.com/llvm/llvm-project/commit/e292cdfb33829952fb5a837d4e9c528281a3fffd.di

[Lldb-commits] [lldb] 7ece7c0 - Revert "Create basic SBEnvironment class"

Author: Walter Erquinigo Date: 2020-03-20T19:25:27-07:00 New Revision: 7ece7c0faae39b5c57662b28e0e51b2a82ad34c3 URL: https://github.com/llvm/llvm-project/commit/7ece7c0faae39b5c57662b28e0e51b2a82ad34c3 DIFF: https://github.com/llvm/llvm-project/commit/7ece7c0faae39b5c57662b28e0e51b2a82ad34c3.di

[Lldb-commits] [lldb] c85bf7c - Revert "[lldb-vscode] Add inheritEnvironment option"

Author: Walter Erquinigo Date: 2020-03-20T19:24:51-07:00 New Revision: c85bf7cfa8bd0a3f2f68f57d9b49f003bbafec7f URL: https://github.com/llvm/llvm-project/commit/c85bf7cfa8bd0a3f2f68f57d9b49f003bbafec7f DIFF: https://github.com/llvm/llvm-project/commit/c85bf7cfa8bd0a3f2f68f57d9b49f003bbafec7f.di

[Lldb-commits] [PATCH] D76529: [lldb-vscode] Add missing launchCommands entry in the package.json

wallace reopened this revision. wallace added a comment. I pushed this by mistake, but I've just reverted the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76529/new/ https://reviews.llvm.org/D76529 __

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace reopened this revision. wallace added a comment. I pushed this by mistake, but I've just reverted the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 __

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace updated this revision to Diff 251821. wallace added a comment. fix test failing with python3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-v