Author: Anton Kolesov Date: 2020-03-20T20:15:23+03:00 New Revision: 0b18b568e91a3ebe3ab33d13328a1614fb94cf07
URL: https://github.com/llvm/llvm-project/commit/0b18b568e91a3ebe3ab33d13328a1614fb94cf07 DIFF: https://github.com/llvm/llvm-project/commit/0b18b568e91a3ebe3ab33d13328a1614fb94cf07.diff LOG: [lldb-vscode] Don't use SBLaunchInfo in request_attach If LLDB attaches to an already running target, then structure SBAttachInfo is used instead of SBLaunchInfo. lldb-vscode function request_attach sets some values to g_vsc.launch_info, however this field is then not passed anywhere, so this action has no effect. This commit removes invocation of SBLaunchInfo::SetDetachOnError, which has no equivalent in SBAttachInfo. File package.json doesn't describe detachOnError property for "attach" request type, therefore it is not needed to update it. Differential Revision: https://reviews.llvm.org/D76351 Added: Modified: lldb/tools/lldb-vscode/lldb-vscode.cpp Removed: ################################################################################ diff --git a/lldb/tools/lldb-vscode/lldb-vscode.cpp b/lldb/tools/lldb-vscode/lldb-vscode.cpp index 080ef5b40c01..ff4a6af22af4 100644 --- a/lldb/tools/lldb-vscode/lldb-vscode.cpp +++ b/lldb/tools/lldb-vscode/lldb-vscode.cpp @@ -543,9 +543,6 @@ void request_attach(const llvm::json::Object &request) { return; } - const bool detatchOnError = GetBoolean(arguments, "detachOnError", false); - g_vsc.launch_info.SetDetachOnError(detatchOnError); - // Run any pre run LLDB commands the user specified in the launch.json g_vsc.RunPreRunCommands(); _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
