[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

grimar added inline comments. Comment at: lldb/source/Symbol/LineTable.cpp:27 + LineTable::Entry::LessThanBinaryPredicate less_than_bp(this); + std::sort(sequences.begin(), sequences.end(), less_than_bp); + for (auto *sequence : sequences) { I wonder if this h

[Lldb-commits] [PATCH] D69933: [ASTImporter] Limit imports of structs

jarin updated this revision to Diff 239235. jarin added a comment. Herald added a subscriber: lldb-commits. I changed the diff so that it does not touch Clang's AST importer, instead it patches LLDB's wrapper of the AST importer. The idea is to only import complete a record if the current evalua

[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

labath added a comment. In D72748#1829956 , @JDevlieghere wrote: > In D72748#1823945 , @labath wrote: > > > I didn't actually try it but I am pretty sure this will deadlock with > > nested lldb command files (runn

[Lldb-commits] [PATCH] D73016: [lldb/CMake] Make it possible to disable plugins at configuration time

labath added a comment. In D73016#1830303 , @JDevlieghere wrote: > - I'm aware of the linker issue when you reconfigure. I've spent quite some > time investigating this and this seems related to the way libraries to link > are cached by CMake. I verifie

[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

teemperor added inline comments. Comment at: lldb/source/Symbol/LineTable.cpp:27 + LineTable::Entry::LessThanBinaryPredicate less_than_bp(this); + std::sort(sequences.begin(), sequences.end(), less_than_bp); + for (auto *sequence : sequences) { grimar wrote: >

[Lldb-commits] [PATCH] D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest

teemperor updated this revision to Diff 239251. teemperor added a comment. - Removed all the duplicated linking flags too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73018/new/ https://reviews.llvm.org/D73018 Files: lldb/include/lldb/Initialization/SystemInitializerAllPlugins.h

[Lldb-commits] [PATCH] D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest

teemperor marked an inline comment as done. teemperor added a comment. I moved the single non-plugin call back to the original Full/Test subclasses so the name is now correct. Also I removed all the duplicated linking flags that I forgot to remove before. I also don't think we should make this

[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugins (WIP)

labath added a comment. Overall, I like this, but I have a lot of comments: - I actually very much like the plugin namespace idea -- it makes it harder to use plugin code from non-plugin code, and allows plugins of the same category (e.g. ProcessLinux and ProcessNetBSD) to define similar concep

[Lldb-commits] [PATCH] D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest

labath added a comment. In D73018#1830697 , @teemperor wrote: > I moved the single non-plugin call back to the original Full/Test subclasses > so the name is now correct. Also I removed all the duplicated linking flags > that I forgot to remove before.

[Lldb-commits] [PATCH] D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest

teemperor added a comment. > This still leaves the question of the script interpreter plugins, which are > suspiciously *not* included in "all plugins". The script interpreters are > quite special, so I think it's fine to handle them separately -- the question > is just how to convey that disti

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

labath added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/clang-ast-from-dwarf-unamed-and-anon-structs.cpp:1 +// Test to verify we are corectly generating anonymous flags when parsing +// anonymous class and unnamed structs from DWARF to the a clang AST node. --

[Lldb-commits] [lldb] 1f7b95d - [lldb][NFC] Convert LLDB_LOGF to LLDB_LOG in ClangASTSource.cpp

Author: Raphael Isemann Date: 2020-01-21T13:44:22+01:00 New Revision: 1f7b95d038e687fdaffdff55d32c16934f7bff60 URL: https://github.com/llvm/llvm-project/commit/1f7b95d038e687fdaffdff55d32c16934f7bff60 DIFF: https://github.com/llvm/llvm-project/commit/1f7b95d038e687fdaffdff55d32c16934f7bff60.dif

[Lldb-commits] [PATCH] D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest

labath added a comment. In D73018#1830891 , @teemperor wrote: > > This still leaves the question of the script interpreter plugins, which are > > suspiciously *not* included in "all plugins". The script interpreters are > > quite special, so I think it's

[Lldb-commits] [PATCH] D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest

labath added a comment. I just thought of another corner case (which may be important for the other patch too): `Plugins/Process/Linux` and `Plugins/Process/NetBSD` are used in lldb-server and are not/should not be used in liblldb (or lldb-test). `Plugins/Process/Windows` is even weirder becaus

[Lldb-commits] [lldb] 3f9b6b2 - [lldb] Use llvm::stable_sort in Line

Author: Pavel Labath Date: 2020-01-21T14:09:58+01:00 New Revision: 3f9b6b270f87430c28fb2ff811d3b58dbf8bfdde URL: https://github.com/llvm/llvm-project/commit/3f9b6b270f87430c28fb2ff811d3b58dbf8bfdde DIFF: https://github.com/llvm/llvm-project/commit/3f9b6b270f87430c28fb2ff811d3b58dbf8bfdde.diff

[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

labath added inline comments. Comment at: lldb/source/Symbol/LineTable.cpp:27 + LineTable::Entry::LessThanBinaryPredicate less_than_bp(this); + std::sort(sequences.begin(), sequences.end(), less_than_bp); + for (auto *sequence : sequences) { teemperor wrote: >

[Lldb-commits] [lldb] 18a96fd - [lldb/DWARF] Fix a leak in line table construction

Author: Pavel Labath Date: 2020-01-21T14:44:11+01:00 New Revision: 18a96fd573b134fed7d8ea6b87930e7a059d6c90 URL: https://github.com/llvm/llvm-project/commit/18a96fd573b134fed7d8ea6b87930e7a059d6c90 DIFF: https://github.com/llvm/llvm-project/commit/18a96fd573b134fed7d8ea6b87930e7a059d6c90.diff

[Lldb-commits] [lldb] 5e70f4b - [lldb/breakpad] Use new line table constructor

Author: Pavel Labath Date: 2020-01-21T15:04:27+01:00 New Revision: 5e70f4bdc15960730d0ff2aa167399e36bc64278 URL: https://github.com/llvm/llvm-project/commit/5e70f4bdc15960730d0ff2aa167399e36bc64278 DIFF: https://github.com/llvm/llvm-project/commit/5e70f4bdc15960730d0ff2aa167399e36bc64278.diff

[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugins (WIP)

labath added a comment. Since the initialization function will have to have predictable names anyway, instead of generating the `#include` directives, we could just automatically forward declare the needed functions. So, the .def file would expand to something like: extern lldb_initialize_ob

[Lldb-commits] [PATCH] D73112: [lldb/DWARF] Remove one more auto-dwo method

labath created this revision. labath added reviewers: JDevlieghere, aprantl, clayborg. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. Our DWARFUnit was automatically forwarding the requests to the split unit when looking for a DIE by offset. llvm::DWARFUnit does not do that, and

[Lldb-commits] [PATCH] D73116: [lldb/Initializers] Move all macOS initializers into PlatformMacOSX

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham, teemperor, xiaobai. Herald added a project: LLDB. PlatformMacOSX is the main entry point to the plugin with the same name. This is part of a greater refactoring to auto generate the initializers. (D73067

[Lldb-commits] [PATCH] D73116: [lldb/Initializers] Move all macOS initializers into PlatformMacOSX

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. this seems fine to me. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:9-35 #include "PlatformMacOSX.h" #include "lldb/Host/Config.h" - - -#include +#in

[Lldb-commits] [PATCH] D73119: [lldb/Initializers] Rename plugins to match their entry points

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, xiaobai. Herald added subscribers: jsji, atanasyan, kbarton, mgorny, nemanjai. Herald added a project: LLDB. Rename plugins to match their entry points. This is part of a greater refactoring to auto generate the

[Lldb-commits] [lldb] a731c6b - [lldb/Initializers] Move all macOS initializers into PlatformMacOSX

Author: Jonas Devlieghere Date: 2020-01-21T09:40:48-08:00 New Revision: a731c6ba94d0464c6a122de1af70ab88ffb5c1a6 URL: https://github.com/llvm/llvm-project/commit/a731c6ba94d0464c6a122de1af70ab88ffb5c1a6 DIFF: https://github.com/llvm/llvm-project/commit/a731c6ba94d0464c6a122de1af70ab88ffb5c1a6.d

[Lldb-commits] [PATCH] D73116: [lldb/Initializers] Move all macOS initializers into PlatformMacOSX

This revision was automatically updated to reflect the committed changes. Closed by commit rGa731c6ba94d0: [lldb/Initializers] Move all macOS initializers into PlatformMacOSX (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D73116?vs=239343&id=239355#toc Repository

[Lldb-commits] [PATCH] D73121: [lldb/Initializers] Move all ObjC initializers into AppleObjCRuntime

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, xiaobai. Herald added a project: LLDB. AppleObjCRuntime is the main entry point to the plugin with the same name. This is part of a greater refactoring to auto generate the initializers. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D73119: [lldb/Initializers] Rename plugins to match their entry points

labath added a comment. Herald added a subscriber: wuzish. There are three names to consider here: - the name of the cmake target - the name of the main .h file - the name of the folders the plugin is in Here you seem to be standardizing the first two, sometimes at the expense breaking existing

[Lldb-commits] [lldb] cf26380 - [lldb/tools] Update lldb-test's system initializer

Author: Jonas Devlieghere Date: 2020-01-21T09:58:35-08:00 New Revision: cf263807a6c0a6989476ae9d44a21a657e048c94 URL: https://github.com/llvm/llvm-project/commit/cf263807a6c0a6989476ae9d44a21a657e048c94 DIFF: https://github.com/llvm/llvm-project/commit/cf263807a6c0a6989476ae9d44a21a657e048c94.d

[Lldb-commits] [PATCH] D73053: [lldb/DataFormatters] Fix the `$$deference$$` synthetic child

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Except for one typo in the comment (thanks for adding that BTW) looks good. Comment at: lldb/docs/use/variable.rst:907 + if index == 0: + retu

[Lldb-commits] [PATCH] D69524: [debugserver] Delete macOS/PPC debug server implementation

vsk added a comment. Herald added a subscriber: wuzish. Friendly ping. This isn't urgent, just seems like a simple cleanup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69524/new/ https://reviews.llvm.org/D69524 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D73125: [lldb/Plugins] Move entry points out of plugin namespace

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, xiaobai. Herald added subscribers: abidh, aheejin, sbc100, emaste. Herald added a project: LLDB. This moves the plugin entry points (the class that has the `::Initialize` and `::Terminate` methods) out of the plu

[Lldb-commits] [PATCH] D69524: [debugserver] Delete macOS/PPC debug server implementation

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Ah, sorry yes, the initial debugserver implementation was written back when macOS ppc was still a thing (although on its way out) - but the time the switch happened to lldb, we'd d

[Lldb-commits] [PATCH] D73121: [lldb/Initializers] Move all ObjC initializers into AppleObjCRuntime

shafik added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp:58 +void AppleObjCRuntime::Initialize() { + AppleObjCRuntimeV2::Initialize(); + AppleObjCRuntimeV1::Initialize(); I am curious does order m

[Lldb-commits] [lldb] 9aba2ce - [debugserver] Delete macOS/PPC debug server implementation

Author: Vedant Kumar Date: 2020-01-21T10:59:38-08:00 New Revision: 9aba2ced34b295658f3f07311efe665495987426 URL: https://github.com/llvm/llvm-project/commit/9aba2ced34b295658f3f07311efe665495987426 DIFF: https://github.com/llvm/llvm-project/commit/9aba2ced34b295658f3f07311efe665495987426.diff

[Lldb-commits] [lldb] 441aebc - [debugserver] Delete stale code referencing ppc

Author: Vedant Kumar Date: 2020-01-21T11:04:04-08:00 New Revision: 441aebc5235af164a784d0b9bd460c07e01e9045 URL: https://github.com/llvm/llvm-project/commit/441aebc5235af164a784d0b9bd460c07e01e9045 DIFF: https://github.com/llvm/llvm-project/commit/441aebc5235af164a784d0b9bd460c07e01e9045.diff

[Lldb-commits] [lldb] 7c9bcba - [lldb] Add a setting to not install the main executable

Author: Francesco Petrogalli Date: 2020-01-21T19:06:44Z New Revision: 7c9bcba644c4fc2178e20060d9ba2ff1f50ae15e URL: https://github.com/llvm/llvm-project/commit/7c9bcba644c4fc2178e20060d9ba2ff1f50ae15e DIFF: https://github.com/llvm/llvm-project/commit/7c9bcba644c4fc2178e20060d9ba2ff1f50ae15e.dif

[Lldb-commits] [PATCH] D69524: [debugserver] Delete macOS/PPC debug server implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rG9aba2ced34b2: [debugserver] Delete macOS/PPC debug server implementation (authored by vsk). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D71761: [lldb] Add a setting to not install the main executable

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c9bcba644c4: [lldb] Add a setting to not install the main executable (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71761/new/ ht

[Lldb-commits] [lldb] 9bb1178 - Revert "[lldb] Add a setting to not install the main executable"

Author: Francesco Petrogalli Date: 2020-01-21T19:24:02Z New Revision: 9bb11785dca6b8ee1edb69b52c936edc95a794f0 URL: https://github.com/llvm/llvm-project/commit/9bb11785dca6b8ee1edb69b52c936edc95a794f0 DIFF: https://github.com/llvm/llvm-project/commit/9bb11785dca6b8ee1edb69b52c936edc95a794f0.dif

[Lldb-commits] [lldb] 95116c5 - [lldb] Add a setting to not install the main executable

Author: Daniel Kiss Date: 2020-01-21T19:26:18Z New Revision: 95116c591fab993df76bd20cfa74d2d44a1a9cc6 URL: https://github.com/llvm/llvm-project/commit/95116c591fab993df76bd20cfa74d2d44a1a9cc6 DIFF: https://github.com/llvm/llvm-project/commit/95116c591fab993df76bd20cfa74d2d44a1a9cc6.diff LOG: [

[Lldb-commits] [PATCH] D69933: [ASTImporter] Limit imports of structs

teemperor added a comment. I really don't think the ASTImporter should ever manipulate records in the source context (effectively the source context should be considered immutable). It also seems *very* wrong that what we import depends in any way on a previous expression so I agree we should f

[Lldb-commits] [PATCH] D73116: [lldb/Initializers] Move all macOS initializers into PlatformMacOSX

stella.stamenova added a comment. This change is causing a build break on Windows (which was hidden by the Hexagon build break you just fixed :(). http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/12857/steps/build/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D73121: [lldb/Initializers] Move all ObjC initializers into AppleObjCRuntime

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp:58 +void AppleObjCRuntime::Initialize() { + AppleObjCRuntimeV2::Initialize(); + AppleObjCRuntimeV1::Ini

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

aprantl added a comment. Looks like this broke the ASAN bot? http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-sanitized/783/testReport/junit/lldb-api/functionalities_breakpoint_comp_dir_symlink/TestCompDirSymLink_py/ lldb-api.functionalities/breakpoint/comp_dir_symlink.TestCompDirSymLink

[Lldb-commits] [PATCH] D71770: [lldb] Don't process symlinks deep inside DWARFUnit

aprantl added a comment. Looks like a missing nullptr check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71770/new/ https://reviews.llvm.org/D71770 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. context is missing with this diff (use git diff -U999). Changes look good. We do need a test though. All we need to do is create a target with nothing, then add the image to

[Lldb-commits] [lldb] b6c62ef - [lldb/Platform] Re-add ifdef's to guard macOS-only code.

Author: Jonas Devlieghere Date: 2020-01-21T12:26:52-08:00 New Revision: b6c62ef0871576dd03de2c0077ba15ad0be23f6b URL: https://github.com/llvm/llvm-project/commit/b6c62ef0871576dd03de2c0077ba15ad0be23f6b DIFF: https://github.com/llvm/llvm-project/commit/b6c62ef0871576dd03de2c0077ba15ad0be23f6b.d

Re: [Lldb-commits] [PATCH] D73116: [lldb/Initializers] Move all macOS initializers into PlatformMacOSX

Thanks, I was in meetings. Should be fixed commit b6c62ef0871576dd03de2c0077ba15ad0be23f6b (HEAD -> master, origin/master) Author: Jonas Devlieghere Date: Tue Jan 21 12:25:45 2020 -0800 [lldb/Platform] Re-add ifdef's to guard macOS-only code. I moved the code from the system initializ

[Lldb-commits] [PATCH] D72963: When darwin-debug exec's inferior suspended, make debugserver know that suspend count is higher than normal

clayborg added a comment. We do have people that don't create debugserver and just use the installed one to avoid code signing. Will there be any issue with people using older debugservers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72963/new/

[Lldb-commits] [lldb] aa91ce3 - [lldb/CMake] Add check-lldb-shell and check-lldb-api targets for Xcode

Author: Jonas Devlieghere Date: 2020-01-21T13:22:33-08:00 New Revision: aa91ce3e1dd53a614894d5bef515c5859eea368a URL: https://github.com/llvm/llvm-project/commit/aa91ce3e1dd53a614894d5bef515c5859eea368a DIFF: https://github.com/llvm/llvm-project/commit/aa91ce3e1dd53a614894d5bef515c5859eea368a.d

[Lldb-commits] [lldb] 0478ead - [lldb/DataFormatters] Fix the `$$deference$$` synthetic child

Author: Fred Riss Date: 2020-01-21T13:35:55-08:00 New Revision: 0478eadf73c191199cba12c85785cfafb8bfa174 URL: https://github.com/llvm/llvm-project/commit/0478eadf73c191199cba12c85785cfafb8bfa174 DIFF: https://github.com/llvm/llvm-project/commit/0478eadf73c191199cba12c85785cfafb8bfa174.diff LOG

[Lldb-commits] [PATCH] D73112: [lldb/DWARF] Remove one more auto-dwo method

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73112/new/ https://reviews.llvm.org/D73112 ___

[Lldb-commits] [PATCH] D73053: [lldb/DataFormatters] Fix the `$$deference$$` synthetic child

This revision was automatically updated to reflect the committed changes. Closed by commit rG0478eadf73c1: [lldb/DataFormatters] Fix the `$$deference$$` synthetic child (authored by friss). Changed prior to commit: https://reviews.llvm.org/D73053?vs=239188&id=239425#toc Repository: rG LLVM G

[Lldb-commits] [lldb] 83a131b - Fix an over-suspend bug with LaunchInNewTerminalWithAppleScript sessions

Author: Jason Molenda Date: 2020-01-21T14:55:46-08:00 New Revision: 83a131b276426a0dc97f43c139a0f3b308f24154 URL: https://github.com/llvm/llvm-project/commit/83a131b276426a0dc97f43c139a0f3b308f24154 DIFF: https://github.com/llvm/llvm-project/commit/83a131b276426a0dc97f43c139a0f3b308f24154.diff

[Lldb-commits] [PATCH] D72963: When darwin-debug exec's inferior suspended, make debugserver know that suspend count is higher than normal

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG83a131b27642: Fix an over-suspend bug with LaunchInNewTerminalWithAppleScript sessions (authored by jasonmolenda). Change

[Lldb-commits] [lldb] 7745990 - [lldb/Plugin] Rename TSanRuntime for consistency with plugin (NFC)

Author: Jonas Devlieghere Date: 2020-01-21T15:02:41-08:00 New Revision: 7745990dd93267d73e08ac5d9e5104645791a70e URL: https://github.com/llvm/llvm-project/commit/7745990dd93267d73e08ac5d9e5104645791a70e DIFF: https://github.com/llvm/llvm-project/commit/7745990dd93267d73e08ac5d9e5104645791a70e.d

[Lldb-commits] [lldb] 0feedeb - [lldb/Plugin] Rename AddressSanitizerRuntime for consistency with plugin (NFC)

Author: Jonas Devlieghere Date: 2020-01-21T15:02:41-08:00 New Revision: 0feedebf4f4b2a888c0d66e2347342234b6fc5ff URL: https://github.com/llvm/llvm-project/commit/0feedebf4f4b2a888c0d66e2347342234b6fc5ff DIFF: https://github.com/llvm/llvm-project/commit/0feedebf4f4b2a888c0d66e2347342234b6fc5ff.d

[Lldb-commits] [lldb] be96042 - [lldb/Plugin] Move DisassemblerLLVMC for consistency with plugin (NFC)

Author: Jonas Devlieghere Date: 2020-01-21T15:17:29-08:00 New Revision: be9604247e33146b53f270fd35c4a7c4a44fda53 URL: https://github.com/llvm/llvm-project/commit/be9604247e33146b53f270fd35c4a7c4a44fda53 DIFF: https://github.com/llvm/llvm-project/commit/be9604247e33146b53f270fd35c4a7c4a44fda53.d

[Lldb-commits] [PATCH] D73112: [lldb/DWARF] Remove one more auto-dwo method

clayborg added a comment. Thanks for doing the cleanup. After we switched over to using the DWARFDie more, there are probably many more cleanups like this where the code didn't get converted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73112/new

[Lldb-commits] [lldb] fa00176 - Fix typos

Author: Adrian Prantl Date: 2020-01-21T15:32:34-08:00 New Revision: fa001767f0856118e8e7c8f12c31ef7c3afe2b4e URL: https://github.com/llvm/llvm-project/commit/fa001767f0856118e8e7c8f12c31ef7c3afe2b4e DIFF: https://github.com/llvm/llvm-project/commit/fa001767f0856118e8e7c8f12c31ef7c3afe2b4e.diff

[Lldb-commits] [PATCH] D73119: [lldb/Initializers] Rename plugins to match their entry points

JDevlieghere updated this revision to Diff 239452. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73119/new/ https://reviews.llvm.org/D73119 Files: lldb/source/API/SystemInitializerFull.cpp lldb/source/Plugins/CMakeLists.txt lldb/source/Plugins/DynamicLoader/POSIX-DYLD/CMakeLists.tx

[Lldb-commits] [PATCH] D73148: [lldb/Value] Report size of Value as size of underlying data buffer

vsk created this revision. vsk added reviewers: jingham, aprantl. Value::GetValueByteSize() assumes that the size of a Value is always equal to the size of the underlying variable's CompilerType. However, llvm's DWARF generator doesn't appear to create fresh types with new sizes when emitting frag

[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

clayborg added a comment. In D72748#1830638 , @labath wrote: > In D72748#1829956 , @JDevlieghere > wrote: > > > In D72748#1823945 , @labath wrote: > > > > > I didn't actuall

[Lldb-commits] [PATCH] D73148: [lldb/Value] Report size of Value as size of underlying data buffer

clayborg added a comment. Would it be better to just ensure that the buffer for DW_OP_piece is at least the size of the type instead? To do this right we would really need to track which bytes in the buffer are actually valid. This patch assumes we will always get the first N bytes of a value.

[Lldb-commits] [PATCH] D73119: [lldb/Initializers] Rename plugins to match their entry points

JDevlieghere added a comment. I think the remaining discrepancies between the plugin name and the directory make sense. For example, I don't really see the benefit of renaming `AppleObjCRuntime` to `LanguageRuntimeAppleObjeC`. The `ClangASTContext` is the exception, but I really don't want to r

[Lldb-commits] [PATCH] D69933: [ASTImporter] Limit imports of structs

clayborg added a comment. Clang AST contexts know how to complete types and is done via the external AST source code that will ask a type to complete itself. Each object file has an AST that knows how to lazily complete a type when and only when it is needed. Each object file also only knows ab

[Lldb-commits] [PATCH] D73148: [lldb/Value] Report size of Value as size of underlying data buffer

vsk added a comment. In D73148#1832704 , @clayborg wrote: > Would it be better to just ensure that the buffer for DW_OP_piece is at least > the size of the type instead? To do this right we would really need to track > which bytes in the buffer are actua

[Lldb-commits] [PATCH] D73148: [lldb/Value] Report size of Value as size of underlying data buffer

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. In D73148#1832762 , @vsk wrote: > In D73148#1832704 , @clayborg wrote: > > > Would it be better to just ens

[Lldb-commits] [PATCH] D73148: [lldb/Value] Report size of Value as size of underlying data buffer

clayborg added a comment. Actually it would be nice to have a test that will trigger on at least one build bot that runs ASAN? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73148/new/ https://reviews.llvm.org/D73148 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

JDevlieghere added a comment. I'm seeing some really weird behavior for the following two tests and I'm honestly kind of puzzled. ObjectFile/ELF/PT_LOAD-overlap-PT_TLS.yaml ObjectFile/ELF/PT_TLS-overlap-PT_LOAD.yaml They fail in the same way for a standalone build, both on macOS (http://gr

[Lldb-commits] [lldb] 1d1ebb9 - [lldb/Initializers] Move all ObjC initializers into AppleObjCRuntime

Author: Jonas Devlieghere Date: 2020-01-21T22:24:32-08:00 New Revision: 1d1ebb9e592bea931845296dd80a46fb46af2642 URL: https://github.com/llvm/llvm-project/commit/1d1ebb9e592bea931845296dd80a46fb46af2642 DIFF: https://github.com/llvm/llvm-project/commit/1d1ebb9e592bea931845296dd80a46fb46af2642.d

[Lldb-commits] [PATCH] D73121: [lldb/Initializers] Move all ObjC initializers into AppleObjCRuntime

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG1d1ebb9e592b: [lldb/Initializers] Move all ObjC initializers into AppleObjCRuntime (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] c9a39a8 - [lldb] Add a display name to ClangASTContext instances

Author: Raphael Isemann Date: 2020-01-22T08:54:10+01:00 New Revision: c9a39a896c95402ede07061380346c725556e308 URL: https://github.com/llvm/llvm-project/commit/c9a39a896c95402ede07061380346c725556e308 DIFF: https://github.com/llvm/llvm-project/commit/c9a39a896c95402ede07061380346c725556e308.dif

[Lldb-commits] [PATCH] D72391: [lldb] Add a display name to ClangASTContext instances

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9a39a896c95: [lldb] Add a display name to ClangASTContext instances (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D72391?vs=236786&id=239495#toc Repository: rG LLVM Gith