labath added a comment.
Herald added a subscriber: wuzish.

There are three names to consider here:

- the name of the cmake target
- the name of the main .h file
- the name of the folders the plugin is in

Here you seem to be standardizing the first two, sometimes at the expense 
breaking existing symmetry with the third one (lldbPluginProcessMacOSXKernel -> 
lldbPluginProcessKDP) . Could we make all three consistent? I don't know 
whether you'll need that for the auto-generation, but it sure won't hurt..


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73119/new/

https://reviews.llvm.org/D73119



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to