teemperor marked an inline comment as done.
teemperor added a comment.

I moved the single non-plugin call back to the original Full/Test subclasses so 
the name is now correct. Also I removed all the duplicated linking flags that I 
forgot to remove before.

I also don't think we should make this a header. With a header we still need to 
copy the linking flags around and it also deviates from the existing approach 
of using subclasses like SystemInitializerCommon (which anyway looks nicer).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73018/new/

https://reviews.llvm.org/D73018



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to