labath added a comment. In D73018#1830697 <https://reviews.llvm.org/D73018#1830697>, @teemperor wrote:
> I moved the single non-plugin call back to the original Full/Test subclasses > so the name is now correct. Also I removed all the duplicated linking flags > that I forgot to remove before. This still leaves the question of the script interpreter plugins, which are suspiciously *not* included in "all plugins". The script interpreters are quite special, so I think it's fine to handle them separately -- the question is just how to convey that distinction. Move them into a different top level folder? Call this `SystemInitializerMostPlugins` ? However, an even bigger question is what is the relationship of this patch and D73067 <https://reviews.llvm.org/D73067>? Right now, they seem to be taking the plugin system in two different directions, so I don't think it makes sense to accept either one before we decide what that direction is... ================ Comment at: lldb/source/API/SystemInitializerFull.h:21 /// internally by SBDebugger to initialize the system. -class SystemInitializerFull : public SystemInitializerCommon { +class SystemInitializerFull : public SystemInitializerAllPlugins { public: ---------------- Maybe call this SystemInitializerAPI, or SystemInitializer(Lib)LLDB.. Having both "Full" and "AllPlugins" is confusing... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73018/new/ https://reviews.llvm.org/D73018 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
