[Lldb-commits] [PATCH] D69400: [lldb] [Host/netbsd] Set Arg0 for 'platform process list -v'

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6712889f5f1: [lldb] [Host/netbsd] Set Arg0 for 'platform process list -v' (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D69425: [lldb] Fix broken -D option for breakpoint set command

poya created this revision. poya added a reviewer: jingham. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. BreakpointDummyOptionGroup was using //g_breakpoint_modify_options// rather than //g_breakpoint_dummy_options// causing the -D option for //breakpoint s

[Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

omjavaid marked an inline comment as done. omjavaid added a comment. We ll be dealing with Linux user mode and mostly aarch64 data registers except for cpsr, fpsr and fpcr. I think we should be fine but let me confirm this again from documentation. Further more, motivation behind these changes

[Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

labath added a comment. In D69371#1721077 , @omjavaid wrote: > We ll be dealing with Linux user mode and mostly aarch64 data registers > except for cpsr, fpsr and fpcr. I think we should be fine but let me confirm > this again from documentation. Right

[Lldb-commits] [PATCH] D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map

aprantl added a comment. @jingham may have a stronger opinion on this :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69422/new/ https://reviews.llvm.org/D69422 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map

aprantl added a comment. I think the reason why the gdb aliases aren't mentioned here is that intent was to train users in LLDB's more regular command syntax. That said, personally I wouldn't mind documenting them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

labath accepted this revision. labath added a comment. Thanks for bearing with me. :) Comment at: test/Shell/SymbolFile/DWARF/anon_class_w_and_wo_export_symbols.ll:21 +; RUN: lldb-test symbols -dump-clang-ast %t.o | FileCheck %s +; RUN: dwarfdump %t.o | FileCheck %s --check-pre

[Lldb-commits] [PATCH] D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map

kastiglione added a comment. Thanks. I thought this was reasonable since the documentation shows many uses of lldb aliases already. > intent was to train users in LLDB's more regular command syntax lldb's aliases, especially the regex ones, are great. In my experience, people prefer aliases, t

[Lldb-commits] [PATCH] D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map

kastiglione added a comment. fwiw I have a python command called `abbrev` that takes a command and shows you the alias you can use instead. (lldb) abbrev mem read -s 8 -c 10 -f x 0xfedcba00 x/10xg 0xfedcba00 (lldb) abbrev break set -f foo.c -l 123 b foo.c:23 (lldb) abbrev thread jump -

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

labath closed this revision. labath added a comment. Managed to commit this today (b37c659). We'll see what happens after a master restart. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69341/new/ https://reviews.llvm.org/D69341 ___ lldb-c

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

shafik updated this revision to Diff 226450. shafik marked an inline comment as done. shafik added a comment. Using llvm-dwarfdump instead of dwarfdump CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68961/new/ https://reviews.llvm.org/D68961 Files: include/lldb/Symbol/ClangASTContext.

[Lldb-commits] [lldb] 5934cd1 - [TableGen] Add asserts to make sure default values match property type

Author: Jonas Devlieghere Date: 2019-10-25T10:18:38-07:00 New Revision: 5934cd11ea3e15dd9f13a9ee960012b5b64463ec URL: https://github.com/llvm/llvm-project/commit/5934cd11ea3e15dd9f13a9ee960012b5b64463ec DIFF: https://github.com/llvm/llvm-project/commit/5934cd11ea3e15dd9f13a9ee960012b5b64463ec.d

[Lldb-commits] [PATCH] D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map

jingham added a comment. I have no objection to documenting the aliases we have. Having the ability to define shortcuts for common operations was one of the key pieces that allowed the straight command set to be laid out in an orderly fashion, which I think is great for discoverability. It's

[Lldb-commits] [lldb] 96601ec - ValueObject: Fix a crash related to children address type computation

Author: Pavel Labath Date: 2019-10-25T17:49:06Z New Revision: 96601ec28b7efe5abf3479a1aa91bcedb235bbbd URL: https://github.com/llvm/llvm-project/commit/96601ec28b7efe5abf3479a1aa91bcedb235bbbd DIFF: https://github.com/llvm/llvm-project/commit/96601ec28b7efe5abf3479a1aa91bcedb235bbbd.diff LOG:

[Lldb-commits] [PATCH] D69425: [lldb] Fix broken -D option for breakpoint set command

jingham added a comment. Ack, yes. That's definitely wrong. Could you write a test for this to make sure we don't break it in the future. This should fail if you make one target, set a breakpoint with the -D option, then make a second target and check that it has the breakpoint, so it should

[Lldb-commits] [PATCH] D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map

kastiglione added a comment. > I wonder if it is time to take the gdb commands out and just make this a task > -> lldb commands table? +1 from me > The abbrev script sounds cool. We have a bunch of useful Python examples in > examples/Python, this sounds like a perfect candidate for that if yo

[Lldb-commits] [PATCH] D69273: ValueObject: Fix a crash related to children address type computation

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rG96601ec28b7e: ValueObject: Fix a crash related to children address type computation (authored by labath). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 72105b9 - Fix compilation error in ObjectFileMachO::ParseSymtab

Author: Vedant Kumar Date: 2019-10-25T11:16:51-07:00 New Revision: 72105b9dcd67eb539b77a77c5ed3530da1171724 URL: https://github.com/llvm/llvm-project/commit/72105b9dcd67eb539b77a77c5ed3530da1171724 DIFF: https://github.com/llvm/llvm-project/commit/72105b9dcd67eb539b77a77c5ed3530da1171724.diff

[Lldb-commits] [lldb] 0877dd1 - [Driver] Force llvm to install its handlers before lldb's

Author: Vedant Kumar Date: 2019-10-25T11:19:10-07:00 New Revision: 0877dd14e4e85550f8e267b5ceeff1d3409c41ba URL: https://github.com/llvm/llvm-project/commit/0877dd14e4e85550f8e267b5ceeff1d3409c41ba DIFF: https://github.com/llvm/llvm-project/commit/0877dd14e4e85550f8e267b5ceeff1d3409c41ba.diff

[Lldb-commits] [PATCH] D69403: [Driver] Force llvm to install its handlers before lldb's

This revision was automatically updated to reflect the committed changes. Closed by commit rG0877dd14e4e8: [Driver] Force llvm to install its handlers before lldb's (authored by vsk). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [lldb] 738af7a - Add the ability to pass extra args to a Python breakpoint callback.

Author: Jim Ingham Date: 2019-10-25T14:05:07-07:00 New Revision: 738af7a6241c98164625b9cd1ba9f8af4e36f197 URL: https://github.com/llvm/llvm-project/commit/738af7a6241c98164625b9cd1ba9f8af4e36f197 DIFF: https://github.com/llvm/llvm-project/commit/738af7a6241c98164625b9cd1ba9f8af4e36f197.diff LO

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

labath added a comment. I'm sorry, this dropped off my radar. The only question I have here is about the createPythonInit.py script. If we're moving stuff to cmake, I am wondering if we shouldn't move that thing too? It doesn't look like the code is doing anything which would be hard to replica

[Lldb-commits] [PATCH] D69451: Inline variable only used in assertion

scw created this revision. scw added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This prevents unused variable warning/error in -DNDEBUG builds. The variable was introduced in rG5934cd11ea3e

[Lldb-commits] [lldb] 73a7a55 - lldb/COFF: Create a separate "section" for the file header

Author: Pavel Labath Date: 2019-10-25T22:11:53Z New Revision: 73a7a55c0ec976fecadd7a872d24d850f8cd793a URL: https://github.com/llvm/llvm-project/commit/73a7a55c0ec976fecadd7a872d24d850f8cd793a DIFF: https://github.com/llvm/llvm-project/commit/73a7a55c0ec976fecadd7a872d24d850f8cd793a.diff LOG:

[Lldb-commits] [PATCH] D69100: COFF: Create a separate "section" for the file header

labath closed this revision. labath added a comment. Committed as 73a7a55 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69100/new/ https://reviews.llvm.org/D69100 ___ l

[Lldb-commits] [lldb] 7c603a4 - lldb/minidump: Refactor memory region computation code

Author: Pavel Labath Date: 2019-10-25T22:33:32Z New Revision: 7c603a41e20f461cf38ec7359a9eaa118fc0db5d URL: https://github.com/llvm/llvm-project/commit/7c603a41e20f461cf38ec7359a9eaa118fc0db5d DIFF: https://github.com/llvm/llvm-project/commit/7c603a41e20f461cf38ec7359a9eaa118fc0db5d.diff LOG:

[Lldb-commits] [PATCH] D69035: minidump: Refactor memory region computation code

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7c603a41e20f: lldb/minidump: Refactor memory region computation code (authored by labath). Herald added a project: LLDB.

[Lldb-commits] [PATCH] D69451: Inline variable only used in assertion

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. PS: In the future please uploaded full-context diffs . Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D69451: Inline variable only used in assertion

JDevlieghere added a comment. Thanks! Please let me know if you need me to commit this for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69451/new/ https://reviews.llvm.org/D69451 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D69451: Inline variable only used in assertion

scw updated this revision to Diff 226512. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69451/new/ https://reviews.llvm.org/D69451 Files: lldb/utils/TableGen/LLDBPropertyDefEmitter.cpp Index: lldb/utils/TableGen/LLDBPropertyDefEmitter.cpp =

[Lldb-commits] [lldb] 10b5cd8 - [LLDB] Fix inline variable only used in assertion. (NFC)

Author: Jonas Devlieghere Date: 2019-10-25T15:47:17-07:00 New Revision: 10b5cd8ed5272d135ac75a94d3cf5854a0912f84 URL: https://github.com/llvm/llvm-project/commit/10b5cd8ed5272d135ac75a94d3cf5854a0912f84 DIFF: https://github.com/llvm/llvm-project/commit/10b5cd8ed5272d135ac75a94d3cf5854a0912f84.d

[Lldb-commits] [PATCH] D69451: Inline variable only used in assertion

This revision was automatically updated to reflect the committed changes. Closed by commit rG10b5cd8ed527: [LLDB] Fix inline variable only used in assertion. (NFC) (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69451/new/

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

amccarth added a comment. FYI: This broke the build for me. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:323 + const char *function_name, + StructuredData::ObjectSP extra_args_sp) {} This breaks some builds because it doesn't retur

[Lldb-commits] [PATCH] D69451: Inline variable only used in assertion

scw added a comment. Missed my alias and used the command line for other projects instead :/ Yes, please commit it for me as I don't have the permission. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69451/new/ https://reviews.llvm.org/D69451 _

[Lldb-commits] [PATCH] D69453: Modernize TestThreadStepOut.py

jingham created this revision. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. This test was timing out on the bots occasionally, so I was poking around at it. I didn't see any obvious reason why it would stall, but it had a slightly odd way of rendezv

[Lldb-commits] [lldb] 5a3c657 - Fix after 738af7a6241c98164625b9cd1ba9f8af4e36f197

Author: Adrian McCarthy Date: 2019-10-25T15:57:52-07:00 New Revision: 5a3c657f3e8fe83ed5074edee94fb2303cd5fa2e URL: https://github.com/llvm/llvm-project/commit/5a3c657f3e8fe83ed5074edee94fb2303cd5fa2e DIFF: https://github.com/llvm/llvm-project/commit/5a3c657f3e8fe83ed5074edee94fb2303cd5fa2e.dif

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb added a comment. In D69019#1721867 , @labath wrote: > I'm sorry, this dropped off my radar. The only question I have here is about > the createPythonInit.py script. If we're moving stuff to cmake, I am > wondering if we shouldn't move that thing too?

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

labath added a comment. Right. I see what you mean. But... does this have to happen at build time? Since the list of files is already known at configuration time, you should be able to generate the files in the "cmake" step (but still leave the copying for the build step, so that any changes t

[Lldb-commits] [PATCH] D69455: Correct size_t format specifier

scw created this revision. scw added a reviewer: jingham. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69455 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp Index: lldb/s

Re: [Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

Ack, sorry. Thanks for fixing it. Jim > On Oct 25, 2019, at 3:52 PM, Adrian McCarthy via Phabricator > wrote: > > amccarth added a comment. > > FYI: This broke the build for me. > > > > > Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:323 > + const c

[Lldb-commits] [PATCH] D69455: Correct size_t format specifier

scw updated this revision to Diff 226525. scw added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69455/new/ https://reviews.llvm.org/D69455 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp Index: lldb/source/Plugins/ScriptInterpret

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

mgorny added a comment. Well, I found another problem with these series, specifically starting at this commit. Any use of `script` in LLDB ends up with: (lldb) script True True close failed in file object destructor: IOError: [Errno 9] Bad file descriptor I'd suspect the same fd is usin