jingham added a comment.

I have no objection to documenting the aliases we have.  Having the ability to 
define shortcuts for common operations was one of the key pieces that allowed 
the straight command set to be laid out in an orderly fashion, which I think is 
great for discoverability.  It's really hard to do the latter and not have some 
commands be overly long to type.  This gives us the best of both worlds.

I personally am a little less fond of the complex regex commands, particularly 
ones like "b" that become their own little DSL and now you have to try to 
decode it's operations from looking at the regex matcher to figure out what is 
actually going to happen.  But I don't think I'm in the majority in that 
opinion.

It's a bit of a shame that our "list of aliases" is available as a gdb->lldb 
table.  The table is actually arranged by task, so it serves as a pretty good 
task -> full & short-cut lldb commands, but you wouldn't think to use it for 
that purpose if you were not a gdb user.  And it's a bit weird to have things 
in the table that don't have gdb equivalents.  I wonder if it is time to take 
the gdb commands out and just make this a task -> lldb commands table?

But anyway, these changes are fine.

The abbrev script sounds cool.  We have a bunch of useful Python examples in 
examples/Python, this sounds like a perfect candidate for that if you are free 
to contribute it.  We should figure out a mechanism to test and package the 
appropriate ones of these utilities with lldb distributions, not everything in 
lldb has to be built in...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69422/new/

https://reviews.llvm.org/D69422



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to