omjavaid marked an inline comment as done.
omjavaid added a comment.

We ll be dealing with Linux user mode and mostly aarch64 data registers except 
for cpsr, fpsr and fpcr. I think we should be fine but let me confirm this 
again from documentation.

Further more, motivation behind these changes is SVE register set which may 
exchange high volume of data due to large register sizes.



================
Comment at: 
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h:153-154
 
+  bool m_gpr_is_valid;
+  bool m_fpu_is_valid;
+
----------------
labath wrote:
> Please move these next to the members they are guarding.
Alright.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69371/new/

https://reviews.llvm.org/D69371



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to