teemperor accepted this revision.
teemperor added a comment.
Also LGTM! Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68422/new/
https://reviews.llvm.org/D68422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
sylvestre.ledru created this revision.
sylvestre.ledru added a reviewer: mgorny.
Herald added a subscriber: delcypher.
AFAIK, lit-cpuid is used by the tests.
Installing it causes LLVMExports*.cmake files to depend
on this program.
It causes some serious packaging issues as it would means
that llv
mgorny accepted this revision.
mgorny added a comment.
This revision is now accepted and ready to land.
WFM. You should really switch to stand-alone builds to avoid this kind of
issues and help us support it better ;-P.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68537/new/
https://r
sylvestre.ledru added a comment.
Sure, happy to try, do you have some docs on this? Thanks :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68537/new/
https://reviews.llvm.org/D68537
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: sylvestre
Date: Sat Oct 5 01:22:40 2019
New Revision: 373819
URL: http://llvm.org/viewvc/llvm-project?rev=373819&view=rev
Log:
Do not install lit-cpuid
Summary:
AFAIK, lit-cpuid is used by the tests.
Installing it causes LLVMExports*.cmake files to depend
on this program.
It causes some
mgorny added a comment.
I'm afraid I don't. Learned all of it the hard way. But the minimal effort way
is easy — you just install LLVM (with no other projects) first, then just cmake
in specific other projects (clang, etc.). Getting tests to run usually requires
having LLVM sources somewhere th
hhb marked an inline comment as done.
hhb added inline comments.
Comment at: lldb/CMakeLists.txt:42
+COMMAND ${PYTHON_EXECUTABLE}
+-c "import distutils.sysconfig, sys;
print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))"
+${CMAKE_INSTALL_PREFI
hhb marked an inline comment as not done.
hhb added inline comments.
Comment at: lldb/CMakeLists.txt:42
+COMMAND ${PYTHON_EXECUTABLE}
+-c "import distutils.sysconfig, sys;
print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))"
+${CMAKE_INSTALL_P
wallace updated this revision to Diff 223376.
wallace added a comment.
added a test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68293/new/
https://reviews.llvm.org/D68293
Files:
lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_c
mgorny added inline comments.
Comment at: lldb/CMakeLists.txt:42
+COMMAND ${PYTHON_EXECUTABLE}
+-c "import distutils.sysconfig, sys;
print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))"
+${CMAKE_INSTALL_PREFIX}
hhb wrote:
> hh
llunak created this revision.
llunak added a reviewer: clayborg.
llunak added a project: LLDB.
Herald added subscribers: lldb-commits, JDevlieghere, abidh.
The attached patch implements 'u' and 'd' keyboard shortcuts in lldb gui,
similar to gdb tui's shortcuts.
One obvious problem is that 'd' is
kwk added a comment.
@labath ah, I've just seen that you did accept the revision already. Will merge
it then after running tests once more.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66791/new/
https://reviews.llvm.org/D66791
___
kwk updated this revision to Diff 223381.
kwk marked 10 inline comments as done.
kwk added a comment.
- Fix typo: s/a. /a ./
- Fix comment header
- Remove redundant input buffer check
- Remove another redundant input buffer check
- Change variable initialization to assign
- added comment about min
kwk added a comment.
@labath I've addressed all you comments. Thank you for answering
@jankratochvil's question as well. If this patch is good to go now, please give
a thumbs up.
Comment at: lldb/source/Host/common/LZMA.cpp:84
+ lzma_ret xzerr = lzma_stream_footer_decode(
+
kwk updated this revision to Diff 223382.
kwk added a comment.
Rebased onto current master
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66791/new/
https://reviews.llvm.org/D66791
Files:
lldb/cmake/modules/LLDBConfig.cmake
lldb/include/lldb/Ho
kwk added a comment.
@labath as much as I would love to merge this patch I get errors from these
tests that I didn't see before. They only appear after rebasing onto master:
Failing Tests (4):
lldb-Suite :: commands/process/attach/TestProcessAttach.py
lldb-Suite :: python_api/hello
lawrence_danna created this revision.
lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath.
Herald added a project: LLDB.
dotest.py currently requires a filterspec to be of the
form `TestCase.test_method`. This patch makes it more
flexible, so you can pass `TestModule.TestCase.test
lawrence_danna updated this revision to Diff 223389.
lawrence_danna added a comment.
rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68188/new/
https://reviews.llvm.org/D68188
Files:
lldb/include/lldb/API/SBFile.h
lldb/packages/Python/ll
lawrence_danna updated this revision to Diff 223391.
lawrence_danna marked an inline comment as done.
lawrence_danna added a comment.
rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68434/new/
https://reviews.llvm.org/D68434
Files:
lldb/in
lawrence_danna updated this revision to Diff 223392.
lawrence_danna added a comment.
rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68444/new/
https://reviews.llvm.org/D68444
Files:
lldb/source/API/SBDebugger.cpp
lldb/source/Core/IOHand
lawrence_danna updated this revision to Diff 223390.
lawrence_danna added a comment.
rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68433/new/
https://reviews.llvm.org/D68433
Files:
lldb/packages/Python/lldbsuite/test/python_api/file_hand
lawrence_danna created this revision.
lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath.
Herald added a project: LLDB.
This patch adds FileSP and SBFile versions of the API methods
ReportEventState and HandleProcessEvent. It points the SWIG
wrappers at these instead of the on
lawrence_danna updated this revision to Diff 223394.
lawrence_danna added a comment.
oops, remove unnecessary FileSP reference from interface file
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68546/new/
https://reviews.llvm.org/D68546
Files:
ll
lawrence_danna updated this revision to Diff 223395.
lawrence_danna added a comment.
add safe PythonModule functions and use them
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68188/new/
https://reviews.llvm.org/D68188
Files:
lldb/include/lldb/A
lawrence_danna created this revision.
lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath, zturner.
Herald added a project: LLDB.
Python APIs nearly all can return an exception. They do this
by returning NULL, or -1, or some such value and setting
the exception state with PyErr_Se
lawrence_danna updated this revision to Diff 223397.
lawrence_danna added a comment.
split off generic exception handling stuff into a separate patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68188/new/
https://reviews.llvm.org/D68188
Files:
llunak created this revision.
llunak added a reviewer: clayborg.
llunak added a project: LLDB.
Herald added subscribers: lldb-commits, JDevlieghere, aprantl.
BumpPtrAllocator allocates in 4KiB chunks, which with any larger project is
going to result in a large number of allocations. Increasing al
27 matches
Mail list logo
