hhb marked an inline comment as done.
hhb added inline comments.
================
Comment at: lldb/CMakeLists.txt:42
+ COMMAND ${PYTHON_EXECUTABLE}
+ -c "import distutils.sysconfig, sys;
print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))"
+ ${CMAKE_INSTALL_PREFIX}
----------------
mgorny wrote:
> I still like my `(False, False, '')` version better than having to
> recalculate path afterwards.
I don't have a strong opinion here. Let's see what labath@ think.
That been said, I did this because some distribution modified get_python_lib()
to return differently based on prefix. One example is Debian/Ubuntu, where
'dist-packages' will be used if prefix is '', '/usr' or '/usr/local'.
In reality, that only makes difference when CMAKE_INSTALL_PREFIX is set. But I
guess it doesn't really matter whether we use 'dist-packages' or
'site-packages' that time, as long as it is consistent everywhere.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68442/new/
https://reviews.llvm.org/D68442
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
