kwk added a comment. @labath as much as I would love to merge this patch I get errors from these tests that I didn't see before. They only appear after rebasing onto master:
Failing Tests (4): lldb-Suite :: commands/process/attach/TestProcessAttach.py lldb-Suite :: python_api/hello_world/TestHelloWorld.py lldb-Suite :: tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py lldb-Suite :: tools/lldb-vscode/attach/TestVSCode_attach.py I also get the same errors on current master .(revision 8815be04ec1f333564591d9593735f22efa9bee5 <https://reviews.llvm.org/rG8815be04ec1f333564591d9593735f22efa9bee5>) without my patch applied. But before I merrge my patch I'd like to see master in a better shape, no? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits