kwk added a comment.
@labath I've addressed all you comments. Thank you for answering
@jankratochvil's question as well. If this patch is good to go now, please give
a thumbs up.
================
Comment at: lldb/source/Host/common/LZMA.cpp:84
+ lzma_ret xzerr = lzma_stream_footer_decode(
+ &opts, InputBuffer.data() + InputBuffer.size() -
LZMA_STREAM_HEADER_SIZE);
+ if (xzerr != LZMA_OK) {
----------------
labath wrote:
> Maybe `InputBuffer.take_back(LZMA_STREAM_HEADER_SIZE).data()` ?
`take_back`:
> Return a copy of *this with only the last \p N elements.
I mean `LZMA_STREAM_HEADER_SIZE` is only 12 but do we really need it?
================
Comment at: lldb/source/Host/common/LZMA.cpp:104-105
+ lzma_index_buffer_decode(&xzindex, &memlimit, nullptr,
+ InputBuffer.data() + InputBuffer.size() -
+ LZMA_STREAM_HEADER_SIZE -
opts.backward_size,
+ &inpos, InputBuffer.size());
----------------
labath wrote:
> same here.
Same answer here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66791/new/
https://reviews.llvm.org/D66791
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
