[Lldb-commits] [PATCH] D61587: [lldb] Added support for dwarf expressions DW_OP_call2/DW_OP_call4

Chirag updated this revision to Diff 198439. Chirag added a comment. Fixed as per comments. passed proper execution/register context. for the time being DW_OP_piece is not allowed in call op. Working on testcase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61587/new/ https://reviews.

[Lldb-commits] [lldb] r360148 - [lldb] [lit] Fix Register tests to reference arrays via %0 and %1

Author: mgorny Date: Tue May 7 07:02:11 2019 New Revision: 360148 URL: http://llvm.org/viewvc/llvm-project?rev=360148&view=rev Log: [lldb] [lit] Fix Register tests to reference arrays via %0 and %1 Fix Register tests to reference memory access to arrays via %0 and %1, rather than via referencing

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D61578#1492422 , @JDevlieghere wrote: > In D61578#1492086 , @clayborg wrote: > > > Just wanted to verify th

[Lldb-commits] [PATCH] D61587: [lldb] Added support for dwarf expressions DW_OP_call2/DW_OP_call4

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. A few nits and waiting for the test case. Comment at: source/Expression/DWARFExpression.cpp:2701-2704 + auto ref_die = dwarf_cu->GetDIE(die_ref_offset); +

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds like a reasonable thing to do. If you're going to be looking into jitted code more, I'd strongly encourage you to try to come up with a testing strategy here. Setting up a smoke test wh

[Lldb-commits] [lldb] r360158 - RegisterContextLLDB: Push CFA value on DWARF stack when evaluating register expressions

Author: labath Date: Tue May 7 08:27:35 2019 New Revision: 360158 URL: http://llvm.org/viewvc/llvm-project?rev=360158&view=rev Log: RegisterContextLLDB: Push CFA value on DWARF stack when evaluating register expressions Summary: This behavior is specified in the Section 6.4.2.3 (Register Rule i

[Lldb-commits] [PATCH] D61018: RegisterContextLLDB: Push CFA value on DWARF stack when evaluating register expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rL360158: RegisterContextLLDB: Push CFA value on DWARF stack when evaluating register… (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[Lldb-commits] [lldb] r360161 - Added missing files from 360071.

Author: gclayton Date: Tue May 7 08:37:28 2019 New Revision: 360161 URL: http://llvm.org/viewvc/llvm-project?rev=360161&view=rev Log: Added missing files from 360071. Added: lldb/trunk/unittests/Symbol/Inputs/inlined-functions.yaml lldb/trunk/unittests/Symbol/TestLineEntry.cpp Modified:

Re: [Lldb-commits] [lldb] r360076 - Fix the cmake build by removing non-existant source file

Thanks for doing this. Just checked the files in with: $ svn commit Sendingunittests/Symbol/CMakeLists.txt Adding unittests/Symbol/Inputs/inlined-functions.yaml Adding unittests/Symbol/TestLineEntry.cpp Transmitting file data ...done Committing transaction... Committed revi

[Lldb-commits] [PATCH] D61311: PostfixExpression: Use signed integers in IntegerNode

This revision was automatically updated to reflect the committed changes. Closed by commit rL360166: PostfixExpression: Use signed integers in IntegerNode (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[Lldb-commits] [lldb] r360166 - PostfixExpression: Use signed integers in IntegerNode

Author: labath Date: Tue May 7 08:58:20 2019 New Revision: 360166 URL: http://llvm.org/viewvc/llvm-project?rev=360166&view=rev Log: PostfixExpression: Use signed integers in IntegerNode Summary: This is necessary to support parsing expressions like ".cfa -16 + ^", as that format is used in break

[Lldb-commits] [lldb] r360168 - Make eh-frame-dwarf-unwind.test run on non-linux platforms

Author: labath Date: Tue May 7 09:13:05 2019 New Revision: 360168 URL: http://llvm.org/viewvc/llvm-project?rev=360168&view=rev Log: Make eh-frame-dwarf-unwind.test run on non-linux platforms This was meant to be a part of r360158, but I forgot to squash the commits before pushing. Added: ll

[Lldb-commits] [lldb] r360169 - Fixup r360161

Author: labath Date: Tue May 7 09:13:10 2019 New Revision: 360169 URL: http://llvm.org/viewvc/llvm-project?rev=360169&view=rev Log: Fixup r360161 Remove SymbolVendorMacOSX from the test, as this plugin is not available on non-mac platforms, and it does not seem to be necessary anyway. Declare i

[Lldb-commits] [PATCH] D61565: Ignore generated @import statements in the expression evaluator to fix import-std-module tests on macOS

aprantl added a comment. A slightly more elegant solution might be to inject a #line directive that changes to a different source file for the code that the user entered. I've been long wanting to make `expr -g` more palatable to end users by hiding the LLDB-injected code in a separate source f

[Lldb-commits] [PATCH] D61423: MinidumpYAML: add support for the ThreadList stream

jhenderson added inline comments. Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:57 +/// instantiations can be used to represent the ModuleList stream and other +/// streams with similar structure. +template with -> with a Comment at: incl

[Lldb-commits] [PATCH] D61565: Ignore generated @import statements in the expression evaluator to fix import-std-module tests on macOS

aprantl added a comment. To clarify: I'd like `expr -g` to write out one temporary file (`lldb-expr.mm`) that only contains the code the user typed and in the expression. The expression should say @implementation $__lldb_objc_class ($__lldb_category) +(void)%s:(void *)$__lldb_arg { #lin

[Lldb-commits] [PATCH] D61482: [DWARF] Store compile unit IDs in the DIERef class

labath planned changes to this revision. labath added a comment. My understanding of the DIERef class has evolved. I'm going to revise this approach a bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61482/new/ https://reviews.llvm.org/D61482 __

[Lldb-commits] [lldb] r360172 - [Driver] Add command line option to allow loading local lldbinit file.

Author: jdevlieghere Date: Tue May 7 09:57:17 2019 New Revision: 360172 URL: http://llvm.org/viewvc/llvm-project?rev=360172&view=rev Log: [Driver] Add command line option to allow loading local lldbinit file. This patch adds a command line flag that allows lldb to load local lldbinit files. Dif

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

This revision was automatically updated to reflect the committed changes. Closed by commit rL360172: [Driver] Add command line option to allow loading local lldbinit file. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[Lldb-commits] [PATCH] D61606: Add support for importing general C++ modules into the LLDB expression evaluator

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/CompileUnit.h:397 std::vector m_imported_modules; + /// All modules, including the current module, used directly or indirectly + /// by this compile unit. All *Clang/Source* modules? Otherwi

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

jingham added a comment. In D61578#1493452 , @labath wrote: > In D61578#1492422 , @JDevlieghere > wrote: > > > In D61578#1492086 , @clayborg > > wrote: > > > > > Just wante

Re: [Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

On Tue, May 7, 2019 at 10:33 AM Jim Ingham via Phabricator < revi...@reviews.llvm.org> wrote: > jingham added a comment. > > In D61578#1493452 , @labath > wrote: > > > In D61578#1492422 , > @JDevlieghere wrote: > > >

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

labath added a comment. In D61578#1493863 , @jingham wrote: > The dotest.py tests all disable reading the global .lldbinit file. Do the > lit tests not do that as well? For tests that actually test reading the > user's .lldbinit file we will need to do

[Lldb-commits] [lldb] r360178 - [Host] Clean up dependencies of HostMacOSXObjCXX

Author: xiaobai Date: Tue May 7 11:08:06 2019 New Revision: 360178 URL: http://llvm.org/viewvc/llvm-project?rev=360178&view=rev Log: [Host] Clean up dependencies of HostMacOSXObjCXX Modified: lldb/trunk/source/Host/macosx/objcxx/CMakeLists.txt Modified: lldb/trunk/source/Host/macosx/objcxx/

[Lldb-commits] [PATCH] D61578: [Driver] Add command line option to allow loading local lldbinit file

jingham added a comment. In D61578#1493875 , @labath wrote: > In D61578#1493863 , @jingham wrote: > > > The dotest.py tests all disable reading the global .lldbinit file. Do the > > lit tests not do that as well?

[Lldb-commits] [lldb] r360182 - Disable eh-frame-dwarf-unwind.test on windows

Author: labath Date: Tue May 7 12:24:28 2019 New Revision: 360182 URL: http://llvm.org/viewvc/llvm-project?rev=360182&view=rev Log: Disable eh-frame-dwarf-unwind.test on windows It fails on the windows bot. Disable until I can figure out what's the reason. Modified: lldb/trunk/lit/Unwind/eh

[Lldb-commits] [PATCH] D61648: [DWARF] Centralize user_id <-> DWARFDIE conversions

labath created this revision. labath added reviewers: JDevlieghere, clayborg, aprantl. The logic for translating a user_id into a DWARFDIE was replicated in several places. This removes that redundancy and settles on a single implementation in SymbolFileDWARF. The reason for choosing that instead

[Lldb-commits] [PATCH] D61648: [DWARF] Centralize user_id <-> DWARFDIE conversions

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:137 - SymbolFileDWARF *GetDWARFForUID(lldb::user_id_t uid); - - DWARFDIE - GetDIEFromUID(lldb::user_id_t uid); + DWARFDIE GetDIEFromUID(lldb::user_id_t uid); + lldb::user_id_t Get

[Lldb-commits] [lldb] r360193 - [Core] Remove unused dependencies

Author: xiaobai Date: Tue May 7 14:34:44 2019 New Revision: 360193 URL: http://llvm.org/viewvc/llvm-project?rev=360193&view=rev Log: [Core] Remove unused dependencies Modified: lldb/trunk/source/Core/CMakeLists.txt Modified: lldb/trunk/source/Core/CMakeLists.txt URL: http://llvm.org/viewvc

[Lldb-commits] [PATCH] D61579: Propagate command interpreter errors from lldlbinit

jingham added a comment. I wonder if it would make this a little more convenient if we added a SetNoisy as the opposite of SetSilent? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61579/new/ https://reviews.llvm.org/D61579 __

[Lldb-commits] [PATCH] D61659: Fix bug in ArchSpec::MergeFrom

clayborg created this revision. clayborg added reviewers: labath, zturner, jingham. Previous ArchSpec tests didn't catch this bug since we never tested just the OS being out of date. Fixed the bug and covered this with a test that would catch this. This was found when trying to load a core file

[Lldb-commits] [PATCH] D61579: Propagate command interpreter errors from lldlbinit

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Seems plausible. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2472 + flags |= eHandleCommandFlagPrintErrors; +} else if (m_command_source_flags.back(

[Lldb-commits] [PATCH] D61659: Fix bug in ArchSpec::MergeFrom

xiaobai added a comment. Ah, this was my bad. Thanks for taking care of this. Comment at: unittests/Utility/ArchSpecTest.cpp:188-193 +EXPECT_EQ(llvm::Triple::ArchType::arm, B.GetTriple().getArch()); +EXPECT_EQ(llvm::Triple::VendorType::UnknownVendor, + B.Ge

[Lldb-commits] [PATCH] D61579: Propagate command interpreter errors from lldlbinit

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2472 + flags |= eHandleCommandFlagPrintErrors; +} else if (m_command_source_flags.back() & eHandleCommandFlagPrintErrors) { +

[Lldb-commits] [PATCH] D61579: Propagate command interpreter errors from lldlbinit

jingham added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2472 + flags |= eHandleCommandFlagPrintErrors; +} else if (m_command_source_flags.back() & eHandleCommandFlagPrintErrors) { + flags |= eHandleCommandFlagPrintErrors; --

[Lldb-commits] [lldb] r360208 - [Expression] Remove unused dependency

Author: xiaobai Date: Tue May 7 16:11:05 2019 New Revision: 360208 URL: http://llvm.org/viewvc/llvm-project?rev=360208&view=rev Log: [Expression] Remove unused dependency lldbExpression was linking against lldbPluginExpressionParserClang, and lldbPluginExpressionParserClang was linking against l

[Lldb-commits] [lldb] r360209 - [Docs] Add timestamp

Author: jdevlieghere Date: Tue May 7 16:14:06 2019 New Revision: 360209 URL: http://llvm.org/viewvc/llvm-project?rev=360209&view=rev Log: [Docs] Add timestamp Modified: lldb/trunk/docs/conf.py Modified: lldb/trunk/docs/conf.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/docs/conf.p

[Lldb-commits] [lldb] r360216 - Propagate command interpreter errors from lldlbinit

Author: jdevlieghere Date: Tue May 7 18:23:47 2019 New Revision: 360216 URL: http://llvm.org/viewvc/llvm-project?rev=360216&view=rev Log: Propagate command interpreter errors from lldlbinit This patch ensures that we propagate errors coming from the lldbinit file trough the command/script interp

[Lldb-commits] [PATCH] D61579: Propagate command interpreter errors from lldlbinit

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB360216: Propagate command interpreter errors from lldlbinit (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D61579?vs=198215&id=198571#toc Repository:

[Lldb-commits] [PATCH] D61648: [DWARF] Centralize user_id <-> DWARFDIE conversions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Greg's suggestion for an overload seems reasonable. Otherwise LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61648/new/ https://reviews.llvm.org/D61648 ___

[Lldb-commits] [lldb] r360218 - [Docs] Re-order homepage: Download -> Build -> Test

Author: jdevlieghere Date: Tue May 7 18:38:12 2019 New Revision: 360218 URL: http://llvm.org/viewvc/llvm-project?rev=360218&view=rev Log: [Docs] Re-order homepage: Download -> Build -> Test I also reformatted some paragraphs to 80 cols. Modified: lldb/trunk/docs/index.rst lldb/trunk/doc

[Lldb-commits] [lldb] r360219 - [Docs] Fix incorrect heading and update titles.

Author: jdevlieghere Date: Tue May 7 18:51:26 2019 New Revision: 360219 URL: http://llvm.org/viewvc/llvm-project?rev=360219&view=rev Log: [Docs] Fix incorrect heading and update titles. This patch fixes two incorrect headings in source.rst which caused it to show up on the homepage. I also updat