xiaobai added a comment. Ah, this was my bad. Thanks for taking care of this.
================ Comment at: unittests/Utility/ArchSpecTest.cpp:188-193 + EXPECT_EQ(llvm::Triple::ArchType::arm, B.GetTriple().getArch()); + EXPECT_EQ(llvm::Triple::VendorType::UnknownVendor, + B.GetTriple().getVendor()); + EXPECT_EQ(llvm::Triple::OSType::Linux, B.GetTriple().getOS()); + EXPECT_EQ(llvm::Triple::EnvironmentType::UnknownEnvironment, + B.GetTriple().getEnvironment()); ---------------- I think it might be a good idea to assert A's values here to show that nothing changed except the OS after the `MergeFrom` call. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61659/new/ https://reviews.llvm.org/D61659 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
